Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Thu, 27 Feb 2025 19:57:37 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: izumi.kuramura@gmail.com, pgsql-docs@lists.postgresql.org
Message-Id: <73133eb7-d8ef-4b3f-a9da-c03d12252501@app.fastmail.com>
In-Reply-To: 
 <174037994589.898582.18052583186032701533@wrigleys.postgresql.org>
References: 
 <174037994589.898582.18052583186032701533@wrigleys.postgresql.org>
Subject: Re: correction
Content-Type: multipart/mixed;
 boundary=86811d17caa54cd6b35a71be95d3ce66
Archived-At: 
 <https://www.postgresql.org/message-id/73133eb7-d8ef-4b3f-a9da-c03d12252501%40app.fastmail.com>
Precedence: bulk

--86811d17caa54cd6b35a71be95d3ce66
Content-Type: multipart/alternative;
 boundary=2e9faafc4cdb4a509411eb75e5225481

--2e9faafc4cdb4a509411eb75e5225481
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Mon, Feb 24, 2025, at 3:52 AM, PG Doc comments form wrote:
> hi i found a tiny error below:
> https://www.postgresql.org/docs/current/routine-vacuuming.html
> >Drop any old replication slots. Use pg_stat_replication to find slots where
> age(xmin) or age(catalog_xmin) is large. In many cases, such slots were
> created for replication to servers that no longer exist, or that have been
> down for a long time.
> 
> not pg_stat_replication but pg_replication_slots 
> because pg_stat_replication has neither 
> xmin nor catalog_xmin.
> 

Good catch! This seems an oversight in commit a70bce43fbc that was
backpatched down to v14. The attached patch should fix it.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--2e9faafc4cdb4a509411eb75e5225481
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Feb 24,=
 2025, at 3:52 AM, PG Doc comments form wrote:<br></div><blockquote type=
=3D"cite" id=3D"qt" style=3D""><div>hi i found a tiny error below:<br></=
div><div><a href=3D"https://www.postgresql.org/docs/current/routine-vacu=
uming.html">https://www.postgresql.org/docs/current/routine-vacuuming.ht=
ml</a><br></div><div>&gt;Drop any old replication slots. Use pg_stat_rep=
lication to find slots where<br></div><div>age(xmin) or age(catalog_xmin=
) is large. In many cases, such slots were<br></div><div>created for rep=
lication to servers that no longer exist, or that have been<br></div><di=
v>down for a long time.<br></div><div><br></div><div>not pg_stat_replica=
tion but pg_replication_slots&nbsp;<br></div><div>because pg_stat_replic=
ation has neither&nbsp;<br></div><div>xmin nor catalog_xmin.<br></div><d=
iv><br></div></blockquote><div><br></div><div>Good catch! This seems an =
oversight in commit a70bce43fbc that was<br></div><div>backpatched down =
to v14. The attached patch should fix it.<br style=3D"max-width:100%;hei=
ght:auto;"></div><div><br></div><div><br></div><div id=3D"sig112409080">=
<div class=3D"signature">--<br></div><div class=3D"signature">Euler Tave=
ira<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D"https:/=
/www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></div></div=
><div><br></div></body></html>
--2e9faafc4cdb4a509411eb75e5225481--

--86811d17caa54cd6b35a71be95d3ce66
Content-Disposition: attachment; filename="doc-fix.patch"
Content-Type: text/x-patch; name="doc-fix.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tYWludGVuYW5jZS5zZ21sIGIvZG9jL3NyYy9z
Z21sL21haW50ZW5hbmNlLnNnbWwKaW5kZXggYjViOWRhN2Y4YTkuLjI3ZGU1OTNhN2I4IDEw
MDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvbWFpbnRlbmFuY2Uuc2dtbAorKysgYi9kb2Mvc3Jj
L3NnbWwvbWFpbnRlbmFuY2Uuc2dtbApAQCAtNzE0LDggKzcxNCw4IEBAIEhJTlQ6ICBFeGVj
dXRlIGEgZGF0YWJhc2Utd2lkZSBWQUNVVU0gaW4gdGhhdCBkYXRhYmFzZS4KICAgICAgPC9s
aXN0aXRlbT4KICAgICAgPGxpc3RpdGVtPgogICAgICAgPHNpbXBhcmE+RHJvcCBhbnkgb2xk
IHJlcGxpY2F0aW9uIHNsb3RzLiBVc2UKLSAgICAgICA8bGluayBsaW5rZW5kPSJtb25pdG9y
aW5nLXBnLXN0YXQtcmVwbGljYXRpb24tdmlldyI+cGdfc3RhdF9yZXBsaWNhdGlvbjwvbGlu
az4gdG8KLSAgICAgICBmaW5kIHNsb3RzIHdoZXJlIDxsaXRlcmFsPmFnZSh4bWluKTwvbGl0
ZXJhbD4gb3IgPGxpdGVyYWw+YWdlKGNhdGFsb2dfeG1pbik8L2xpdGVyYWw+CisgICAgICAg
PGxpbmsgbGlua2VuZD0idmlldy1wZy1yZXBsaWNhdGlvbi1zbG90cyI+PHN0cnVjdG5hbWU+
cGdfcmVwbGljYXRpb25fc2xvdHM8L3N0cnVjdG5hbWU+PC9saW5rPgorICAgICAgIHRvIGZp
bmQgc2xvdHMgd2hlcmUgPGxpdGVyYWw+YWdlKHhtaW4pPC9saXRlcmFsPiBvciA8bGl0ZXJh
bD5hZ2UoY2F0YWxvZ194bWluKTwvbGl0ZXJhbD4KICAgICAgICBpcyBsYXJnZS4gSW4gbWFu
eSBjYXNlcywgc3VjaCBzbG90cyB3ZXJlIGNyZWF0ZWQgZm9yIHJlcGxpY2F0aW9uIHRvIHNl
cnZlcnMgdGhhdCBubwogICAgICAgIGxvbmdlciBleGlzdCwgb3IgdGhhdCBoYXZlIGJlZW4g
ZG93biBmb3IgYSBsb25nIHRpbWUuIElmIHlvdSBkcm9wIGEgc2xvdCBmb3IgYSBzZXJ2ZXIK
ICAgICAgICB0aGF0IHN0aWxsIGV4aXN0cyBhbmQgbWlnaHQgc3RpbGwgdHJ5IHRvIGNvbm5l
Y3QgdG8gdGhhdCBzbG90LCB0aGF0IHJlcGxpY2EgbWF5Cg==

--86811d17caa54cd6b35a71be95d3ce66--