Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odYqN-0000A1-QH for pgsql-docs@arkaria.postgresql.org; Wed, 28 Sep 2022 15:19:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1odYqM-000103-MT for pgsql-docs@arkaria.postgresql.org; Wed, 28 Sep 2022 15:19:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odYqM-0000zu-BR for pgsql-docs@lists.postgresql.org; Wed, 28 Sep 2022 15:19:26 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1odYqF-0007mT-1A for pgsql-docs@lists.postgresql.org; Wed, 28 Sep 2022 15:19:25 +0000 Received: by mail-ej1-x635.google.com with SMTP id lh5so27850543ejb.10 for ; Wed, 28 Sep 2022 08:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date; bh=EXpu6lEIbIvwo1SV9jFTH2HyllC6F33Z0TSGVZ0Eakw=; b=YI3srJiugSwq4L5iVcTML2F3YEdi/niiQlkfqflSbG/FXbu3DjSanuQ7tSMJIwIEpV vp2N4dl/GmBdBh+9uL0yZ1W3mUfZUvSxKKnqtadabMcnZ4kRtfiVnnDHtN3veHkIuiMu hAE5KII866c/d7Qw+8YOAiL4PEtl/GVEd/UIo7J4VkCnd8mzwxRpd8T2hM24B9eK8FDE SYJf//qufdX3pz4JLYdS3nTbEMo1ao7qEJKAo2Lm2/CvvGaD143HDMsr9pFb2yVp+jRV 0EJ/qL7IQ8DB5DFIwdRdtJNetrkXgOA5uUbgkG6jEv704G0bT010tGS9FF5yQp7phnV4 Pbsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date; bh=EXpu6lEIbIvwo1SV9jFTH2HyllC6F33Z0TSGVZ0Eakw=; b=LmRFmgD1GvQwyyvJehwNKek5ewRZ5GTWn1ryO84WmePNw87z5IfHeO1fdxGjemgH7u LD7gpzrB45+cNRbU5WpK3q2dlHNI1F/UbQWVSEP5QUINjjwx02FruhpGpSnT5ZZofnsP /gKUa7Y7D+WhNxdGnPUJEa4IYP3Gu6D1fA41hxKWX93P6qZ7RLBZmRLp/Cff9Mkjs1SN tdm7ym1XySG6eDFd7HwZDz1bWGtF5frIo/R1MLw14KeCj0TiyMwGiuYatuq4YcfkdYpj Gj69WBLg0TAyIAH2LNwTU+x7cYXqqkMBi1/+lNVBFwPLRJV16mQnOg1bQOUd5lXJKDdy 0yQA== X-Gm-Message-State: ACrzQf2TAl2AAOBK437pYUbaga99d1UHS5JFanQStKpgWWTpAsIoHmEN HBI+Pw99sn7kToZoSyXU4rmMsSy4DcMR0A== X-Google-Smtp-Source: AMsMyM4gYndQYMuM8L3E+2wnEua8lMQH94Fsg+eS6ifJhSnwJWJw4qmDmWZU+HbQoR1zvsrpD2/wpQ== X-Received: by 2002:a17:906:2681:b0:783:6a92:4c38 with SMTP id t1-20020a170906268100b007836a924c38mr14837505ejc.75.1664378356560; Wed, 28 Sep 2022 08:19:16 -0700 (PDT) Received: from localhost.localdomain ([83.68.136.68]) by smtp.gmail.com with ESMTPSA id q18-20020a17090676d200b0077f324979absm2556207ejn.67.2022.09.28.08.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 08:19:16 -0700 (PDT) Message-ID: <73de8b6a2e14684638ee2211ea693f2d5fb495ce.camel@cybertec.at> Subject: Re: suggest about bpchar data type in the document From: Laurenz Albe To: Tom Lane Cc: yanliang lei , "pgsql-docs@lists.postgresql.org" Date: Wed, 28 Sep 2022 17:19:15 +0200 In-Reply-To: <3946522.1664376483@sss.pgh.pa.us> References: <120b3084.56b6.1833b5ffe4b.Coremail.msdnchina@163.com> <41fe0ea52f9803649ae876d4d14b2b7ca89ffc06.camel@cybertec.at> <3946522.1664376483@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="=-+QYOD9k6nA6wYBpTlCTo" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-+QYOD9k6nA6wYBpTlCTo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2022-09-28 at 10:48 -0400, Tom Lane wrote: > Laurenz Albe writes: > > > I think that adding "bpchar(n)" in table 8.4 would be a good thing. > > > Here is a patch for that. > > There would need to be some mention of it in the paras below, too. True. I think the attached should be sufficient. Yours, Laurenz Albe --=-+QYOD9k6nA6wYBpTlCTo Content-Disposition: attachment; filename="0001-Document-bpchar-as-character-data-type.V2.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-Document-bpchar-as-character-data-type.V2.patch"; charset="UTF-8" RnJvbSBkYTY4ZWI3NmU2MWQ4NmM5ZGU0NjQxMDdmYjc5MGZkNzNjYmEwMDA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h dD4KRGF0ZTogV2VkLCAyOCBTZXAgMjAyMiAxNzoxNzo0NSArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IERvY3VtZW50ICJicGNoYXIiIGFzIGNoYXJhY3RlciBkYXRhIHR5cGUKCiJicGNoYXIiIGlzIG91 ciBpbnRlcm5hbCBuYW1lIGZvciAiY2hhcmFjdGVyIiwgYnV0IGl0IHNob3VsZApzdGlsbCBiZSBk b2N1bWVudGVkIGFzIGFuIGFsdGVybmF0aXZlIG5hbWUgdG8gYXZvaWQgY29uZnVzaW9uLgoKUGVy IHJlcXVlc3QgZnJvbSBZYW5saWFuZyBMZWkuCgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5l cy9tLzEyMGIzMDg0LjU2YjYuMTgzM2I1ZmZlNGIuQ29yZW1haWwubXNkbmNoaW5hQDE2My5jb20K LS0tCiBkb2Mvc3JjL3NnbWwvZGF0YXR5cGUuc2dtbCB8IDExICsrKysrKy0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Rv Yy9zcmMvc2dtbC9kYXRhdHlwZS5zZ21sIGIvZG9jL3NyYy9zZ21sL2RhdGF0eXBlLnNnbWwKaW5k ZXggMDI1OGIxOTJlMC4uMTRkNjNiN2JiYyAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL2RhdGF0 eXBlLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2RhdGF0eXBlLnNnbWwKQEAgLTExNjksNyArMTE2 OSw3IEBAIFNFTEVDVCAnNTIwOTMuODknOjptb25leTo6bnVtZXJpYzo6ZmxvYXQ4OwogICAgICAg ICA8ZW50cnk+dmFyaWFibGUtbGVuZ3RoIHdpdGggbGltaXQ8L2VudHJ5PgogICAgICAgIDwvcm93 PgogICAgICAgIDxyb3c+Ci0gICAgICAgIDxlbnRyeT48dHlwZT5jaGFyYWN0ZXIoPHJlcGxhY2Vh YmxlPm48L3JlcGxhY2VhYmxlPik8L3R5cGU+LCA8dHlwZT5jaGFyKDxyZXBsYWNlYWJsZT5uPC9y ZXBsYWNlYWJsZT4pPC90eXBlPjwvZW50cnk+CisgICAgICAgIDxlbnRyeT48dHlwZT5jaGFyYWN0 ZXIoPHJlcGxhY2VhYmxlPm48L3JlcGxhY2VhYmxlPik8L3R5cGU+LCA8dHlwZT5jaGFyKDxyZXBs YWNlYWJsZT5uPC9yZXBsYWNlYWJsZT4pPC90eXBlPiwgPHR5cGU+YnBjaGFyKDxyZXBsYWNlYWJs ZT5uPC9yZXBsYWNlYWJsZT4pPC90eXBlPjwvZW50cnk+CiAgICAgICAgIDxlbnRyeT5maXhlZC1s ZW5ndGgsIGJsYW5rIHBhZGRlZDwvZW50cnk+CiAgICAgICAgPC9yb3c+CiAgICAgICAgPHJvdz4K QEAgLTEyMTMsMTAgKzEyMTMsMTEgQEAgU0VMRUNUICc1MjA5My44OSc6Om1vbmV5OjpudW1lcmlj OjpmbG9hdDg7CiAgICA8L3BhcmE+CiAKICAgIDxwYXJhPgotICAgIFRoZSBub3RhdGlvbnMgPHR5 cGU+dmFyY2hhcig8cmVwbGFjZWFibGU+bjwvcmVwbGFjZWFibGU+KTwvdHlwZT4gYW5kCi0gICAg PHR5cGU+Y2hhcig8cmVwbGFjZWFibGU+bjwvcmVwbGFjZWFibGU+KTwvdHlwZT4gYXJlIGFsaWFz ZXMgZm9yIDx0eXBlPmNoYXJhY3RlcgotICAgIHZhcnlpbmcoPHJlcGxhY2VhYmxlPm48L3JlcGxh Y2VhYmxlPik8L3R5cGU+IGFuZAotICAgIDx0eXBlPmNoYXJhY3Rlcig8cmVwbGFjZWFibGU+bjwv cmVwbGFjZWFibGU+KTwvdHlwZT4sIHJlc3BlY3RpdmVseS4KKyAgICBUaGUgbm90YXRpb24gPHR5 cGU+dmFyY2hhcig8cmVwbGFjZWFibGU+bjwvcmVwbGFjZWFibGU+KTwvdHlwZT4gaXMgYW4KKyAg ICBhbGlhcyBmb3IgPHR5cGU+Y2hhcmFjdGVyIHZhcnlpbmcoPHJlcGxhY2VhYmxlPm48L3JlcGxh Y2VhYmxlPik8L3R5cGU+LAorICAgIGFuZCA8dHlwZT5jaGFyKDxyZXBsYWNlYWJsZT5uPC9yZXBs YWNlYWJsZT4pPC90eXBlPiBhbmQKKyAgICA8dHlwZT5icGNoYXIoPHJlcGxhY2VhYmxlPm48L3Jl cGxhY2VhYmxlPik8L3R5cGU+IGFyZSBhbGlhc2VzIGZvcgorICAgIDx0eXBlPmNoYXJhY3Rlcig8 cmVwbGFjZWFibGU+bjwvcmVwbGFjZWFibGU+KTwvdHlwZT4uCiAgICAgSWYgc3BlY2lmaWVkLCB0 aGUgbGVuZ3RoIG11c3QgYmUgZ3JlYXRlciB0aGFuIHplcm8gYW5kIGNhbm5vdCBleGNlZWQKICAg ICAxMDQ4NTc2MC4KICAgICA8dHlwZT5jaGFyYWN0ZXI8L3R5cGU+IHdpdGhvdXQgbGVuZ3RoIHNw ZWNpZmllciBpcyBlcXVpdmFsZW50IHRvCi0tIAoyLjM3LjMKCg== --=-+QYOD9k6nA6wYBpTlCTo--