MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_db0af7783e72b020066f68d64a05cf84"
Content-Transfer-Encoding: 7bit
Date: Mon, 18 May 2020 22:31:35 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: daniel@yesql.se, a.lakhin@postgrespro.ru, pgsql-docs@postgresql.org
Subject: Re: Missing comma?
In-Reply-To: <20200518061619.GA1830@paquier.xyz>
References: <ad1a0badc32658b1bbb07aa312346a1d@postgrespro.ru>
 <5B3957FE-D31E-4838-B35C-C2F0EEC3E557@yesql.se>
 <6fa8ba75057b16f88010c2b945f720c0@postgrespro.ru>
 <20200514000738.GA166343@paquier.xyz>
 <226cae2ef0bf26a59011de38eec9c7f4@postgrespro.ru>
 <20200515021625.GD2462@paquier.xyz>
 <37b6de0c81a52af5c6a120cd3341ce28@postgrespro.ru>
 <20200518061619.GA1830@paquier.xyz>
User-Agent: Roundcube Webmail/1.4.0
Message-ID: <74011867ff6e9c35ad195d1c3e44ed6c@postgrespro.ru>
Organization: Postgres Professional
Precedence: bulk

--=_db0af7783e72b020066f68d64a05cf84
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2020-05-18 09:16, Michael Paquier wrote:
> On Sat, May 16, 2020 at 09:38:46PM +0300, Marina Polyakova wrote:
>> I like if we can explain the situation in more detail. But IMO the 
>> phrase
>> "same as default" sounds as if we will try to find the primary index 
>> and use
>> it if the required index (with pg_index.indisreplident = true) does 
>> not
>> exist. What do you think of "(same as nothing if the index used got
>> dropped)"? It seems that in this case we have the same behaviour:
>> - we cannot update or delete rows from the table if the action is 
>> published
>> because this table does not have a "working" replica identity;
>> - we cannot apply updates or deletes on subscriber until we have a 
>> primary
>> key or the published relation has replica identity full.
> 
> Yeah.  I was testing that once again today and you are right.  The
> publisher would just assume that there is nothing as there is in the
> changes nothing about the old row for a relation using a replident
> based on an index that got dropped, and this even if there is a
> primary key on the relation.  So using "same as nothing" would be
> fine.

Glad to hear this =)

> Would you like to send an updated patch?  Note that as the release of
> beta1 is planned for this week, we have a grace period until the
> version is tagged on HEAD.

The patch is attached, changes to html such as they were discussed.

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--=_db0af7783e72b020066f68d64a05cf84
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-Fix-the-description-of-the-field-pg_class.relreplide.patch
Content-Disposition: attachment;
 filename=0001-Fix-the-description-of-the-field-pg_class.relreplide.patch;
 size=1440

RnJvbSBjMzIwODVlZDBiZTEzZGExMmVlNTg4YzA3NTEzMDk4NzM3OGIzNDQ2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbmEgUG9seWFrb3ZhIDxtLnBvbHlha292YUBwb3N0Z3Jl
c3Byby5ydT4KRGF0ZTogTW9uLCAxOCBNYXkgMjAyMCAyMjoxOTo0NiArMDMwMApTdWJqZWN0OiBb
UEFUQ0hdIEZpeCB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIGZpZWxkIHBnX2NsYXNzLnJlbHJlcGxp
ZGVudAoKLSBBZGQgYSBjb21tYSBiZXR3ZWVuICJmID0gYWxsIGNvbHVtbnMiIGFuZCAiaSA9IGlu
ZGV4IHdpdGggLi4uIi4KLSBGaXggdGhlIGRlc2NyaXB0aW9uIG9mIHJlcGxpY2EgaWRlbnRpdHkg
aW5kZXggaWYgdGhlIGluZGV4IHVzZWQgZ290IGRyb3BwZWQKICAoaW4gdGhpcyBjYXNlIHdlIGNh
bm5vdCB1cGRhdGUgb3IgZGVsZXRlIHJvd3MgZnJvbSB0aGUgdGFibGUgaWYgdGhlIGFjdGlvbiBp
cwogIHB1Ymxpc2hlZCBldmVuIGlmIHRoZSB0YWJsZSBoYXMgYSBwcmltYXJ5IGluZGV4KS4KLS0t
CiBkb2Mvc3JjL3NnbWwvY2F0YWxvZ3Muc2dtbCB8IDYgKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwg
NCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dt
bC9jYXRhbG9ncy5zZ21sIGIvZG9jL3NyYy9zZ21sL2NhdGFsb2dzLnNnbWwKaW5kZXggYjFiMDc3
Yzk3Zi4uNThhMjVlOGU2OCAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL2NhdGFsb2dzLnNnbWwK
KysrIGIvZG9jL3NyYy9zZ21sL2NhdGFsb2dzLnNnbWwKQEAgLTIxNDEsOCArMjE0MSwxMCBAQCBT
Q1JBTS1TSEEtMjU2JDxyZXBsYWNlYWJsZT4mbHQ7aXRlcmF0aW9uIGNvdW50Jmd0OzwvcmVwbGFj
ZWFibGU+OjxyZXBsYWNlYWJsZT4mbAogICAgICAgIENvbHVtbnMgdXNlZCB0byBmb3JtIDxxdW90
ZT5yZXBsaWNhIGlkZW50aXR5PC9xdW90ZT4gZm9yIHJvd3M6CiAgICAgICAgPGxpdGVyYWw+ZDwv
bGl0ZXJhbD4gPSBkZWZhdWx0IChwcmltYXJ5IGtleSwgaWYgYW55KSwKICAgICAgICA8bGl0ZXJh
bD5uPC9saXRlcmFsPiA9IG5vdGhpbmcsCi0gICAgICAgPGxpdGVyYWw+ZjwvbGl0ZXJhbD4gPSBh
bGwgY29sdW1ucwotICAgICAgIDxsaXRlcmFsPmk8L2xpdGVyYWw+ID0gaW5kZXggd2l0aCA8c3Ry
dWN0ZmllbGQ+aW5kaXNyZXBsaWRlbnQ8L3N0cnVjdGZpZWxkPiBzZXQsIG9yIGRlZmF1bHQKKyAg
ICAgICA8bGl0ZXJhbD5mPC9saXRlcmFsPiA9IGFsbCBjb2x1bW5zLAorICAgICAgIDxsaXRlcmFs
Pmk8L2xpdGVyYWw+ID0gaW5kZXggd2l0aAorICAgICAgIDxzdHJ1Y3RmaWVsZD5pbmRpc3JlcGxp
ZGVudDwvc3RydWN0ZmllbGQ+IHNldCAoc2FtZSBhcyBub3RoaW5nIGlmIHRoZQorICAgICAgIGlu
ZGV4IHVzZWQgZ290IGRyb3BwZWQpCiAgICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgPC9yb3c+
CiAKLS0gCjIuMTcuMQoK
--=_db0af7783e72b020066f68d64a05cf84--