To: Bruce Momjian <bruce@momjian.us>
cc: gabrielle <gorthx@gmail.com>, pgsql-docs@postgresql.org
Subject: Re: [PATCH] log_statement docs 
In-reply-to: <201002251847.o1PIl3h23647@momjian.us> 
References: <201002251847.o1PIl3h23647@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Thu, 25 Feb 2010 13:47:03 -0500"
Date: Thu, 25 Feb 2010 14:07:57 -0500
Message-ID: <7494.1267124877@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Bruce Momjian <bruce@momjian.us> writes:
> gabrielle wrote:
>> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Shouldn't it just say "all means all", if we think that needs to be
>>> explained?
>> 
>> I think it should say something about the "all" option.  I read &
>> re-read that section trying to figure out what the difference between
>> "mod" and "all" was, and finally asked on the irc channel.  As it
>> stands, it essentially says "there are three options to this command,
>> but we're only going to tell you about two of them." :)

> Well, if you take a look at utility.c:GetCommandLogLevel() you will see
> that ALL includes a lot more commands than just SELECT.

Yeah.  My objection was not to documenting ALL, it was to documenting it
with exactly that sentence, which seems both needlessly complicated and
subject to errors of omission.

			regards, tom lane