From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <7657EDEE-5EE2-4AAB-BA95-47B4F71653E1@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_BC3219CF-6E27-477D-89A4-F4E27BC81354"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: Lower or Upper case for F.33. pg_trgm
Date: Tue, 16 Aug 2022 23:28:13 +0200
In-Reply-To: <1119558.1660658030@sss.pgh.pa.us>
Cc: Erik Rijkers <er@xs4all.nl>,
 marcmaiwald@googlemail.com,
 pgsql-docs@lists.postgresql.org
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <166064504415.652.12724576876807446945@wrigleys.postgresql.org>
 <65FB8525-EB15-4A22-B204-51385A088D64@yesql.se>
 <3856dba5-81c8-8221-90e6-5307679f9be7@xs4all.nl>
 <5B31E9AC-9F6B-47BB-85DB-188507CF6297@yesql.se>
 <4be605ae-7fbb-c47c-9c7f-f8965ff0ea9e@xs4all.nl>
 <1119558.1660658030@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/7657EDEE-5EE2-4AAB-BA95-47B4F71653E1%40yesql.se>
Precedence: bulk


--Apple-Mail=_BC3219CF-6E27-477D-89A4-F4E27BC81354
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On 16 Aug 2022, at 15:53, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Erik Rijkers <er@xs4all.nl> writes:
>> (bluntly stating 'similarity comparisons are case-insensitive' -=20
>> although I'm not really sure..)
>=20
> Perhaps like "similarity comparisons are case-insensitive in a
> standard build of pg_trgm", if you want to nod to the existence
> of a compile option without going into detail.

Looking at this I'm leaning towards paring down the diff posted upthread =
with
pretty much this, I think that will provide value while avoid causing
confusion.

As a related side note, there are four instances of "case =
insensitive{ly}" in
the docs with all other instances using "case-insensitive{ly}".  I'm =
inclined
to fix those four to use a dash while at it to be consistent across all =
pages.

--
Daniel Gustafsson		https://vmware.com/


--Apple-Mail=_BC3219CF-6E27-477D-89A4-F4E27BC81354
Content-Disposition: attachment;
	filename=pg_trgm_case.diff
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="pg_trgm_case.diff"
Content-Transfer-Encoding: 7bit

diff --git a/doc/src/sgml/pgtrgm.sgml b/doc/src/sgml/pgtrgm.sgml
index 7e29282255..fefe30afb7 100644
--- a/doc/src/sgml/pgtrgm.sgml
+++ b/doc/src/sgml/pgtrgm.sgml
@@ -416,6 +416,8 @@
    the above-described similarity operators, and additionally support
    trigram-based index searches for <literal>LIKE</literal>, <literal>ILIKE</literal>,
    <literal>~</literal>, <literal>~*</literal> and <literal>=</literal> queries.
+   The similarity comparisons are case-insensitive in a default build of
+   <filename>pg_trgm</filename>.
    Inequality operators are not supported.
    Note that those indexes may not be as efficient as regular B-tree indexes
    for equality operator.

--Apple-Mail=_BC3219CF-6E27-477D-89A4-F4E27BC81354--