Message-ID: <7dd9ec53-e58c-44fa-b4ef-b92c9b0a6005@oss.nttdata.com>
Date: Wed, 18 Jun 2025 09:21:18 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Reorder min/max_protocol_version descriptions in libpq
 documentation
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-docs@lists.postgresql.org
References: <a3391f36-30f5-4d4a-825b-232476819de8@oss.nttdata.com>
 <CAGECzQQ2MgUTsUAHESLhW47wA-S3V9vuBzUcP6qRfBY12xGMdA@mail.gmail.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CAGECzQQ2MgUTsUAHESLhW47wA-S3V9vuBzUcP6qRfBY12xGMdA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/7dd9ec53-e58c-44fa-b4ef-b92c9b0a6005%40oss.nttdata.com>
Precedence: bulk


On 2025/06/18 1:34, Jelte Fennema-Nio wrote:
> On Tue, 17 Jun 2025 at 18:32, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> Hi,
>>
>> Commit 285613c60a7 added the min_protocol_version and max_protocol_version
>> connection options to libpq. However, their descriptions currently appear
>> in the middle of the unrelated ssl_min_protocol_version and
>> ssl_max_protocol_version entries in libpq.sgml. Is there a reason for
>> this placement?
> 
> Not that I can remember, probably because I copied the
> ssl_min_protocol_version section when writing the initial version
> min_protocol_version section.
> 
>> To make the documentation more intuitive and easier to navigate,
>> I suggest moving these entries after the SSL-related options.
>> Attached is a patch that does that.
> 
> +1

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation