pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
Fix analyze_sampling docs in postgres-fdw.sgml 3+ messages / 3 participants [nested] [flat]
* Fix analyze_sampling docs in postgres-fdw.sgml @ 2024-03-04 05:27 Shinya Kato <Shinya11.Kato@oss.nttdata.com> 2024-03-04 08:37 ` Re: Fix analyze_sampling docs in postgres-fdw.sgml Laurenz Albe <laurenz.albe@cybertec.at> 0 siblings, 1 reply; 3+ messages in thread From: Shinya Kato @ 2024-03-04 05:27 UTC (permalink / raw) To: pgsql-docs@lists.postgresql.org Hi! I fixed analyze_sampling docs in postgres-fdw.sgml. - Changed analyze_sampling type 'text' to 'string' - Add a statement 'The option specified on a table overrides an option specified for the server.' Do you think? Regards, Shinya Kato NTT DATA GROUP CORPORATION Attachments: [text/x-diff] v1-0001-fix-analyze_sampling-docs.patch (1.1K, ../../7fd9166b9fda267411793f39986d7f24@oss.nttdata.com/2-v1-0001-fix-analyze_sampling-docs.patch) download | inline diff: diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml index 3c54a26c9a..13b0f46bbf 100644 --- a/doc/src/sgml/postgres-fdw.sgml +++ b/doc/src/sgml/postgres-fdw.sgml @@ -337,13 +337,14 @@ OPTIONS (ADD password_required 'false'); <variablelist> <varlistentry> - <term><literal>analyze_sampling</literal> (<type>text</type>)</term> + <term><literal>analyze_sampling</literal> (<type>string</type>)</term> <listitem> <para> This option, which can be specified for a foreign table or a foreign server, determines if <command>ANALYZE</command> on a foreign table samples the data on the remote side, or reads and transfers all data - and performs the sampling locally. The supported values + and performs the sampling locally. The option specified on a table + overrides an option specified for the server. The supported values are <literal>off</literal>, <literal>random</literal>, <literal>system</literal>, <literal>bernoulli</literal> and <literal>auto</literal>. <literal>off</literal> disables remote ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Fix analyze_sampling docs in postgres-fdw.sgml 2024-03-04 05:27 Fix analyze_sampling docs in postgres-fdw.sgml Shinya Kato <Shinya11.Kato@oss.nttdata.com> @ 2024-03-04 08:37 ` Laurenz Albe <laurenz.albe@cybertec.at> 2024-03-04 09:24 ` Re: Fix analyze_sampling docs in postgres-fdw.sgml Daniel Gustafsson <daniel@yesql.se> 0 siblings, 1 reply; 3+ messages in thread From: Laurenz Albe @ 2024-03-04 08:37 UTC (permalink / raw) To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>; pgsql-docs@lists.postgresql.org On Mon, 2024-03-04 at 14:27 +0900, Shinya Kato wrote: > I fixed analyze_sampling docs in postgres-fdw.sgml. > - Changed analyze_sampling type 'text' to 'string' +1 > - Add a statement 'The option specified on a table overrides an option > specified for the server.' I think that applies to all options. It would be better to have a general statement to that effect at the beginning of the "Options" section. Yours, Laurenz Albe ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Fix analyze_sampling docs in postgres-fdw.sgml 2024-03-04 05:27 Fix analyze_sampling docs in postgres-fdw.sgml Shinya Kato <Shinya11.Kato@oss.nttdata.com> 2024-03-04 08:37 ` Re: Fix analyze_sampling docs in postgres-fdw.sgml Laurenz Albe <laurenz.albe@cybertec.at> @ 2024-03-04 09:24 ` Daniel Gustafsson <daniel@yesql.se> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2024-03-04 09:24 UTC (permalink / raw) To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: Shinya Kato <Shinya11.Kato@oss.nttdata.com>; pgsql-docs@lists.postgresql.org > On 4 Mar 2024, at 09:37, Laurenz Albe <laurenz.albe@cybertec.at> wrote: > > On Mon, 2024-03-04 at 14:27 +0900, Shinya Kato wrote: >> I fixed analyze_sampling docs in postgres-fdw.sgml. >> - Changed analyze_sampling type 'text' to 'string' > > +1 Agreed, that should be changed, will fix. >> - Add a statement 'The option specified on a table overrides an option >> specified for the server.' > > I think that applies to all options. It would be better to have a general > statement to that effect at the beginning of the "Options" section. Yeah, that might be a good idead. -- Daniel Gustafsson ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-03-04 09:24 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-03-04 05:27 Fix analyze_sampling docs in postgres-fdw.sgml Shinya Kato <Shinya11.Kato@oss.nttdata.com> 2024-03-04 08:37 ` Laurenz Albe <laurenz.albe@cybertec.at> 2024-03-04 09:24 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox