Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvLn1-004ff2-QY for pgsql-docs@arkaria.postgresql.org; Tue, 24 Oct 2023 18:06:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qvLmx-00BCDy-VU for pgsql-docs@arkaria.postgresql.org; Tue, 24 Oct 2023 18:06:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvLmx-00BCDq-Mx for pgsql-docs@lists.postgresql.org; Tue, 24 Oct 2023 18:06:00 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvLmt-002VEJ-RO for pgsql-docs@lists.postgresql.org; Tue, 24 Oct 2023 18:05:59 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39OI5r5c831892; Tue, 24 Oct 2023 14:05:53 -0400 From: Tom Lane To: Bruce Momjian cc: "Jonathan S. Katz" , "David G. Johnston" , splarv@ya.ru, pgsql-docs@lists.postgresql.org Subject: Re: 'value' has special behaviour in alter system In-reply-to: References: <167105927893.1897.13227723035830709578@wrigleys.postgresql.org> <3417417.1671124227@sss.pgh.pa.us> Comments: In-reply-to Bruce Momjian message dated "Tue, 24 Oct 2023 13:07:28 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <831890.1698170753.1@sss.pgh.pa.us> Date: Tue, 24 Oct 2023 14:05:53 -0400 Message-ID: <831891.1698170753@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Bruce Momjian writes: > I have developed the attached patch to document this. This seems a little imprecise: + Values with non-alphanumeric characters must be quoted. I think accurate is more like "Values that are neither a number nor a valid identifier must be quoted." Also, that para already mentions that the input can be a comma-separated list when appropriate, so your add-on para seems partially repetitive. I think you could just drop the first sentence of it. regards, tom lane