public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: pgsql-docs <[email protected]>
Subject: PARALLEL in old syntax for CREATE AGGREGATE
Date: Mon, 27 Nov 2017 16:00:42 +0100
Message-ID: <[email protected]> (raw)
When looking at review comments on one of my patches, I noticed that commit
41ea0c23761 didn’t include the PARALLEL keyword for the old style CREATE
AGGREGATE syntax. Since it is supported, and commit 59b71c6fe6c use it in a
testcase, it seems reasonable to add something along the lines of the attached
patch to the docs.
cheers ./daniel
Attachments:
[application/octet-stream] create_agg_parallel.patch (1.4K, 2-create_agg_parallel.patch)
download | inline diff:
From 2ed82ee3f3fa28bd69f2981730cf60d89c8f3867 Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <[email protected]>
Date: Mon, 27 Nov 2017 15:29:15 +0100
Subject: [PATCH 2/2] doc: add PARALLEL option to old syntax for CREATE
AGGREGATE
The old pre-8.2 syntax for CREATE AGGREGATE also support PARALLEL,
even though it's required to be quoted as PARALLEL is an unreserved
keyword.
---
doc/src/sgml/ref/create_aggregate.sgml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/src/sgml/ref/create_aggregate.sgml b/doc/src/sgml/ref/create_aggregate.sgml
index a4aaae876e..d813ec41e6 100644
--- a/doc/src/sgml/ref/create_aggregate.sgml
+++ b/doc/src/sgml/ref/create_aggregate.sgml
@@ -80,6 +80,7 @@ CREATE AGGREGATE <replaceable class="parameter">name</replaceable> (
[ , MFINALFUNC_MODIFY = { READ_ONLY | SHARABLE | READ_WRITE } ]
[ , MINITCOND = <replaceable class="parameter">minitial_condition</replaceable> ]
[ , SORTOP = <replaceable class="parameter">sort_operator</replaceable> ]
+ [ , "PARALLEL" = { SAFE | RESTRICTED | UNSAFE } ]
)
</synopsis>
</refsynopsisdiv>
@@ -630,6 +631,10 @@ SELECT col FROM tab ORDER BY col USING sortop LIMIT 1;
functions are not consulted by the planner, only the marking of the
aggregate itself.
</para>
+ <para>
+ Note that when using the old syntax, <literal>"PARALLEL"</literal> must
+ be quoted.
+ </para>
</listitem>
</varlistentry>
--
2.14.1.145.gb3622a4ee
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: PARALLEL in old syntax for CREATE AGGREGATE
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox