Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7hMF-004JoO-M5 for pgsql-docs@arkaria.postgresql.org; Wed, 23 Apr 2025 21:10:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u7hMD-00AM6G-3j for pgsql-docs@arkaria.postgresql.org; Wed, 23 Apr 2025 21:10:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7hMC-00AM67-8H for pgsql-docs@lists.postgresql.org; Wed, 23 Apr 2025 21:10:13 +0000 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7hM8-001fB9-1p for pgsql-docs@lists.postgresql.org; Wed, 23 Apr 2025 21:10:12 +0000 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.phl.internal (Postfix) with ESMTP id 5F47D13801D7 for ; Wed, 23 Apr 2025 17:10:07 -0400 (EDT) Received: from phl-imap-09 ([10.202.2.99]) by phl-compute-07.internal (MEProxy); Wed, 23 Apr 2025 17:10:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1745442607; x=1745529007; bh=yMUzLwu9Mn gCdqCVcrq4z8YK3so0hnO2C9kPN8z13Pg=; b=KMzjU+v8cXtoHaPa2I1ptpgE+M I+CTG10YadwOareukIeuPqZv+P0arl7otfvVVH5hxb2J0rsMF7UgYuGz28ov6ZMN NQO6yFm+qykOtAEVjcAbkqfmZryQzc+LxWLygTtJBYDyUfAxCPzO93XrQvXFMkaV t8tPCNlI42t10iYrTfG7PyjgUhOLVl4AHPcqzjiOoovZc15ibhc2OL7xHhvKP8th 1CxJfaLS0CrAu3xFXB8rAekf2JC3b4B6GlC2w1ocXf6tHUbeppwGUZfWKEGrIF40 cGTDmAozPmC3cwKXY0tTFW79vgnpeV9k5nhGYCdhF2+Gn+p240fdquKPYN4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1745442607; x=1745529007; bh=yMUzLwu9MngCdqCVcrq4z8YK3so0hnO2C9k PN8z13Pg=; b=YSGAgIBIEcry1weKl6AA0i00iN+ceb4qEwqFHOm6iodki/e9Rww 5rU9ML7+zgwnMRx7Yde1zS1q9mBCT+wr8HcM0lvq9ucAnNrVfBB8xuNU4TAxa7PC Gj4/7XVgHQCpZNHMhYE1MdcEgrKAMx4q579UG0kHO0Qk7Rr85o0geXlYN4ukveJQ s8/0CmmHu+XOPDwYvyL18/NqatIxLQ9TC3Vm+g8ljXlsDswe4xXNfXuIYFOv5evO Veu5o2MsRkDesl15Qk6BSdLJ60qV99WpSlkIL219zN263WUUIrnJzGz7TL1VBM7M 7o0qi7IKd1Z5l5PE5suTgGIGnvEgx+i1fow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeejieegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefogg ffhffvkfgjfhfutgesrgdtreerredttdenucfhrhhomhepfdfguhhlvghrucfvrghvvghi rhgrfdcuoegvuhhlvghrsegvuhhlvghrthhordgtohhmqeenucggtffrrghtthgvrhhnpe fhtdduleeufeeltedutddukeekfeeugedvgfejteeggfffteeiffdugffgueffteenucff ohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepvghulhgvrhesvghulhgvrhhtohdrtgho mhdpnhgspghrtghpthhtohepuddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepph hgshhqlhdqughotghssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id B42D9780069; Wed, 23 Apr 2025 17:10:06 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: T8d6be4984d6524ae Date: Wed, 23 Apr 2025 18:09:45 -0300 From: "Euler Taveira" To: pgsql-docs@lists.postgresql.org Message-Id: <8425ab63-ee04-4ad5-8857-5806e3f4e751@app.fastmail.com> In-Reply-To: References: Subject: Re: Remove unnecessary secondary index terms for replication settings Content-Type: multipart/alternative; boundary=637c99ebc5334743933a40c73bba6917 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --637c99ebc5334743933a40c73bba6917 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Apr 23, 2025, at 3:53 AM, Fujii Masao wrote: > These secondary terms don't seem necessary anymore, since each parameter > now has only one index entry. Removing them would simplify the documentation. > > Originally, the secondary entries made sense because > max_active_replication_origins was part of max_replication_slots, > so both needed separate index entries. But commit 04ff636cbce > split them into distinct parameters. Agreed. It was an oversight in my patch. LGTM. -- Euler Taveira EDB https://www.enterprisedb.com/ --637c99ebc5334743933a40c73bba6917 Content-Type: text/html Content-Transfer-Encoding: 7bit
On Wed, Apr 23, 2025, at 3:53 AM, Fujii Masao wrote:
These secondary terms don't seem necessary anymore, since each parameter
now has only one index entry. Removing them would simplify the documentation.

Originally, the secondary entries made sense because
max_active_replication_origins was part of max_replication_slots,
so both needed separate index entries. But commit 04ff636cbce
split them into distinct parameters.

Agreed. It was an oversight in my patch. LGTM.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--637c99ebc5334743933a40c73bba6917--