Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Documentation improvement patch
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <b9ff5247-04a0-4fe5-9e2f-454b0c7bde7f@postgrespro.ru>
Date: Wed, 22 Oct 2025 10:02:14 +0200
Cc: pgsql-docs@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <84E4E3E6-D702-4604-AE0B-AF92B80B3833@yesql.se>
References: <e62bedb5-c26f-4d37-b4ed-ce9b55f1e980@postgrespro.ru>
 <3881A97B-0146-4389-9C39-3C596536750B@yesql.se>
 <b9ff5247-04a0-4fe5-9e2f-454b0c7bde7f@postgrespro.ru>
To: Oleg <o.sibiryakov@postgrespro.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/84E4E3E6-D702-4604-AE0B-AF92B80B3833%40yesql.se>
Precedence: bulk

> On 13 Oct 2025, at 12:51, Oleg <o.sibiryakov@postgrespro.ru> wrote:

> - <command>COPY</command> and other functions which allow executing a
> + the <command>COPY</command> command and functions, which allow =
executing a
> I'm not sure about these, I think we use COPY without the the "the =
COPY
> command" decoration in many places so I think it's more consistent =
like this.
>=20
> I actually think we should add the decoration here because =
"<command>COPY</command> and other file-access functions"
> sounds a bit confusing since COPY is not a file-access function and we =
seem to put it in the list. Even though I=20
> agree that everybody knows COPY is a command, not a function.

We refer to SQL commands by just their names all over the documentation =
without
saying "an EXPLAIN command" etc, and I think this falls in that same =
category.

> - to call functions defined in the standard internal library, by using =
an
> + to call functions defined in the standard internal function library =
by using an
> interface similar to their SQL signature.
> Isn't it a bit redundant to say "internal function library" when we =
are already
> talking about function definitions?
>=20
> I agree that it may seem redundant, I added "function" here for the =
sake of consistency with lines 1829/1830 (if applied to the master =
branch)
> where the documentation mentions "standard internal function library".

I hadn't seen that, but with that in mind I agree that being consistent =
is good
so I'll withdraw that comment.

--
Daniel Gustafsson