Feedback-ID: i131946ab:Fastmail
Message-ID: <8586c379-4070-d054-5948-50a733c5d042@enterprisedb.com>
Date: Wed, 7 Jun 2023 18:01:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.0
Subject: Re: confusing positioning of notes in connection settings
Content-Language: en-US
To: "Jonathan S. Katz" <jkatz@postgresql.org>,
 Daniel Gustafsson <daniel@yesql.se>
Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
References: <6f825d42-a1ce-492a-2ea7-c83e6e65fa8b@postgresql.org>
 <4e34fcb4-6791-0266-7352-27b769c478f9@enterprisedb.com>
 <D70737D3-C949-471A-9471-9E2C22C428F4@yesql.se>
 <39202431-DF62-42E2-B0C1-500C93AD37C8@yesql.se>
 <ab7511ea-a089-2445-f64d-0bf72ebb7bc4@enterprisedb.com>
 <A21C7848-0B4A-4216-A528-92B41F220A76@yesql.se>
 <739043ea-9fe8-3fa5-ed10-aa988eaeb121@postgresql.org>
 <b7d65e59-92a1-488f-7859-632c1f44d69a@enterprisedb.com>
 <8d88b78e-08d0-a703-4127-76023757efac@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <8d88b78e-08d0-a703-4127-76023757efac@postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8586c379-4070-d054-5948-50a733c5d042%40enterprisedb.com>
Precedence: bulk

On 07.06.23 17:34, Jonathan S. Katz wrote:
> On 6/7/23 11:17 AM, Peter Eisentraut wrote:
> 
>> The proposed text in the patch is
>>
>> "This parameter is supported only on systems that {have this property} 
>> (which does not include Windows)."
>>
>> I don't see how the change you are proposing is correct.
> 
> I see -- I had read it quickly and didn't sound it out. Nit withdrawn.

Ok, I committed it.

I don't have an opinion on whether any changes are necessary on the 
libpq side.