Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uITfc-005SE2-JY for pgsql-docs@arkaria.postgresql.org; Fri, 23 May 2025 14:46:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uITfb-002aEX-Ex for pgsql-docs@arkaria.postgresql.org; Fri, 23 May 2025 14:46:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uITfb-002aEL-3G for pgsql-docs@lists.postgresql.org; Fri, 23 May 2025 14:46:46 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uITfX-000X2J-0o for pgsql-docs@lists.postgresql.org; Fri, 23 May 2025 14:46:45 +0000 Received: from [192.168.11.9] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133]) by oss.nttdata.com (Postfix) with ESMTPSA id C5523619E6; Fri, 23 May 2025 23:46:38 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------Z8ctqq7zA3qe55Hw6NfBIaVP" Message-ID: <864b0ee3-35af-4b87-9070-155bcd931f95@oss.nttdata.com> Date: Fri, 23 May 2025 23:46:36 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Hot standbys now support exporting snapshots while creating a logical replication slot To: Kevin K Biju Cc: pgsql-docs@lists.postgresql.org References: <174791480466.798.17122832105389395178@wrigleys.postgresql.org> <97694620-3bfe-457c-8761-1a08a233f57b@oss.nttdata.com> Content-Language: en-US From: Fujii Masao In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------Z8ctqq7zA3qe55Hw6NfBIaVP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/05/23 19:52, Kevin K Biju wrote: > Hi Fuiji, > > I wasn't aware that support for exporting snapshots goes as far back as v10. The change looks good. Thanks for the review! I've prepared two patches: one for v15 and later, and another for v13 and v14. Unless there are any objections, I'll go ahead and commit and back-patch the patch to all supported branches. Regards, -- Fujii Masao NTT DATA Japan Corporation --------------Z8ctqq7zA3qe55Hw6NfBIaVP Content-Type: text/plain; charset=UTF-8; name="v1-0001-PG13_PG14-doc-Fix-documenation-for-snapshot-export-in-logic.patch" Content-Disposition: attachment; filename*0="v1-0001-PG13_PG14-doc-Fix-documenation-for-snapshot-export-i"; filename*1="n-logic.patch" Content-Transfer-Encoding: base64 RnJvbSA5N2Y4NWE2MGNlZjMyYTEyYTEyMzJkM2Q1ZTE2MTcxODcyOGQ4NzJmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IEZyaSwgMjMgTWF5IDIwMjUgMTA6MTg6MDQgKzA5MDAKU3ViamVjdDogW1BB VENIIHYxXSBkb2M6IEZpeCBkb2N1bWVuYXRpb24gZm9yIHNuYXBzaG90IGV4cG9ydCBpbiBs b2dpY2FsCiBkZWNvZGluZy4KClRoZSBkb2N1bWVudGF0aW9uIGZvciBleHBvcnRlZCBzbmFw c2hvdHMgaW4gbG9naWNhbCBkZWNvZGluZyBwcmV2aW91c2x5CnN0YXRlZCB0aGF0IHNuYXBz aG90IGNyZWF0aW9uIG1heSBmYWlsIG9uIGEgaG90IHN0YW5kYnkuIFRoaXMgaXMgbm8gbG9u Z2VyCmFjY3VyYXRlLCBhcyBzbmFwc2hvdCBleHBvcnRpbmcgb24gc3RhbmRieXMgaGFzIGJl ZW4gc3VwcG9ydGVkIHNpbmNlClBvc3RncmVTUUwgMTAuIFRoaXMgY29tbWl0IHJlbW92ZXMg dGhlIG91dGRhdGVkIGRlc2NyaXB0aW9uLgoKQWRkaXRpb25hbGx5LCB0aGUgZG9jcyByZWZl cnJlZCB0byB0aGUgTk9FWFBPUlRfU05BUFNIT1Qgb3B0aW9uIHRvCnN1cHByZXNzIHNuYXBz aG90IGV4cG9ydGluZyBpbiBDUkVBVEVfUkVQTElDQVRJT05fU0xPVC4gSG93ZXZlciwKc2lu Y2UgUG9zdGdyZVNRTCAxNSwgTk9FWFBPUlRfU05BUFNIT1QgaXMgY29uc2lkZXJlZCBsZWdh Y3kgc3ludGF4CmFuZCByZXRhaW5lZCBvbmx5IGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5 LiBUaGlzIGNvbW1pdCB1cGRhdGVzCnRoZSBkb2N1bWVudGF0aW9uIGZvciB2MTUgYW5kIGxh dGVyIHRvIHVzZSB0aGUgbW9kZXJuIGVxdWl2YWxlbnQ6ClNOQVBTSE9UICdub3RoaW5nJy4g VGhlIG9sZGVyIHN5bnRheCBpcyBwcmVzZXJ2ZWQgaW4gZG9jdW1lbnRhdGlvbiBmb3IKdjE0 IGFuZCBlYXJsaWVyLgoKQmFjay1wYXRjaGVkIHRvIGFsbCBzdXBwb3J0ZWQgYnJhbmNoZXMu CgpSZXBvcnRlZC1ieTogS2V2aW4gSyBCaWp1IDxrZXZpbmtiaWp1QGdtYWlsLmNvbT4KQXV0 aG9yOiBGdWppaSBNYXNhbyA8bWFzYW8uZnVqaWlAZ21haWwuY29tPgpSZXZpZXdlZC1ieTog S2V2aW4gSyBCaWp1IDxrZXZpbmtiaWp1QGdtYWlsLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6 Ly9wb3N0Z3IuZXMvbS8xNzQ3OTE0ODA0NjYuNzk4LjE3MTIyODMyMTA1Mzg5Mzk1MTc4QHdy aWdsZXlzLnBvc3RncmVzcWwub3JnCkJhY2twYXRjaC10aHJvdWdoOiAxMwotLS0KIGRvYy9z cmMvc2dtbC9sb2dpY2FsZGVjb2Rpbmcuc2dtbCB8IDMgKy0tCiAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9z Z21sL2xvZ2ljYWxkZWNvZGluZy5zZ21sIGIvZG9jL3NyYy9zZ21sL2xvZ2ljYWxkZWNvZGlu Zy5zZ21sCmluZGV4IDc4MDVkZDQ0YTE4Li44NDdkN2RlNzIzYSAxMDA2NDQKLS0tIGEvZG9j L3NyYy9zZ21sL2xvZ2ljYWxkZWNvZGluZy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9sb2dp Y2FsZGVjb2Rpbmcuc2dtbApAQCAtMzM1LDggKzMzNSw3IEBAIHBvc3RncmVzPSMgc2VsZWN0 ICogZnJvbSBwZ19sb2dpY2FsX3Nsb3RfZ2V0X2NoYW5nZXMoJ3JlZ3Jlc3Npb25fc2xvdCcs IE5VTEwsIE5VCiAgICAgIHVzaW5nIHRoZSBzbG90J3MgY29udGVudHMgd2l0aG91dCBsb3Np bmcgYW55IGNoYW5nZXMuCiAgICAgPC9wYXJhPgogICAgIDxwYXJhPgotICAgICBDcmVhdGlv biBvZiBhIHNuYXBzaG90IGlzIG5vdCBhbHdheXMgcG9zc2libGUuICBJbiBwYXJ0aWN1bGFy LCBpdCB3aWxsCi0gICAgIGZhaWwgd2hlbiBjb25uZWN0ZWQgdG8gYSBob3Qgc3RhbmRieS4g IEFwcGxpY2F0aW9ucyB0aGF0IGRvIG5vdCByZXF1aXJlCisgICAgIEFwcGxpY2F0aW9ucyB0 aGF0IGRvIG5vdCByZXF1aXJlCiAgICAgIHNuYXBzaG90IGV4cG9ydCBtYXkgc3VwcHJlc3Mg aXQgd2l0aCB0aGUgPGxpdGVyYWw+Tk9FWFBPUlRfU05BUFNIT1Q8L2xpdGVyYWw+CiAgICAg IG9wdGlvbi4KICAgICA8L3BhcmE+Ci0tIAoyLjQ5LjAKCg== --------------Z8ctqq7zA3qe55Hw6NfBIaVP Content-Type: text/plain; charset=UTF-8; name="v1-0001-PG15_master-doc-Fix-documenation-for-snapshot-export-in-logic.patch" Content-Disposition: attachment; filename*0="v1-0001-PG15_master-doc-Fix-documenation-for-snapshot-export"; filename*1="-in-logic.patch" Content-Transfer-Encoding: base64 RnJvbSBlY2Q1ZTIxYTQzNjJkZDA5N2EyOGQyNmQ1ZWYwZjVlOWE3OGFiOTY4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v cmc+CkRhdGU6IEZyaSwgMjMgTWF5IDIwMjUgMTA6MTg6MDQgKzA5MDAKU3ViamVjdDogW1BB VENIIHYxXSBkb2M6IEZpeCBkb2N1bWVuYXRpb24gZm9yIHNuYXBzaG90IGV4cG9ydCBpbiBs b2dpY2FsCiBkZWNvZGluZy4KClRoZSBkb2N1bWVudGF0aW9uIGZvciBleHBvcnRlZCBzbmFw c2hvdHMgaW4gbG9naWNhbCBkZWNvZGluZyBwcmV2aW91c2x5CnN0YXRlZCB0aGF0IHNuYXBz aG90IGNyZWF0aW9uIG1heSBmYWlsIG9uIGEgaG90IHN0YW5kYnkuIFRoaXMgaXMgbm8gbG9u Z2VyCmFjY3VyYXRlLCBhcyBzbmFwc2hvdCBleHBvcnRpbmcgb24gc3RhbmRieXMgaGFzIGJl ZW4gc3VwcG9ydGVkIHNpbmNlClBvc3RncmVTUUwgMTAuIFRoaXMgY29tbWl0IHJlbW92ZXMg dGhlIG91dGRhdGVkIGRlc2NyaXB0aW9uLgoKQWRkaXRpb25hbGx5LCB0aGUgZG9jcyByZWZl cnJlZCB0byB0aGUgTk9FWFBPUlRfU05BUFNIT1Qgb3B0aW9uIHRvCnN1cHByZXNzIHNuYXBz aG90IGV4cG9ydGluZyBpbiBDUkVBVEVfUkVQTElDQVRJT05fU0xPVC4gSG93ZXZlciwKc2lu Y2UgUG9zdGdyZVNRTCAxNSwgTk9FWFBPUlRfU05BUFNIT1QgaXMgY29uc2lkZXJlZCBsZWdh Y3kgc3ludGF4CmFuZCByZXRhaW5lZCBvbmx5IGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5 LiBUaGlzIGNvbW1pdCB1cGRhdGVzCnRoZSBkb2N1bWVudGF0aW9uIGZvciB2MTUgYW5kIGxh dGVyIHRvIHVzZSB0aGUgbW9kZXJuIGVxdWl2YWxlbnQ6ClNOQVBTSE9UICdub3RoaW5nJy4g VGhlIG9sZGVyIHN5bnRheCBpcyBwcmVzZXJ2ZWQgaW4gZG9jdW1lbnRhdGlvbiBmb3IKdjE0 IGFuZCBlYXJsaWVyLgoKQmFjay1wYXRjaGVkIHRvIGFsbCBzdXBwb3J0ZWQgYnJhbmNoZXMu CgpSZXBvcnRlZC1ieTogS2V2aW4gSyBCaWp1IDxrZXZpbmtiaWp1QGdtYWlsLmNvbT4KQXV0 aG9yOiBGdWppaSBNYXNhbyA8bWFzYW8uZnVqaWlAZ21haWwuY29tPgpSZXZpZXdlZC1ieTog S2V2aW4gSyBCaWp1IDxrZXZpbmtiaWp1QGdtYWlsLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6 Ly9wb3N0Z3IuZXMvbS8xNzQ3OTE0ODA0NjYuNzk4LjE3MTIyODMyMTA1Mzg5Mzk1MTc4QHdy aWdsZXlzLnBvc3RncmVzcWwub3JnCkJhY2twYXRjaC10aHJvdWdoOiAxMwotLS0KIGRvYy9z cmMvc2dtbC9sb2dpY2FsZGVjb2Rpbmcuc2dtbCB8IDUgKystLS0KIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3Ny Yy9zZ21sL2xvZ2ljYWxkZWNvZGluZy5zZ21sIGIvZG9jL3NyYy9zZ21sL2xvZ2ljYWxkZWNv ZGluZy5zZ21sCmluZGV4IDNmMmJjZDQ1YTFlLi5kZDllODNiMDhlYSAxMDA2NDQKLS0tIGEv ZG9jL3NyYy9zZ21sL2xvZ2ljYWxkZWNvZGluZy5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9s b2dpY2FsZGVjb2Rpbmcuc2dtbApAQCAtNDU1LDkgKzQ1NSw4IEBAIHBvc3RncmVzPSMgc2Vs ZWN0ICogZnJvbSBwZ19sb2dpY2FsX3Nsb3RfZ2V0X2NoYW5nZXMoJ3JlZ3Jlc3Npb25fc2xv dCcsIE5VTEwsIE5VCiAgICAgIHVzaW5nIHRoZSBzbG90J3MgY29udGVudHMgd2l0aG91dCBs b3NpbmcgYW55IGNoYW5nZXMuCiAgICAgPC9wYXJhPgogICAgIDxwYXJhPgotICAgICBDcmVh dGlvbiBvZiBhIHNuYXBzaG90IGlzIG5vdCBhbHdheXMgcG9zc2libGUuICBJbiBwYXJ0aWN1 bGFyLCBpdCB3aWxsCi0gICAgIGZhaWwgd2hlbiBjb25uZWN0ZWQgdG8gYSBob3Qgc3RhbmRi eS4gIEFwcGxpY2F0aW9ucyB0aGF0IGRvIG5vdCByZXF1aXJlCi0gICAgIHNuYXBzaG90IGV4 cG9ydCBtYXkgc3VwcHJlc3MgaXQgd2l0aCB0aGUgPGxpdGVyYWw+Tk9FWFBPUlRfU05BUFNI T1Q8L2xpdGVyYWw+CisgICAgIEFwcGxpY2F0aW9ucyB0aGF0IGRvIG5vdCByZXF1aXJlCisg ICAgIHNuYXBzaG90IGV4cG9ydCBtYXkgc3VwcHJlc3MgaXQgd2l0aCB0aGUgPGxpdGVyYWw+ U05BUFNIT1QgJ25vdGhpbmcnPC9saXRlcmFsPgogICAgICBvcHRpb24uCiAgICAgPC9wYXJh PgogICAgPC9zZWN0Mj4KLS0gCjIuNDkuMAoK --------------Z8ctqq7zA3qe55Hw6NfBIaVP--