Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1tLkna-00GmCq-Li
	for pgsql-docs@arkaria.postgresql.org; Thu, 12 Dec 2024 15:08:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1tLknY-00CyLZ-1Z
	for pgsql-docs@arkaria.postgresql.org; Thu, 12 Dec 2024 15:08:17 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1tLknX-00CyLR-Pa
	for pgsql-docs@lists.postgresql.org; Thu, 12 Dec 2024 15:08:16 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps  (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1tLknU-002TxC-Tg
	for pgsql-docs@lists.postgresql.org; Thu, 12 Dec 2024 15:08:16 +0000
Received: from [192.168.11.8] (p3453111-ipxg13001funabasi.chiba.ocn.ne.jp
 [58.88.58.111])
	by oss.nttdata.com (Postfix) with ESMTPSA id 4AC606139E;
	Fri, 13 Dec 2024 00:08:07 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Content-Type: multipart/mixed; boundary="------------R6An9sEgtbAoLMkc45fvo0jM"
Message-ID: <87716933-16fc-4b79-a4f6-59ffc06a76a1@oss.nttdata.com>
Date: Fri, 13 Dec 2024 00:08:06 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Clarify old WAL files cannot be removed until they are summarized
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
References: <fd0eb0a5-f43b-4e06-b450-cbca011b6cff@oss.nttdata.com>
 <Z1jaaLi2vq-Wpk9y@paquier.xyz>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <Z1jaaLi2vq-Wpk9y@paquier.xyz>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/87716933-16fc-4b79-a4f6-59ffc06a76a1%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------R6An9sEgtbAoLMkc45fvo0jM
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 2024/12/11 9:18, Michael Paquier wrote:
> On Fri, Oct 18, 2024 at 02:25:15AM +0900, Fujii Masao wrote:
>> The documentation in wal.sgml explains that old WAL files cannot be
>> removed or recycled until they are archived (when WAL archiving is used)
>> or replicated (when using replication slots). However, it did not
>> mention that, similarly, old WAL files are also kept until they are summarized
>> if WAL summarization is enabled. Attached patch adds that clarification to
>> the documentation. Thought?
>>
>> @@ -643,6 +643,8 @@
>>      until the situation is resolved. A slow or failed standby server that
>>      uses a replication slot will have the same effect (see
>>      <xref linkend="streaming-replication-slots"/>).
>> +   Similarly, if WAL summarization is enabled, old segments are kept
>> +   until they are summarized.
>>     </para>
> 
> Sounds like a good idea to me.  I'd suggest to add a link to
> runtime-config-wal-summarization as it is the first reference to WAL
> summarization in this file.

Yes, that sounds like a good idea. I've updated the patch accordingly.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------R6An9sEgtbAoLMkc45fvo0jM
Content-Type: text/plain; charset=UTF-8;
 name="v2-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.patch"
Content-Disposition: attachment;
 filename*0="v2-0001-doc-Clarify-old-WAL-files-are-kept-until-they-are.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBiMGQ2Y2ViNjc5OTg4OWUzZDkyNjk5NDgzNDJhMjQ5YzY3YzcxMzQxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFRodSwgMTIgRGVjIDIwMjQgMjM6NDY6MjMgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYyXSBkb2M6IENsYXJpZnkgb2xkIFdBTCBmaWxlcyBhcmUga2VwdCB1bnRpbCB0aGV5
IGFyZQogc3VtbWFyaXplZC4KClRoZSBkb2N1bWVudGF0aW9uIGluIHdhbC5zZ21sIGV4cGxh
aW5zIHRoYXQgb2xkIFdBTCBmaWxlcyBjYW5ub3QgYmUKcmVtb3ZlZCBvciByZWN5Y2xlZCB1
bnRpbCB0aGV5IGFyZSBhcmNoaXZlZCAod2hlbiBXQUwgYXJjaGl2aW5nIGlzIHVzZWQpCm9y
IHJlcGxpY2F0ZWQgKHdoZW4gdXNpbmcgcmVwbGljYXRpb24gc2xvdHMpLiBIb3dldmVyLCBp
dCBkaWQgbm90IG1lbnRpb24KdGhhdCwgc2ltaWxhcmx5LCBvbGQgV0FMIGZpbGVzIGFyZSBh
bHNvIGtlcHQgdW50aWwgdGhleSBhcmUgc3VtbWFyaXplZAppZiBXQUwgc3VtbWFyaXphdGlv
biBpcyBlbmFibGVkLiBUaGlzIGNvbW1pdCBhZGRzIHRoYXQgY2xhcmlmaWNhdGlvbgp0byB0
aGUgZG9jdW1lbnRhdGlvbi4KCkJhY2stcGF0Y2ggdG8gdjE3IHdoZXJlIFdBTCBzdW1tYXJp
emF0aW9uIHdhcyBhZGRlZC4KCkF1dGhvcjogRnVqaWkgTWFzYW8KUmV2aWV3ZWQtYnk6IE1p
Y2hhZWwgUGFxdWllcgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL2ZkMGViMGE1
LWY0M2ItNGUwNi1iNDUwLWNiY2EwMTFiNmNmZkBvc3MubnR0ZGF0YS5jb20KLS0tCiBkb2Mv
c3JjL3NnbWwvd2FsLnNnbWwgfCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9u
cygrKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC93YWwuc2dtbCBiL2RvYy9zcmMvc2dt
bC93YWwuc2dtbAppbmRleCBhMzRjZGRiNWVkLi5iOTA4NzIwYWRlIDEwMDY0NAotLS0gYS9k
b2Mvc3JjL3NnbWwvd2FsLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3dhbC5zZ21sCkBAIC02
NDMsNiArNjQzLDkgQEAKICAgIHVudGlsIHRoZSBzaXR1YXRpb24gaXMgcmVzb2x2ZWQuIEEg
c2xvdyBvciBmYWlsZWQgc3RhbmRieSBzZXJ2ZXIgdGhhdAogICAgdXNlcyBhIHJlcGxpY2F0
aW9uIHNsb3Qgd2lsbCBoYXZlIHRoZSBzYW1lIGVmZmVjdCAoc2VlCiAgICA8eHJlZiBsaW5r
ZW5kPSJzdHJlYW1pbmctcmVwbGljYXRpb24tc2xvdHMiLz4pLgorICAgU2ltaWxhcmx5LCBp
ZiA8bGluayBsaW5rZW5kPSJydW50aW1lLWNvbmZpZy13YWwtc3VtbWFyaXphdGlvbiI+Cisg
ICBXQUwgc3VtbWFyaXphdGlvbjwvbGluaz4gaXMgZW5hYmxlZCwgb2xkIHNlZ21lbnRzIGFy
ZSBrZXB0CisgICB1bnRpbCB0aGV5IGFyZSBzdW1tYXJpemVkLgogICA8L3BhcmE+CiAKICAg
PHBhcmE+Ci0tIAoyLjQ3LjAKCg==

--------------R6An9sEgtbAoLMkc45fvo0jM--