public inbox for [email protected]
help / color / mirror / Atom feedRe: Full Text Search examples patch
2+ messages / 2 participants
[nested] [flat]
* Re: Full Text Search examples patch
@ 2008-01-16 02:06 Erik <[email protected]>
2008-03-26 14:10 ` Re: Full Text Search examples patch Bruce Momjian <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Erik @ 2008-01-16 02:06 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; +Cc: Tom Lane <[email protected]>; pgsql-docs
Alvaro Herrera wrote:
> Erik wrote:
>> Tom Lane wrote:
>> > "Erik" <[email protected]> writes:
>> >> I changed all references to 'pgweb' to 'apod'. This
>> apod
>> >> table initially corresponds with the structure of the
>> >> table in the dump file. (In the documentation, that
>> >> table
>> >> is subsequently changed by adding a tsvector column.)
>> >
>> > Huh? These are just examples, they are not supposed
>> to
>> > refer to any
>> > specific real table, much less one that comes standard
>> > with Postgres.
>>
>> I understand that, of course. I am suggesting it might
>> be
>> an improvement to offer the data to go with the
>> examples.
>
> Hmm, wouldn't it be easier to provide the pgweb table?
Maybe - I don't know what that pgweb data would be.
There are really two issues:
1. Apply changes I suggested (and attached earlier) to
the documentation text to make code examples use a
single table instead of two different ones. I chose
apod because I knew apod from tsearch2. In the patch
there are also some confusing inconsistencies removed,
for instance column 'textsearch_indexable_col' is in a
later code example used as column 'textsearch'.
2. Whether or not to include some actual table data (be
it apod or pgweb). This is less important as far as I am
concerned.
The first is more useful and easier to apply than the
second.
> Alvaro Herrera
> http://www.CommandPrompt.com/
> PostgreSQL Replication, Consulting, Custom Development,
> 24x7 support
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by
> donating at
>
> http://www.postgresql.org/about/donate
>
regards,
Erik Rijkers
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Full Text Search examples patch
2008-01-16 02:06 Re: Full Text Search examples patch Erik <[email protected]>
@ 2008-03-26 14:10 ` Bruce Momjian <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Momjian @ 2008-03-26 14:10 UTC (permalink / raw)
To: Erik <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; pgsql-docs
Erik wrote:
> > Hmm, wouldn't it be easier to provide the pgweb table?
>
> Maybe - I don't know what that pgweb data would be.
>
> There are really two issues:
>
> 1. Apply changes I suggested (and attached earlier) to
> the documentation text to make code examples use a
> single table instead of two different ones. I chose
> apod because I knew apod from tsearch2. In the patch
> there are also some confusing inconsistencies removed,
> for instance column 'textsearch_indexable_col' is in a
> later code example used as column 'textsearch'.
>
> 2. Whether or not to include some actual table data (be
> it apod or pgweb). This is less important as far as I am
> concerned.
>
> The first is more useful and easier to apply than the
> second.
Agreed. The data file you sent was 1.5MB of data uncompressed. That
isn't going in the docs.
I looked at adding just the schema you had:
CREATE TABLE apod (
title text,
body text,
sdate date,
keywords text,
id integer
);
but later saw that there were 'apod' references later in the docs that
mentioned columns that weren't in the CREATE TABLE, e.g., 'vector':
SELECT * FROM ts_stat('SELECT vector FROM apod')
ORDER BY nentry DESC, ndoc DESC, word
LIMIT 10;
Please send a patch that adds the CREATE TABLE in a consistent manner
and we will consider just that addition. Here is where I suggest you
add the CREATE TABLE in the patch:
<programlisting>
CREATE TABLE apod (
title text,
body text,
sdate date,
keywords text,
id integer);
-- insert some data
SELECT title, ts_rank_cd(textsearch, query) AS rank
FROM apod, to_tsquery('neutrino|(dark & matter)') query
WHERE query @@ textsearch
ORDER BY rank DESC LIMIT 10;
I am fine with you updating the later examples to be more consistent
too.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2008-03-26 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2008-01-16 02:06 Re: Full Text Search examples patch Erik <[email protected]>
2008-03-26 14:10 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox