public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: Fujii Masao <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Fix data checksum progress reporting docs
Date: Thu, 9 Jul 2026 10:28:18 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwEv-C9ia+rBYyePzO8F=5FVvS412ZqcOupazuOb5RafNg@mail.gmail.com>
References: <CAHGQGwHJHJYAkYZBi3_O13np-Rou9UL637=hB3Y_-qdCgcZn-w@mail.gmail.com>
<[email protected]>
<CAHGQGwEv-C9ia+rBYyePzO8F=5FVvS412ZqcOupazuOb5RafNg@mail.gmail.com>
> On 9 Jul 2026, at 02:17, Fujii Masao <[email protected]> wrote:
>
> On Wed, Jul 8, 2026 at 10:24 PM Daniel Gustafsson <[email protected]> wrote:
>> The proposed changes all look good to me, thanks!
>
> Thanks for the review! I've pushed the patch.
>
> BTW, this is a separate issue, but also related to the data checksums docs,
> I found that the glossary entry for "Auxiliary process" includes
> the data checksums worker and data checksums worker launcher.
> However, their own glossary entries describe them as background workers,
> and they are implemented as dynamic background workers.
>
> This seems inconsistent. Other dynamic background workers, such as
> logical replication apply workers, are not listed as auxiliary processes.
> I don't see why the data checksums worker and launcher should be treated
> differently.
>
> Wouldn't it be better to remove the data checksums worker and data
> checksums worker launcher from the "Auxiliary process" entry?
You are absolutely right. And when looking at it I think we can simplify the
entry a bit as well to make it fit the style of the page better. What do you
think about the attached?
--
Daniel Gustafsson
Attachments:
[application/octet-stream] 0001-doc-Fix-glossary-entry-for-data-checksums-workers.patch (3.7K, ../[email protected]/2-0001-doc-Fix-glossary-entry-for-data-checksums-workers.patch)
download | inline diff:
From 740c9c8e44dc7c419a2ceb0207c43f7588229e87 Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <[email protected]>
Date: Thu, 9 Jul 2026 10:23:22 +0200
Subject: [PATCH] doc: Fix glossary entry for data checksums workers
The glossary entry for data checksums workers incorrectly stated that
they were auxiliary processes, but they are implementerd as background
workers. Fix, and while there, simplify the entry by combining the
worker and launcher into a single glossary term.
Reported-by: Fujii Masao <[email protected]>
Discussion: https://postgr.es/m/CAHGQGwEv-C9ia+rBYyePzO8F=5FVvS412ZqcOupazuOb5RafNg@mail.gmail.com
---
doc/src/sgml/glossary.sgml | 32 ++++++++++++--------------------
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/doc/src/sgml/glossary.sgml b/doc/src/sgml/glossary.sgml
index f7f69afc922..4f841fb5886 100644
--- a/doc/src/sgml/glossary.sgml
+++ b/doc/src/sgml/glossary.sgml
@@ -199,8 +199,6 @@
(but not the autovacuum workers),
the <glossterm linkend="glossary-background-writer">background writer</glossterm>,
the <glossterm linkend="glossary-checkpointer">checkpointer</glossterm>,
- the <glossterm linkend="glossary-data-checksums-worker">data checksums worker</glossterm>,
- the <glossterm linkend="glossary-data-checksums-worker-launcher">data checksums worker launcher</glossterm>,
the <glossterm linkend="glossary-logger">logger</glossterm>,
the <glossterm linkend="glossary-startup-process">startup process</glossterm>,
the <glossterm linkend="glossary-wal-archiver">WAL archiver</glossterm>,
@@ -236,8 +234,9 @@
which runs system- or user-supplied code.
Serves as infrastructure for several features in
<productname>PostgreSQL</productname>, such as
- <glossterm linkend="glossary-replication">logical replication</glossterm>
- and <glossterm linkend="glossary-parallel-query">parallel queries</glossterm>.
+ <glossterm linkend="glossary-replication">logical replication</glossterm>,
+ <glossterm linkend="glossary-parallel-query">parallel queries</glossterm> and
+ <glossterm linkend="glossary-data-checksums-process">data checksums processing</glossterm>.
In addition, <glossterm linkend="glossary-extension">Extensions</glossterm> can add
custom background worker processes.
</para>
@@ -588,24 +587,17 @@
<glosssee otherterm="glossary-data-directory" />
</glossentry>
- <glossentry id="glossary-data-checksums-worker">
- <glossterm>Data Checksums Worker</glossterm>
+ <glossentry id="glossary-data-checksums-process">
+ <glossterm>Data Checksums (process)</glossterm>
<glossdef>
<para>
- A <glossterm linkend="glossary-background-worker">background worker</glossterm>
- which enables data checksums in a specific database.
- </para>
- </glossdef>
- </glossentry>
-
- <glossentry id="glossary-data-checksums-worker-launcher">
- <glossterm>Data Checksums Worker Launcher</glossterm>
- <glossdef>
- <para>
- A <glossterm linkend="glossary-background-worker">background worker</glossterm>
- which starts <glossterm linkend="glossary-data-checksums-worker"> data
- checksum worker</glossterm> processes for enabling data checksums in each
- database, or disables data checksums cluster-wide.
+ A set of
+ <glossterm linkend="glossary-background-worker">background worker</glossterm>
+ processes which can enable, or disable, data checksums in a
+ running cluster. The process which coordinates the work is known as the
+ <firstterm>data checksums worker launcher</firstterm> and the process
+ which operate on the individual databases is known as the
+ <firstterm>data checksums worker</firstterm>.
</para>
</glossdef>
</glossentry>
--
2.39.3 (Apple Git-146)
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Fix data checksum progress reporting docs
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox