From: Daniel Gustafsson <daniel@yesql.se>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: 'bar' shouldn't be a string in example
Date: Tue, 19 Dec 2023 12:07:47 +0100
References: <170292280173.1876505.5204623074024041738@wrigleys.postgresql.org>
To: tim.needham2@gmail.com,
 pgsql-docs@lists.postgresql.org
In-Reply-To: 
 <170292280173.1876505.5204623074024041738@wrigleys.postgresql.org>
Message-Id: <8DF4199B-549C-433E-A35F-D1995933F11F@yesql.se>
Archived-At: 
 <https://www.postgresql.org/message-id/8DF4199B-549C-433E-A35F-D1995933F11F%40yesql.se>
Precedence: bulk

> On 18 Dec 2023, at 19:06, PG Doc comments form =
<noreply@postgresql.org> wrote:

> ALTER FOREIGN DATA WRAPPER dbi OPTIONS (ADD foo '1', DROP 'bar');
>=20
> I think "bar" is akin to "foo" and therefore should be similarly an =
option?
> (i.e. not a string value)?

Nice catch, "DROP 'bar'" is considered to be unqualified and thus ADD is
assumed, generating the below options:

postgres=3D# alter foreign data wrapper dummy options (add foo '1', drop =
'bar');
ALTER FOREIGN DATA WRAPPER
postgres=3D# select fdwoptions from pg_foreign_data_wrapper where =
fdwname=3D'dummy';
    fdwoptions
------------------
 {foo=3D1,drop=3Dbar}
(1 row)

This has been incorrect since forever so I will backpatch this into all
supported versions.

--
Daniel Gustafsson