Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1uUhSJ-007F3G-5Z
	for pgsql-docs@arkaria.postgresql.org; Thu, 26 Jun 2025 07:55:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1uUhSG-009T0S-07
	for pgsql-docs@arkaria.postgresql.org; Thu, 26 Jun 2025 07:55:32 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1uUhSF-009SwJ-No
	for pgsql-docs@lists.postgresql.org; Thu, 26 Jun 2025 07:55:32 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with smtp (Exim 4.96)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1uUhSE-0044GY-0T
	for pgsql-docs@lists.postgresql.org;
	Thu, 26 Jun 2025 07:55:31 +0000
Received: from [192.168.11.9] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133])
	by oss.nttdata.com (Postfix) with ESMTPSA id 002AB61BAA;
	Thu, 26 Jun 2025 16:55:26 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com
Content-Type: multipart/mixed; boundary="------------8ex08rsonNtfqODXbwXZ8ilA"
Message-ID: <8b5ca8aa-dbc0-4f58-87bf-403352f3d00c@oss.nttdata.com>
Date: Thu, 26 Jun 2025 16:55:26 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Mention idle_replication_slot_timeout in pg_replication_slots
 docs
Content-Language: en-US
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
References: <78b34e84-2195-4f28-a151-5d204a382fdd@oss.nttdata.com>
 <OSCPR01MB149667D264CBA6838AEB20648F57AA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <OSCPR01MB149667D264CBA6838AEB20648F57AA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/8b5ca8aa-dbc0-4f58-87bf-403352f3d00c%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------8ex08rsonNtfqODXbwXZ8ilA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 2025/06/26 15:43, Hayato Kuroda (Fujitsu) wrote:
> Dear Fujii-san,
> 
>> The pg_replication_slots documentation mentions only max_slot_wal_keep_size
>> as a condition under which the wal_status column can show unreserved or lost.
>> However, since commit ac0e33136ab, idle_replication_slot_timeout can also
>> cause this behavior when it is set. This has not been documented yet.
>> https://www.postgresql.org/docs/devel/view-pg-replication-slots.html
> 
> Oh, I feel the doc should be also updated.

Thanks for the review!


>> So, how about updating the documentation to also mention
>> idle_replication_slot_timeout as a factor that can cause wal_status to
>> become unreserved or lost? Patch attached.
> 
> One comment:
> 
> ```
>           <para>
>            <literal>lost</literal> means that some required WAL files have
>            been removed and this slot is no longer usable.
>           </para>
> ```
> 
> IIUC, there is a case that status is "lost" but the required WALs have not been
> dropped yet if the slot was invalidated due to the timeout. How about removing the
> first part:
> 
> ```
> <literal>lost</literal> means that this slot is no longer usable.
> ```

Agreed. Attached is the updated version of the patch.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

--------------8ex08rsonNtfqODXbwXZ8ilA
Content-Type: text/plain; charset=UTF-8;
 name="v2-0001-doc-Mention-idle_replication_slot_timeout-in-pg_r.patch"
Content-Disposition: attachment;
 filename*0="v2-0001-doc-Mention-idle_replication_slot_timeout-in-pg_r.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBhNzMwOTA4NzY0YjIyNTVmZDdhYjM2NDQxNDE3YmRkYzY0M2Q0YTVlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFRodSwgMjYgSnVuIDIwMjUgMTY6NDk6NTkgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYyXSBkb2M6IE1lbnRpb24gaWRsZV9yZXBsaWNhdGlvbl9zbG90X3RpbWVvdXQgaW4K
IHBnX3JlcGxpY2F0aW9uX3Nsb3RzIGRvY3MuCgpUaGUgcGdfcmVwbGljYXRpb25fc2xvdHMg
ZG9jdW1lbnRhdGlvbiBwcmV2aW91c2x5IG1lbnRpb25lZCBvbmx5Cm1heF9zbG90X3dhbF9r
ZWVwX3NpemUgYXMgYSBjb25kaXRpb24gdW5kZXIgd2hpY2ggdGhlIHdhbF9zdGF0dXMgY29s
dW1uCmNhbiBzaG93IHVucmVzZXJ2ZWQgb3IgbG9zdC4gSG93ZXZlciwgc2luY2UgY29tbWl0
IGFjMGUzMzEzNmFiLAppZGxlX3JlcGxpY2F0aW9uX3Nsb3RfdGltZW91dCBjYW4gYWxzbyBj
YXVzZSB0aGlzIGJlaGF2aW9yIHdoZW4gaXQgaXMgc2V0LgpUaGlzIHdhcyBub3QgZG9jdW1l
bnRlZC4KClRoaXMgY29tbWl0IHVwZGF0ZXMgdGhlIGRvY3VtZW50YXRpb24gdG8gYWxzbyBt
ZW50aW9uCmlkbGVfcmVwbGljYXRpb25fc2xvdF90aW1lb3V0IGFzIGEgZmFjdG9yIHRoYXQg
Y2FuIGNhdXNlIHdhbF9zdGF0dXMKdG8gYmVjb21lIHVucmVzZXJ2ZWQgb3IgbG9zdC4KCkF1
dGhvcjogRnVqaWkgTWFzYW8gPG1hc2FvLmZ1amlpQGdtYWlsLmNvbT4KUmV2aWV3ZWQtYnk6
IEhheWF0byBLdXJvZGEgPGt1cm9kYS5oYXlhdG9AZnVqaXRzdS5jb20+ClJldmlld2VkLWJ5
OiBOaXNoYSBNb29uZCA8bmlzaGEubW9vbmQ0MTJAZ21haWwuY29tPgpEaXNjdXNzaW9uOiBo
dHRwczovL3Bvc3Rnci5lcy9tLzc4YjM0ZTg0LTIxOTUtNGYyOC1hMTUxLTVkMjA0YTM4MmZk
ZEBvc3MubnR0ZGF0YS5jb20KLS0tCiBkb2Mvc3JjL3NnbWwvc3lzdGVtLXZpZXdzLnNnbWwg
fCA4ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9zeXN0ZW0tdmlld3Muc2dtbCBi
L2RvYy9zcmMvc2dtbC9zeXN0ZW0tdmlld3Muc2dtbAppbmRleCA5ODZhZTFmNTQzZC4uMzA4
ZTVkYWJmM2IgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9zeXN0ZW0tdmlld3Muc2dtbAor
KysgYi9kb2Mvc3JjL3NnbWwvc3lzdGVtLXZpZXdzLnNnbWwKQEAgLTI4MjUsMTUgKzI4MjUs
MTUgQEAgU0VMRUNUICogRlJPTSBwZ19sb2NrcyBwbCBMRUZUIEpPSU4gcGdfcHJlcGFyZWRf
eGFjdHMgcHB4CiAgICAgICAgIDwvbGlzdGl0ZW0+CiAgICAgICAgIDxsaXN0aXRlbT4KICAg
ICAgICAgIDxwYXJhPgotICAgICAgICAgIDxsaXRlcmFsPmxvc3Q8L2xpdGVyYWw+IG1lYW5z
IHRoYXQgc29tZSByZXF1aXJlZCBXQUwgZmlsZXMgaGF2ZQotICAgICAgICAgIGJlZW4gcmVt
b3ZlZCBhbmQgdGhpcyBzbG90IGlzIG5vIGxvbmdlciB1c2FibGUuCisgICAgICAgICAgPGxp
dGVyYWw+bG9zdDwvbGl0ZXJhbD4gbWVhbnMgdGhhdCB0aGlzIHNsb3QgaXMgbm8gbG9uZ2Vy
IHVzYWJsZS4KICAgICAgICAgIDwvcGFyYT4KICAgICAgICAgPC9saXN0aXRlbT4KICAgICAg
ICA8L2l0ZW1pemVkbGlzdD4KICAgICAgICBUaGUgbGFzdCB0d28gc3RhdGVzIGFyZSBzZWVu
IG9ubHkgd2hlbgogICAgICAgIDx4cmVmIGxpbmtlbmQ9Imd1Yy1tYXgtc2xvdC13YWwta2Vl
cC1zaXplIi8+IGlzCi0gICAgICAgbm9uLW5lZ2F0aXZlLiBJZiA8c3RydWN0ZmllbGQ+cmVz
dGFydF9sc248L3N0cnVjdGZpZWxkPiBpcyBOVUxMLCB0aGlzCi0gICAgICAgZmllbGQgaXMg
bnVsbC4KKyAgICAgICBub24tbmVnYXRpdmUgYW5kL29yIDx4cmVmIGxpbmtlbmQ9Imd1Yy1p
ZGxlLXJlcGxpY2F0aW9uLXNsb3QtdGltZW91dCIvPgorICAgICAgIGlzIGdyZWF0ZXIgdGhh
biB6ZXJvLiBJZiA8c3RydWN0ZmllbGQ+cmVzdGFydF9sc248L3N0cnVjdGZpZWxkPiBpcyBO
VUxMLAorICAgICAgIHRoaXMgZmllbGQgaXMgbnVsbC4KICAgICAgIDwvcGFyYT48L2VudHJ5
PgogICAgICA8L3Jvdz4KIAotLSAKMi40OS4wCgo=

--------------8ex08rsonNtfqODXbwXZ8ilA--