Feedback-ID: ie0a040ee:Fastmail
Message-ID: <8f2e99ca-cce1-4b73-98ca-c4eec9aeb502@eisentraut.org>
Date: Tue, 11 Nov 2025 14:12:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Use uppercase keywords in foreign key tutorial
To: jian he <jian.universality@gmail.com>, David Rowley <dgrowleyml@gmail.com>
Cc: Erik Wienhold <ewie@ewie.name>, Tom Lane <tgl@sss.pgh.pa.us>,
 Bruce Momjian <bruce@momjian.us>, Nathan Bossart <nathandbossart@gmail.com>,
 Euler Taveira <euler@eulerto.com>, pgsql-docs@lists.postgresql.org
References: <aQE29YG5pY4Cl8ym@nathan> <aQJ6UIrQeC6impXg@momjian.us>
 <2903384.1761770924@sss.pgh.pa.us>
 <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
 <0a68a965-4599-4af1-a1eb-bd8e1be75788@ewie.name>
 <CAApHDvoqh_K2KTocwWYrGw5vLubnPnTzd1SvYTTonQ=vUXP7Ug@mail.gmail.com>
 <32882add-b671-42db-a041-e2c2c5b7c315@ewie.name>
 <CAApHDvraaZLdTm4XTLkgGhUwecpmNm1dOJMcEToak-Bh5742hQ@mail.gmail.com>
 <4487a138-c4d2-4b06-80b3-5afe7f8e5d82@ewie.name>
 <CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
 <971a5a3d-c200-4700-824b-f71a6e831994@ewie.name>
 <CAApHDvokYxXGORORfF_uP2PbaF-UagV-m3yySOfjzuqrVmWkCg@mail.gmail.com>
 <CACJufxG5UaQtoYFQKdMCYjpz_5Kggvdgm1gVEW4sNEa_W__FKA@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CACJufxG5UaQtoYFQKdMCYjpz_5Kggvdgm1gVEW4sNEa_W__FKA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/8f2e99ca-cce1-4b73-98ca-c4eec9aeb502%40eisentraut.org>
Precedence: bulk

On 10.11.25 04:15, jian he wrote:
> On Thu, Nov 6, 2025 at 11:06 AM David Rowley <dgrowleyml@gmail.com> wrote:
>>
>> I reviewed this and double checked you left "uPDaTE" in [1]. Found no
>> issues, so pushed.
>>
> 
> hi.
> 
> in doc/src/sgml/func/func-matching.sgml
> 
> <synopsis>
> substring(<replaceable>string</replaceable> similar
> <replaceable>pattern</replaceable> escape
> <replaceable>escape-character</replaceable>)
> </synopsis>
>      or using the now obsolete SQL:1999 syntax:
> <synopsis>
> substring(<replaceable>string</replaceable> from
> <replaceable>pattern</replaceable> for
> <replaceable>escape-character</replaceable>)
> </synopsis>
>      or as a plain three-argument function:
> <synopsis>
> substring(<replaceable>string</replaceable>,
> <replaceable>pattern</replaceable>,
> <replaceable>escape-character</replaceable>)
> </synopsis>
> 
> key word: "similar", "escape", "from", "for" within the above synopsis
> section need uppercase too?

I don't think that would be a good change.  substring is also a keyword, 
but it was said not to upper-case keywords used as functions.  So in my 
mind that should also apply to other syntax elements of function-like calls.