Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jZ8Re-0003LQ-JX
	for pgsql-docs@arkaria.postgresql.org; Thu, 14 May 2020 07:38:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jZ8Rc-0003iA-1f
	for pgsql-docs@arkaria.postgresql.org; Thu, 14 May 2020 07:38:16 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <daniel@yesql.se>)
	id 1jZ8Rb-0003i3-Rp
	for pgsql-docs@lists.postgresql.org; Thu, 14 May 2020 07:38:15 +0000
Received: from smtp.outgoing.loopia.se ([93.188.3.37])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <daniel@yesql.se>)
	id 1jZ8RZ-0003nK-My
	for pgsql-docs@postgresql.org; Thu, 14 May 2020 07:38:15 +0000
Received: from s807.loopia.se (localhost [127.0.0.1])
	by s807.loopia.se (Postfix) with ESMTP id 54296309B9CE
	for <pgsql-docs@postgresql.org>; Thu, 14 May 2020 09:38:11 +0200 (CEST)
Received: from s499.loopia.se (unknown [172.22.191.6])
	by s807.loopia.se (Postfix) with ESMTP id 342082EB3349;
	Thu, 14 May 2020 09:38:11 +0200 (CEST)
Received: from s474.loopia.se (unknown [172.22.191.6])
	by s499.loopia.se (Postfix) with ESMTP id 308531CDAEAD;
	Thu, 14 May 2020 09:38:11 +0200 (CEST)
X-Virus-Scanned: amavisd-new at amavis.loopia.se
X-Spam-Flag: NO
X-Spam-Score: -1
X-Spam-Level: 
X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2
	tests=[ALL_TRUSTED=-1] autolearn=disabled
Received: from s645.loopia.se ([172.22.191.6])
	by s474.loopia.se (s474.loopia.se [172.22.190.14]) (amavisd-new, port 10024)
	with LMTP id E6LpU57crNBD; Thu, 14 May 2020 09:38:10 +0200 (CEST)
X-Loopia-Auth: user
X-Loopia-User: daniel@yesql.se
X-Loopia-Originating-IP: 89.255.232.193
Received: from [192.168.72.43] (customer-89-255-232-193.stosn.net
 [89.255.232.193])
	(Authenticated sender: daniel@yesql.se)
	by s645.loopia.se (Postfix) with ESMTPSA id 6D735156E4C8;
	Thu, 14 May 2020 09:38:10 +0200 (CEST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: TLS docs fixes for <programlisting>
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20200514021713.GB166343@paquier.xyz>
Date: Thu, 14 May 2020 09:38:09 +0200
Cc: pgsql-docs@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <928D3FE2-7DB9-4AA9-9AAD-5CD1F09448EF@yesql.se>
References: <401F9024-20EA-4239-83C4-6B7AD35F94BD@yesql.se>
 <20200514021713.GB166343@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
X-Mailer: Apple Mail (2.3445.104.14)
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

> On 14 May 2020, at 04:17, Michael Paquier <michael@paquier.xyz> wrote:
>=20
> On Wed, May 13, 2020 at 11:07:44PM +0200, Daniel Gustafsson wrote:
>> While working with TLS I noticed that the password callback =
definition had an
>> extra newline in the programlisting in the docs.  Since the =
<programlisting>
>> has been indented with the textblock, the newline comes from =
whitespace being
>> significant.  The attached 0001 fixes by instead anchoring =
<programlisting> on
>> column zero like how most of the docs do it.  Grepping around I found =
one more
>> instance of the same pattern which is also included.
>=20
> Indeed, I can see the difference.  In what I spotted after applying
> 0001, you are patching the one in libpq.sgml as of 0002 but in a
> different, correct, way, and I have spotted three more inconsistencies
> within doc/src/sgml/datatype.sgml in the zone for timestamps.

Right, I omitted them to avoid churn since they are using =
<programlisting>
correctly, just in a different way from the rest of the docs.  I'll =
leave the
call whether they should be included for consistency sake to you.

> With everything I found on top of your stuff, I finish with the
> attached.  Does it look fine to you?

+1, thanks for picking it up!

cheers ./daniel=