Content-Type: multipart/mixed; boundary="------------0GxTmL60tm39onJll4vCYAsr"
Message-ID: <95d064d7-9902-436c-a4d2-a1155e4208c2@oss.nttdata.com>
Date: Wed, 2 Jul 2025 16:12:20 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Mention idle_replication_slot_timeout in pg_replication_slots
 docs
To: Nisha Moond <nisha.moond412@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
References: <78b34e84-2195-4f28-a151-5d204a382fdd@oss.nttdata.com>
 <CABdArM5r8wD8w1dTMh+ozXZw5TbiWRYHzrc2tCy6PNOsffHvLA@mail.gmail.com>
 <938e2d16-4449-413b-a2fc-2595e732e3e1@oss.nttdata.com>
 <CABdArM5qHWK9MTjq9Jj=35UYqv02BjRam0FPCLUHNaMceACpcA@mail.gmail.com>
 <c9d23cdc-b5dd-455a-8ee9-f1f24d701d89@oss.nttdata.com>
 <CABdArM4KqFVoSzZBYs4jPBEo=4e1kjcOpCF8rWZSthxZFcnWdw@mail.gmail.com>
 <8147005b-42b5-47d5-84a4-53965568fd6a@oss.nttdata.com>
 <CABdArM57-zFzXCg8bMYaEdjyVEndssR0qRXU9zA0Fnh5YUaiDg@mail.gmail.com>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CABdArM57-zFzXCg8bMYaEdjyVEndssR0qRXU9zA0Fnh5YUaiDg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/95d064d7-9902-436c-a4d2-a1155e4208c2%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------0GxTmL60tm39onJll4vCYAsr
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable


On 2025/07/01 13:52, Nisha Moond wrote:
> On Mon, Jun 30, 2025 at 6:12=E2=80=AFPM Fujii Masao <masao.fujii@oss.nt=
tdata.com> wrote:
>> Is this true starting from v16, when logical replication from standby =
was introduced?
>> In other words, in v15 and earlier, only max_slot_wal_keep_size could =
cause
>> the wal_status to become "unreserved" or "lost"? I'm wondering where t=
o back-patch
>> this fix to.
>>
>=20
> I also think we should back-patch this till v16, since that=E2=80=99s w=
hen
> additional slot invalidation causes were also introduced(commit
> be87200). And since then =E2=80=9Cmax_slot_wal_keep_size=E2=80=9D is no=
 longer the
> sole reason for =E2=80=9Cunreserved=E2=80=9D or =E2=80=9Clost=E2=80=9D =
status.

Okay, I've prepared two patches:

- 0001 removes the incorrect line: "If restart_lsn is NULL, this field is=
 null."
   This should be back-patched to v13.
- 0002 updates the description of the wal_status to reflect that max_slot=
_wal_keep_size
   is not the only cause of the lost state. This should be back-patched t=
o v16.

Barrng objections, I will commit these patches.

Regards,

--=20
Fujii Masao
NTT DATA Japan Corporation

--------------0GxTmL60tm39onJll4vCYAsr
Content-Type: text/plain; charset=UTF-8;
 name="v3-0001-doc-Remove-incorrect-note-about-wal_status-in-pg_.patch"
Content-Disposition: attachment;
 filename*0="v3-0001-doc-Remove-incorrect-note-about-wal_status-in-pg_.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBkOGI5YzFhYWNlM2YyMWJjOTE2ZDkwNTM4MDg5NDM3NmJiM2M3YTZmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFdlZCwgMiBKdWwgMjAyNSAxNTozNzo1MyArMDkwMApTdWJqZWN0OiBbUEFU
Q0ggdjMgMS8yXSBkb2M6IFJlbW92ZSBpbmNvcnJlY3Qgbm90ZSBhYm91dCB3YWxfc3RhdHVz
IGluCiBwZ19yZXBsaWNhdGlvbl9zbG90cy4KClRoZSBkb2N1bWVudGF0aW9uIHByZXZpb3Vz
bHkgc3RhdGVkIHRoYXQgdGhlIHdhbF9zdGF0dXMgY29sdW1uIGlzIE5VTEwKaWYgcmVzdGFy
dF9sc24gaXMgTlVMTCBpbiB0aGUgcGdfcmVwbGljYXRpb25fc2xvdHMgdmlldy4gVGhpcyBp
cyBpbmNvcnJlY3QsCmFuZCB3YWxfc3RhdHVzIGNhbiBiZSAibG9zdCIgZXZlbiB3aGVuIHJl
c3RhcnRfbHNuIGlzIE5VTEwuCgpUaGlzIGNvbW1pdCByZW1vdmVzIHRoZSBpbmNvcnJlY3Qg
ZGVzY3JpcHRpb24uCgpCYWNrLXBhdGNoZWQgdG8gYWxsIHN1cHBvcnRlZCB2ZXJzaW9ucy4K
CkF1dGhvcjogRnVqaWkgTWFzYW8gPG1hc2FvLmZ1amlpQGdtYWlsLmNvbT4KUmV2aWV3ZWQt
Ynk6IE5pc2hhIE1vb25kIDxuaXNoYS5tb29uZDQxMkBnbWFpbC5jb20+CkRpc2N1c3Npb246
IGh0dHBzOi8vcG9zdGdyLmVzL20vYzlkMjNjZGMtYjVkZC00NTVhLThlZTktZjFmMjRkNzAx
ZDg5QG9zcy5udHRkYXRhLmNvbQpCYWNrcGF0Y2gtdGhyb3VnaDogMTMKLS0tCiBkb2Mvc3Jj
L3NnbWwvc3lzdGVtLXZpZXdzLnNnbWwgfCAzICstLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z
ZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9z
eXN0ZW0tdmlld3Muc2dtbCBiL2RvYy9zcmMvc2dtbC9zeXN0ZW0tdmlld3Muc2dtbAppbmRl
eCA5ODZhZTFmNTQzZC4uODI4MjVkYjAzYmIgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9z
eXN0ZW0tdmlld3Muc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvc3lzdGVtLXZpZXdzLnNnbWwK
QEAgLTI4MzIsOCArMjgzMiw3IEBAIFNFTEVDVCAqIEZST00gcGdfbG9ja3MgcGwgTEVGVCBK
T0lOIHBnX3ByZXBhcmVkX3hhY3RzIHBweAogICAgICAgIDwvaXRlbWl6ZWRsaXN0PgogICAg
ICAgIFRoZSBsYXN0IHR3byBzdGF0ZXMgYXJlIHNlZW4gb25seSB3aGVuCiAgICAgICAgPHhy
ZWYgbGlua2VuZD0iZ3VjLW1heC1zbG90LXdhbC1rZWVwLXNpemUiLz4gaXMKLSAgICAgICBu
b24tbmVnYXRpdmUuIElmIDxzdHJ1Y3RmaWVsZD5yZXN0YXJ0X2xzbjwvc3RydWN0ZmllbGQ+
IGlzIE5VTEwsIHRoaXMKLSAgICAgICBmaWVsZCBpcyBudWxsLgorICAgICAgIG5vbi1uZWdh
dGl2ZS4KICAgICAgIDwvcGFyYT48L2VudHJ5PgogICAgICA8L3Jvdz4KIAotLSAKMi40OS4w
Cgo=
--------------0GxTmL60tm39onJll4vCYAsr
Content-Type: text/plain; charset=UTF-8;
 name="v3-0002-doc-Update-outdated-descriptions-of-wal_status-in.patch"
Content-Disposition: attachment;
 filename*0="v3-0002-doc-Update-outdated-descriptions-of-wal_status-in.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAzMjBlMjA4ZTQ0NDNlYjJjODlmNzc3ZWY5OTBmNjY1MzYyODU4OWI0IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFdlZCwgMiBKdWwgMjAyNSAxNjowMjoyOSArMDkwMApTdWJqZWN0OiBbUEFU
Q0ggdjMgMi8yXSBkb2M6IFVwZGF0ZSBvdXRkYXRlZCBkZXNjcmlwdGlvbnMgb2Ygd2FsX3N0
YXR1cyBpbgogcGdfcmVwbGljYXRpb25fc2xvdHMuCgpUaGUgZG9jdW1lbnRhdGlvbiBmb3Ig
cGdfcmVwbGljYXRpb25fc2xvdHMgcHJldmlvdXNseSBtZW50aW9uZWQgb25seQptYXhfc2xv
dF93YWxfa2VlcF9zaXplIGFzIGEgY29uZGl0aW9uIHVuZGVyIHdoaWNoIHRoZSB3YWxfc3Rh
dHVzIGNvbHVtbgpjb3VsZCBzaG93IHVucmVzZXJ2ZWQgb3IgbG9zdC4gSG93ZXZlciwgc2lu
Y2UgY29tbWl0IGJlODcyMDAsCnJlcGxpY2F0aW9uIHNsb3RzIGNhbiBhbHNvIGJlIGludmFs
aWRhdGVkIGR1ZSB0byBob3Jpem9uIG9yIHdhbF9sZXZlbCwKYW5kIHNpbmNlIGNvbW1pdCBh
YzBlMzMxMzZhYiwgaWRsZV9yZXBsaWNhdGlvbl9zbG90X3RpbWVvdXQgY2FuIGFsc28KdHJp
Z2dlciB0aGlzIHN0YXRlLgoKVGhpcyBjb21taXQgdXBkYXRlcyB0aGUgZGVzY3JpcHRpb24g
b2YgdGhlIHdhbF9zdGF0dXMgY29sdW1uIHRvCnJlZmxlY3QgdGhhdCBtYXhfc2xvdF93YWxf
a2VlcF9zaXplIGlzIG5vdCB0aGUgb25seSBjYXVzZSBvZiB0aGUgbG9zdCBzdGF0ZS4KCkJh
Y2stcGF0Y2hlZCB0byB2MTYsIHdoZXJlIHRoZSBhZGRpdGlvbmFsIGludmFsaWRhdGlvbiBj
YXNlcyB3ZXJlIGludHJvZHVjZWQuCgpBdXRob3I6IEZ1amlpIE1hc2FvIDxtYXNhby5mdWpp
aUBnbWFpbC5jb20+ClJldmlld2VkLWJ5OiBIYXlhdG8gS3Vyb2RhIDxrdXJvZGEuaGF5YXRv
QGZ1aml0c3UuY29tPgpSZXZpZXdlZC1ieTogTmlzaGEgTW9vbmQgPG5pc2hhLm1vb25kNDEy
QGdtYWlsLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS83OGIzNGU4NC0y
MTk1LTRmMjgtYTE1MS01ZDIwNGEzODJmZGRAb3NzLm50dGRhdGEuY29tCkJhY2twYXRjaC10
aHJvdWdoOiAxNwotLS0KIGRvYy9zcmMvc2dtbC9zeXN0ZW0tdmlld3Muc2dtbCB8IDEwICsr
KystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z
KC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3N5c3RlbS12aWV3cy5zZ21sIGIvZG9j
L3NyYy9zZ21sL3N5c3RlbS12aWV3cy5zZ21sCmluZGV4IDgyODI1ZGIwM2JiLi5lMWFjNTQ0
ZWU0MCAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3N5c3RlbS12aWV3cy5zZ21sCisrKyBi
L2RvYy9zcmMvc2dtbC9zeXN0ZW0tdmlld3Muc2dtbApAQCAtMjgxOSwyMCArMjgxOSwxOCBA
QCBTRUxFQ1QgKiBGUk9NIHBnX2xvY2tzIHBsIExFRlQgSk9JTiBwZ19wcmVwYXJlZF94YWN0
cyBwcHgKICAgICAgICAgIDxwYXJhPgogICAgICAgICAgIDxsaXRlcmFsPnVucmVzZXJ2ZWQ8
L2xpdGVyYWw+IG1lYW5zIHRoYXQgdGhlIHNsb3Qgbm8gbG9uZ2VyCiAgICAgICAgICAgcmV0
YWlucyB0aGUgcmVxdWlyZWQgV0FMIGZpbGVzIGFuZCBzb21lIG9mIHRoZW0gYXJlIHRvIGJl
IHJlbW92ZWQgYXQKLSAgICAgICAgICB0aGUgbmV4dCBjaGVja3BvaW50LiAgVGhpcyBzdGF0
ZSBjYW4gcmV0dXJuCisgICAgICAgICAgdGhlIG5leHQgY2hlY2twb2ludC4gIFRoaXMgdHlw
aWNhbGx5IG9jY3VycyB3aGVuCisgICAgICAgICAgPHhyZWYgbGlua2VuZD0iZ3VjLW1heC1z
bG90LXdhbC1rZWVwLXNpemUiLz4gaXMgc2V0IHRvCisgICAgICAgICAgYSBub24tbmVnYXRp
dmUgdmFsdWUuICBUaGlzIHN0YXRlIGNhbiByZXR1cm4KICAgICAgICAgICB0byA8bGl0ZXJh
bD5yZXNlcnZlZDwvbGl0ZXJhbD4gb3IgPGxpdGVyYWw+ZXh0ZW5kZWQ8L2xpdGVyYWw+Lgog
ICAgICAgICAgPC9wYXJhPgogICAgICAgICA8L2xpc3RpdGVtPgogICAgICAgICA8bGlzdGl0
ZW0+CiAgICAgICAgICA8cGFyYT4KLSAgICAgICAgICA8bGl0ZXJhbD5sb3N0PC9saXRlcmFs
PiBtZWFucyB0aGF0IHNvbWUgcmVxdWlyZWQgV0FMIGZpbGVzIGhhdmUKLSAgICAgICAgICBi
ZWVuIHJlbW92ZWQgYW5kIHRoaXMgc2xvdCBpcyBubyBsb25nZXIgdXNhYmxlLgorICAgICAg
ICAgIDxsaXRlcmFsPmxvc3Q8L2xpdGVyYWw+IG1lYW5zIHRoYXQgdGhpcyBzbG90IGlzIG5v
IGxvbmdlciB1c2FibGUuCiAgICAgICAgICA8L3BhcmE+CiAgICAgICAgIDwvbGlzdGl0ZW0+
CiAgICAgICAgPC9pdGVtaXplZGxpc3Q+Ci0gICAgICAgVGhlIGxhc3QgdHdvIHN0YXRlcyBh
cmUgc2VlbiBvbmx5IHdoZW4KLSAgICAgICA8eHJlZiBsaW5rZW5kPSJndWMtbWF4LXNsb3Qt
d2FsLWtlZXAtc2l6ZSIvPiBpcwotICAgICAgIG5vbi1uZWdhdGl2ZS4KICAgICAgIDwvcGFy
YT48L2VudHJ5PgogICAgICA8L3Jvdz4KIAotLSAKMi40OS4wCgo=

--------------0GxTmL60tm39onJll4vCYAsr--