public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Daniel Gustafsson <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Missing File weather.txt
Date: Fri, 11 Jul 2025 08:36:38 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>



On 2025/07/11 7:22, Daniel Gustafsson wrote:
>> On 5 Jul 2025, at 19:29, Tom Lane <[email protected]> wrote:
>>
>> Fujii Masao <[email protected]> writes:
>>> On 2020/01/28 19:18, Daniel Gustafsson wrote:
>>>> This is only mentioned as an example of another input method, with a link to
>>>> the COPY page for more information.  That being said, it's a good thing for a
>>>> tutorial to be self-contained, and going from a basic tutorial to the COPY
>>>> reference page is a fairly large step.  I propose that we add a small example
>>>> on what weather.txt could look like as per the attached diff.
>>
>>> Sorry for reviving this old thread, but I wanted to follow up since
>>> the same issue was reported again in [1], and the proposed patch
>>> basically looks good to me.
>>
>> +1
>>
>>> In the tutorial, three rows are inserted using INSERT, so shouldn't
>>> the sample input for COPY include all three, like this?
>>
>> Agreed, the example file should match what the tutorial expects to be
>> in the table.  I'd include text along the lines of "The data inserted
>> above could also be inserted from a file containing:".
> 
> The attached v2 adds the missing line, and tweaks the text added to document
> the file.

Thanks for updating the patch! LGTM.

Just one small comment:

+Hayward    37    54    0.0    1994-11-29

This row is inserted using the following INSERT statement:

     INSERT INTO weather (date, city, temp_hi, temp_lo)
         VALUES ('1994-11-29', 'Hayward', 54, 37);

Since the prcp column isn't specified, its value is NULL. So shouldn't
the fourth field in the data line above be \N instead of 0.0?


>  Since there have been reports I propose backpatching this all the
> way down to 13 while at it.

+1

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Missing File weather.txt
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox