X-Original-To: pgsql-docs-postgresql.org@postgresql.org
Received: from localhost (mx1.hub.org [200.46.208.251])
	by postgresql.org (Postfix) with ESMTP id 618119FB205
	for <pgsql-docs-postgresql.org@postgresql.org>;
	Thu,  3 Aug 2006 23:50:35 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024)
	with ESMTP id 95208-05 for <pgsql-docs-postgresql.org@postgresql.org>;
	Thu,  3 Aug 2006 23:50:34 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by postgresql.org (Postfix) with ESMTP id 831A79FB1FB
	for <pgsql-docs@postgresql.org>; Thu,  3 Aug 2006 23:50:33 -0300 (ADT)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id k742oHQm000970;
	Thu, 3 Aug 2006 22:50:17 -0400 (EDT)
To: pgsql-hackers@postgresql.org, Gavin Sherry <swm@linuxworld.com.au>
cc: Michael Glaesemann <grzm@seespotcode.net>,
 Joe Conway <mail@joeconway.com>,
	pgsql-patches@postgresql.org, pgsql-docs@postgresql.org
Subject: Re: [PATCHES] Values list-of-targetlists patch for comments (was Re: 
In-reply-to: <Pine.LNX.4.58.0608041040550.16622@linuxworld.com.au> 
References: <44B69778.5050104@dunslane.net> <44B7ADFC.90205@dunslane.net>
	<44BC0432.3040509@joeconway.com> <44BC661F.80609@joeconway.com>
	<44CFFD2D.8040906@joeconway.com>
	<Pine.LNX.4.58.0608031523090.4590@linuxworld.com.au>
	<18685.1154617090@sss.pgh.pa.us>
	<429A0065-78C7-48C9-B2DC-E898988F93E6@seespotcode.net>
	<Pine.LNX.4.58.0608041040550.16622@linuxworld.com.au>
Comments: In-reply-to Gavin Sherry <swm@linuxworld.com.au>
	message dated "Fri, 04 Aug 2006 10:42:02 +1000"
Date: Thu, 03 Aug 2006 22:50:17 -0400
Message-ID: <969.1154659817@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0.158 tagged_above=0 required=5 tests=AWL,
	SPF_HELO_PASS, SPF_PASS
X-Spam-Level: 
X-Archive-Number: 200608/10
X-Sequence-Number: 3628

Gavin Sherry <swm@linuxworld.com.au> writes:
> On Fri, 4 Aug 2006, Michael Glaesemann wrote:
>> On Aug 3, 2006, at 23:58 , Tom Lane wrote:
>>> Should we give VALUES its own reference page?  That doesn't quite
>>> seem helpful either.
>> 
>> I think we should go for a separate reference page, as VALUES appears
>> to be expanding quite a bit.

> ... with update? I associate it very closely with INSERT. After all,
> INSERT is the only statement where we've had VALUES as part of the
> grammar.

True, but I think that's just a historical artifact.  If you look at the
SQL spec, INSERT ... VALUES and INSERT ... SELECT are not distinct
constructs: they fall out of the fact that VALUES and SELECT are allowed
interchangeably.

         <insert statement> ::=
              INSERT INTO <table name>
                <insert columns and source>

         <insert columns and source> ::=
                [ <left paren> <insert column list> <right paren> ]
              <query expression>
              | DEFAULT VALUES

         <insert column list> ::= <column name list>

and when you trace down <query expression> you find the SELECT
and VALUES options entering at exactly the same place ...

I'd like to see us refactor the docs as necessary to reflect that idea.
Peter is right that this needs some discussion in syntax.sgml as well as
in the reference pages --- but I'm still not very clear on how the
presentation should go.

			regards, tom lane