Date: Wed, 5 Nov 2025 19:09:28 +0100
From: Erik Wienhold <ewie@ewie.name>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>,
	Nathan Bossart <nathandbossart@gmail.com>, Euler Taveira <euler@eulerto.com>,
	pgsql-docs@lists.postgresql.org
Subject: Re: Use uppercase keywords in foreign key tutorial
Message-ID: <971a5a3d-c200-4700-824b-f71a6e831994@ewie.name>
References: <aQE29YG5pY4Cl8ym@nathan>
 <aQJ6UIrQeC6impXg@momjian.us>
 <2903384.1761770924@sss.pgh.pa.us>
 <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
 <0a68a965-4599-4af1-a1eb-bd8e1be75788@ewie.name>
 <CAApHDvoqh_K2KTocwWYrGw5vLubnPnTzd1SvYTTonQ=vUXP7Ug@mail.gmail.com>
 <32882add-b671-42db-a041-e2c2c5b7c315@ewie.name>
 <CAApHDvraaZLdTm4XTLkgGhUwecpmNm1dOJMcEToak-Bh5742hQ@mail.gmail.com>
 <4487a138-c4d2-4b06-80b3-5afe7f8e5d82@ewie.name>
 <CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="s2j2a4mecdx56knb"
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/971a5a3d-c200-4700-824b-f71a6e831994%40ewie.name>
Precedence: bulk


--s2j2a4mecdx56knb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On 2025-11-04 03:09 +0100, David Rowley wrote:
> On Tue, 4 Nov 2025 at 13:04, Erik Wienhold <ewie@ewie.name> wrote:
> >
> > On 2025-11-03 23:37 +0100, David Rowley wrote:
> > > I'm starting to wonder if adjusting the spacing here is a worthwhile
> > > change.
> >
> > I think it's worth to have that consistency.  If the patch is too broad
> > I can of course limit it to the listings with inconsistent keyword
> > casing which is more less patch v2 plus some changes from v3 and later.
> >
> > Or just fix the keywords for now to get that out of the way and deal
> > with the spacing in a separate patch/thread.
> 
> I think just the keyword upper casing is a good idea for now. I'm
> starting to lose hope that there's enough merit and consistency to the
> proposed whitespace changes. Maybe there's a subset of it that does
> make sense to do.

Done in the attached v6.  But I kept the few whitespace changes on lines
where I change keywords to uppercase.  It's mostly a single space after
commas in column and parameter lists which I think also enhances
readability.

-- 
Erik Wienhold

--s2j2a4mecdx56knb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v6-0001-doc-Use-uppercase-keywords.patch"