Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jNgTv-0007dV-Ni
	for pgsql-docs@arkaria.postgresql.org; Sun, 12 Apr 2020 17:33:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1jNgTu-00077C-5S
	for pgsql-docs@arkaria.postgresql.org; Sun, 12 Apr 2020 17:33:18 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jNgTt-00076G-Vg
	for pgsql-docs@lists.postgresql.org; Sun, 12 Apr 2020 17:33:17 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jNgTq-00046U-PO
	for pgsql-docs@lists.postgresql.org; Sun, 12 Apr 2020 17:33:17 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 03CHXB8A009780;
	Sun, 12 Apr 2020 13:33:11 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
cc: pgsql-docs@lists.postgresql.org
Subject: Re: Getting our tables to render better in PDF output
In-reply-to: <701.1586638307@sss.pgh.pa.us>
References: <20200212221818.GA15503@alvherre.pgsql>
 <23574.1581555393@sss.pgh.pa.us> <10810.1581883655@sss.pgh.pa.us>
 <5d1f5b72-1b4a-6e15-6730-d94e2252a073@gmail.com>
 <525a6c9e-a4e2-cd8f-54b6-b69f40d70289@gmail.com>
 <701.1586638307@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 11 Apr 2020 16:51:47 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <9672.1586712639.0@sss.pgh.pa.us>
Date: Sun, 12 Apr 2020 13:33:11 -0400
Message-ID: <9779.1586712791@sss.pgh.pa.us>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9672.1586712639.1@sss.pgh.pa.us>

I wrote:
> So if we can get <returnvalue> to both insert a right arrow and switch the
> font to match <type>'s choice, this would work more or less decently, and
> it's probably cleaner than the bare-entity-reference approach I posted
> before.  I don't have the XSL skills to get that to work though.
> Anyone want to help out?

I educated myself a teensy bit about XSL, and unless I'm missing
something, this is really pretty darn trivial; the attached seems
to do the trick.

I experimented with the markup from <guimenuitem> and decided that
I didn't like their choice of a smaller font size in this context;
it looks better to me to leave the arrow full-size.  The important
thing to learn from that precedent seems to be that we have to
specify the font correctly, as indeed is mentioned in the docbook
documentation.  So it seems to work well to just use

    <fo:inline font-family="{$symbol.font.family}">&#x2192; </fo:inline>

(The extra space seems to be necessary, else the arrow ends up
adjacent to the type name.)

So I'm pretty happy with this implementation and will push forward.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="markup-for-returnvalue.patch";
	charset="us-ascii"
Content-ID: <9672.1586712639.2@sss.pgh.pa.us>
Content-Description: markup-for-returnvalue.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/doc/src/sgml/stylesheet-common.xsl b/doc/src/sgml/stylesheet-=
common.xsl
index e148c90..5936d9a 100644
--- a/doc/src/sgml/stylesheet-common.xsl
+++ b/doc/src/sgml/stylesheet-common.xsl
@@ -49,6 +49,11 @@
   <xsl:call-template name=3D"inline.charseq"/>
 </xsl:template>
 =

+<xsl:template match=3D"returnvalue">
+  &#x2192;
+  <xsl:call-template name=3D"inline.monoseq"/>
+</xsl:template>
+
 <xsl:template match=3D"structfield">
   <xsl:call-template name=3D"inline.monoseq"/>
 </xsl:template>
diff --git a/doc/src/sgml/stylesheet-fo.xsl b/doc/src/sgml/stylesheet-fo.x=
sl
index ea75408..a3b6463 100644
--- a/doc/src/sgml/stylesheet-fo.xsl
+++ b/doc/src/sgml/stylesheet-fo.xsl
@@ -63,6 +63,12 @@
   </fo:inline>
 </xsl:template>
 =

+<!-- overrides stylesheet-common.xsl -->
+<xsl:template match=3D"returnvalue">
+  <fo:inline font-family=3D"{$symbol.font.family}">&#x2192; </fo:inline>
+  <xsl:call-template name=3D"inline.monoseq"/>
+</xsl:template>
+
 <!-- bug fix from <https://sourceforge.net/p/docbook/bugs/1360/#831b> -->
 =

 <xsl:template match=3D"varlistentry/term" mode=3D"xref-to">

------- =_aaaaaaaaaa0--