public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Bruce Momjian <[email protected]>
To: PostgreSQL-documentation <[email protected]>
Subject: Re: Quoting of *_command arguments
Date: Wed, 12 Nov 2025 14:45:16 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On 11.11.25 20:31, Bruce Momjian wrote:
> We inconsistently double-quote the "%f" and "%p" arguments of
> "archive_command" and "restore_command".  Paths with spaces or special
> characters, especially directory names in these cases, would need
> double-quotes.
> 
> This patch adds double-quotes to all instances.  I can also go the other
> way and remove them all, but we should be consistent.

I think %f doesn't need to be quoted because it will only contain 
certain characters, but if we tried to clarify that it would probably be 
too confusing.  It makes sense to nudge people that some quoting is prudent.

Your patch looks good to me.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Quoting of *_command arguments
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox