Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Curt Kolovson <ckolovson@gmail.com>
Mime-Version: 1.0 (1.0)
Subject: Re: Bug in documentation:
 https://www.postgresql.org/docs/current/spi-examples.html
Date: Mon, 17 Jul 2023 19:45:24 -0700
Message-Id: <9F566B71-42A3-4502-85CA-076BA8C5BDD5@gmail.com>
References: <4124246.1689647806@sss.pgh.pa.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 pgsql-docs@lists.postgresql.org
In-Reply-To: <4124246.1689647806@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/9F566B71-42A3-4502-85CA-076BA8C5BDD5%40gmail.com>
Precedence: bulk

I=E2=80=99d vote for showing both (with RETURNING and without), since withou=
t it the second argument to SPI_exec has no effect in this example, which ma=
y not be obvious. That seems to be one of the subtle points illustrated by t=
his example.=20

> On Jul 17, 2023, at 7:36 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> =EF=BB=BF"David G. Johnston" <david.g.johnston@gmail.com> writes:
>>> On Mon, Jul 17, 2023 at 6:22=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
>>> I think his point is that this example does not behave as the
>>> documentation claims.  Which it does not, according to my
>>> tests here.  I find this a bit disturbing --- did we intentionally
>>> change the behavior of SPI_exec somewhere along the line?
>=20
>> Appears to be a documentation fix oversight back in v9.0
>> https://github.com/postgres/postgres/commit/2ddc600f8f0252a0864e85d5cc1ee=
b3b9687d7e9
>=20
> Ah, thanks for the pointer.  I'd just been trying to bisect where
> between 8.4 and 9.0 it changed, but failed because early-9.0 versions
> don't build at all with current bison :-(
>=20
> Anyway, given that the example needs updating, how should we do that
> exactly?  Is it worth demonstrating both the behavior with RETURNING
> and that without?  If not, which one to show?
>=20
>            regards, tom lane