Message-ID: <9b3e1b97-4d2f-25af-fa52-1b2c31511444@enterprisedb.com>
Date: Fri, 18 Feb 2022 08:07:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: maximum number of backtrace frames logged by backtrace_functions
Content-Language: en-US
To: Fujii Masao <masao.fujii@oss.nttdata.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@lists.postgresql.org
References: <0f0ed9f3-3892-e8a3-51c9-ed268dff6bdd@oss.nttdata.com>
 <4e16a3e9-e717-05e1-d905-6c21beba80f8@enterprisedb.com>
 <b22cd3c0-d76b-0379-5971-8637b65b8e87@oss.nttdata.com>
 <b219d7c9-fb66-c762-ce90-ef20c0667a02@enterprisedb.com>
 <252159.1643899696@sss.pgh.pa.us>
 <e312116f-9c44-b7f6-3cfc-4c67f50bbbc7@oss.nttdata.com>
 <33675df8-60e1-7da6-8995-3743668fd682@oss.nttdata.com>
 <b56ce3bf-d308-8dcf-7eaf-e1d3acd021a1@enterprisedb.com>
 <e4ea7dc1-2925-21e1-27b1-44e47b2122bb@oss.nttdata.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <e4ea7dc1-2925-21e1-27b1-44e47b2122bb@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/9b3e1b97-4d2f-25af-fa52-1b2c31511444%40enterprisedb.com>
Precedence: bulk

On 07.02.22 17:42, Fujii Masao wrote:
> On 2022/02/08 1:12, Peter Eisentraut wrote:
>> This change looks good to me.  There is also backtrace code in 
>> assert.c that might want the same treatment.
> 
> Yeah, that's good idea! The attached patch also adds the same treatment 
> into assert.c.

I don't know if using write_stderr() is the right thing here.  Since 
backtrace_symbols_fd() writes directly to stderr in any case, the whole 
Windows-specific eventlog dance in write_stderr() wouldn't make sense 
even if this feature supported Windows.  So I'd just do a straight 
fprintf(stderr) there.