Message-ID: <9e64d4f34fdf686c09e4b5a86595dfe9645077bc.camel@cybertec.at>
Subject: Re: [PATCH] fix ICU explorer link in locale documentation
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Bruce Momjian <bruce@momjian.us>
Cc: Anton Voloshin <a.voloshin@postgrespro.ru>, Magnus Hagander
	 <magnus@hagander.net>, Pg Docs <pgsql-docs@lists.postgresql.org>
Date: Wed, 29 Sep 2021 12:13:33 +0200
In-Reply-To: <20210927183103.GA12052@momjian.us>
References: <68f32992-7ba7-f797-2bb3-8851bd70d95d@postgrespro.ru>
	 <CABUevEzePbHCk75uzzpRwLbv0Evra1sFt3YAi=ahtmkADQ0tHw@mail.gmail.com>
	 <ca09a8ad-5361-4e5e-4e13-4017fa593bb0@postgrespro.ru>
	 <279934e1ab80d511d2739f840db1685d756ff99c.camel@cybertec.at>
	 <865474b6ab538cdd9419672c4bf2aba47ee3e9f3.camel@cybertec.at>
	 <20210927183103.GA12052@momjian.us>
Content-Type: multipart/mixed; boundary="=-ywsMzONzYSCm2Pou/Y77"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/9e64d4f34fdf686c09e4b5a86595dfe9645077bc.camel%40cybertec.at>
Precedence: bulk


--=-ywsMzONzYSCm2Pou/Y77
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On Mon, 2021-09-27 at 14:31 -0400, Bruce Momjian wrote:
> On Fri, Sep  3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote:
> > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote:
> > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is 
> > > > still the proper one, and eventually it will be fixed. Anyway, the old 
> > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through 
> > > > "wrong domain in certificate" errors, still redirects to the same
> > > > https://icu4c-demos.unicode.org/icu-bin/locexp
> > > > 
> > > > I believe changing link in Postgres' docs is better than keeping the old 
> > > > one, even though they are currently both 404 one way or another. At 
> > > > least it would save people following that link from scary "Warning: 
> > > > Potential Security Risk Ahead" messages before properly 404-ing.
> > > 
> > > I suggest that we wait until the end of the June 2021 commitfest and decide then.
> > > If it is still not fixed then, the second option is better - or we move it to
> > > the next commitfest.
> > 
> > It is way past that time, and the link is still broken.
> > 
> > So I guess it would be the best to remove the link from the documentation.
> 
> Should we change it to a link to the locexp source?
> 
>         https://github.com/unicode-org/icu-demos/tree/main/locexp
> 
>         This is the source for the locale explorer CGI which is on IBM's
>         external website at:
>         
>             http://demo.icu-project.org/icu-bin/locexp

I had a look at that and tried to build the software from source.
It requires you to build ICU, and even then it failed to build for me.
The build documentation is not very detailed.
So I think we should not link to that.

I noticed that two more external links have moved.

Attached is a patch that fixes those links and removes the link to
the locale explorer.

Yours,
Laurenz Albe

--=-ywsMzONzYSCm2Pou/Y77
Content-Disposition: attachment; filename="0001-Fix-external-ICU-links.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name="0001-Fix-external-ICU-links.patch";
 charset="UTF-8"

RnJvbSAxMGMzM2E5MGE5NDZhNDMzN2UzN2U1NDI5M2U1MzllNmY4Y2QyOTU0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogV2VkLCAyOSBTZXAgMjAyMSAxMjowOToxOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hd
IEZpeCBleHRlcm5hbCBJQ1UgbGlua3MKClRoZSBsaW5rcyBleHBsYWluaW5nIElDVSBsb2NhbGVz
IGFuZCBJQ1UgQVBJIGRldGFpbHMgaGF2ZSBtb3ZlZC4KCkFsc28sIHJlbW92ZSB0aGUgbGluayB0
byB0aGUgIklDVSBMb2NhbGUgRXhwbG9yZXIiLCBzaW5jZSBpdCBpcwpubyBsb25nZXIgYXZhaWxh
YmxlLiAgV2UgY291bGQgaGF2ZSBhZGRlZCBhIGxpbmsgdG8gdGhlIHNvdXJjZQphdCBodHRwczov
L2dpdGh1Yi5jb20vdW5pY29kZS1vcmcvaWN1LWRlbW9zLCBidXQgdGhlIGJ1aWxkCmRvY3VtZW50
YXRpb24gaXMgbm90IHZlcnkgZGV0YWlsZWQsIGFuZCBhbiBhdHRlbXB0IHRvIGJ1aWxkCmZhaWxl
ZCBkdWUgdG8gbWlzc2luZyBoZWFkZXJzIG9mIHVuc3BlY2lmaWVkIG9yaWdpbi4KCkF1dGhvcjog
QW50b24gVm9sb3NoaW4KUmV2aWV3ZWQtYnk6IExhdXJlbnogQWxiZQoKRGlzY3Vzc2lvbjogaHR0
cHM6Ly9wb3N0Z3IuZXMvbS82OGYzMjk5Mi03YmE3LWY3OTctMmJiMy04ODUxYmQ3MGQ5NWRAcG9z
dGdyZXNwcm8ucnUKLS0tCiBkb2Mvc3JjL3NnbWwvY2hhcnNldC5zZ21sIHwgOCArKy0tLS0tLQog
MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9kb2Mvc3JjL3NnbWwvY2hhcnNldC5zZ21sIGIvZG9jL3NyYy9zZ21sL2NoYXJzZXQuc2dt
bAppbmRleCAwNWE2YmY1NjhmLi5mMjAzYzM2OGMyIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwv
Y2hhcnNldC5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9jaGFyc2V0LnNnbWwKQEAgLTc0Nyw4ICs3
NDcsOCBAQCBDUkVBVEUgQ09MTEFUSU9OIGdlcm1hbiAocHJvdmlkZXIgPSBsaWJjLCBsb2NhbGUg
PSAnZGVfREUnKTsKICAgICBzZXQgdGhhdCBpcyBwcmVsb2FkZWQgYnkgPGNvbW1hbmQ+aW5pdGRi
PC9jb21tYW5kPi4gIFVzZXJzIGFyZSBlbmNvdXJhZ2VkCiAgICAgdG8gZGVmaW5lIHRoZWlyIG93
biBjb2xsYXRpb24gb2JqZWN0cyB0aGF0IG1ha2UgdXNlIG9mIHRoZXNlIGZhY2lsaXRpZXMgdG8K
ICAgICBzdWl0IHRoZSBzb3J0aW5nIGJlaGF2aW9yIHRvIHRoZWlyIHJlcXVpcmVtZW50cy4KLSAg
ICBTZWUgPHVsaW5rIHVybD0iaHR0cDovL3VzZXJndWlkZS5pY3UtcHJvamVjdC5vcmcvbG9jYWxl
Ij48L3VsaW5rPgotICAgIGFuZCA8dWxpbmsgdXJsPSJodHRwOi8vdXNlcmd1aWRlLmljdS1wcm9q
ZWN0Lm9yZy9jb2xsYXRpb24vYXBpIj48L3VsaW5rPiBmb3IKKyAgICBTZWUgPHVsaW5rIHVybD0i
aHR0cHM6Ly91bmljb2RlLW9yZy5naXRodWIuaW8vaWN1L3VzZXJndWlkZS9sb2NhbGUvIj48L3Vs
aW5rPgorICAgIGFuZCA8dWxpbmsgdXJsPSJodHRwczovL3VuaWNvZGUtb3JnLmdpdGh1Yi5pby9p
Y3UvdXNlcmd1aWRlL2NvbGxhdGlvbi9hcGkuaHRtbCI+PC91bGluaz4gZm9yCiAgICAgaW5mb3Jt
YXRpb24gb24gSUNVIGxvY2FsZSBuYW1pbmcuICBUaGUgc2V0IG9mIGFjY2VwdGFibGUgbmFtZXMg
YW5kCiAgICAgYXR0cmlidXRlcyBkZXBlbmRzIG9uIHRoZSBwYXJ0aWN1bGFyIElDVSB2ZXJzaW9u
LgogICAgPC9wYXJhPgpAQCAtODQyLDEwICs4NDIsNiBAQCBDUkVBVEUgQ09MTEFUSU9OIGdlcm1h
biAocHJvdmlkZXIgPSBsaWJjLCBsb2NhbGUgPSAnZGVfREUnKTsKICAgICBzdWJ0YWcpIGNhbiBi
ZSBmb3VuZCBpbgogICAgIHRoZSA8dWxpbmsgdXJsPSJodHRwczovL2dpdGh1Yi5jb20vdW5pY29k
ZS1vcmcvY2xkci9ibG9iL21hc3Rlci9jb21tb24vYmNwNDcvY29sbGF0aW9uLnhtbCI+Q0xEUgog
ICAgIHJlcG9zaXRvcnk8L3VsaW5rPi4KLSAgICBUaGUgPHVsaW5rIHVybD0iaHR0cHM6Ly9zc2wu
aWN1LXByb2plY3Qub3JnL2ljdS1iaW4vbG9jZXhwIj5JQ1UgTG9jYWxlCi0gICAgRXhwbG9yZXI8
L3VsaW5rPiBjYW4gYmUgdXNlZCB0byBjaGVjayB0aGUgZGV0YWlscyBvZiBhIHBhcnRpY3VsYXIg
bG9jYWxlCi0gICAgZGVmaW5pdGlvbi4gIFRoZSBleGFtcGxlcyB1c2luZyB0aGUgPGxpdGVyYWw+
ayo8L2xpdGVyYWw+IHN1YnRhZ3MgcmVxdWlyZQotICAgIGF0IGxlYXN0IElDVSB2ZXJzaW9uIDU0
LgogICAgPC9wYXJhPgogCiAgICA8cGFyYT4KLS0gCjIuMzEuMQoK


--=-ywsMzONzYSCm2Pou/Y77--