Message-ID: <9f703511c57d6bb0f44f9a968414869854ae50ea.camel@cybertec.at>
Subject: Re: small patch
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: rir <rirans@comcast.net>
Cc: pgsql-docs@lists.postgresql.org
Date: Thu, 07 Oct 2021 07:58:47 +0200
In-Reply-To: <20211007033905.pmsg5qnyqceepfva@localhost>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
	 <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
	 <20211007033905.pmsg5qnyqceepfva@localhost>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/9f703511c57d6bb0f44f9a968414869854ae50ea.camel%40cybertec.at>
Precedence: bulk

On Wed, 2021-10-06 at 23:39 -0400, rir wrote:
> On Mon, Oct 04, 2021 at 08:18:22AM +0200, Laurenz Albe wrote:
> > On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> > > Minor changes to move.sgml and fetch.sgml.
> > > 
> > > The text 'or empty' is inconsistent by restating what the
> > > synopsis notation has expressed.
> > > 
> > > The comments on sharing a language feature, while
> > > likely helpful during review, seem verbose compared to
> > > the non-commenting in other similar files.
> > 
> > Thanks for the effort of preparing a patch.
> > 
> > However, I don't think that is an improvement:
> > 
> > - the comments pointing from MOVE to FETCH and vice versa are
> >   helpful for people who edit the documentation like you did
> > - we should retain "empty or one of", otherwise the following syntax
> >   would be undocumented:
> > 
> >       FETCH FROM c;
> 
> Your view is completely reasonable, but it suggests that
> many of the synopses are leaving syntax undocumented.
> The 'empty or one of:' is only used in these two synopses.

You have a point there.

Can you think of a way to modify the syntax diagram so that it
expresses that and still remains comprehensible?

Yours,
Laurenz Albe