Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id 7255E13364DE for ; Thu, 23 Dec 2010 21:49:51 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 80545-04 for ; Fri, 24 Dec 2010 01:49:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-iw0-f174.google.com (mail-iw0-f174.google.com [209.85.214.174]) by mail.postgresql.org (Postfix) with ESMTP id 8958B1337BD2 for ; Thu, 23 Dec 2010 21:49:43 -0400 (AST) Received: by iwn9 with SMTP id 9so6663384iwn.19 for ; Thu, 23 Dec 2010 17:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=yohpSAHmQSf2kXXjFhsN2Lxbd4VndfPGEJqCqqVvGV8=; b=l/P32uAY+9ac5aYCdb843PdAt2pREgSw71X6iXYUsbvQihgHt1RTK7ZKyujFB9kBmg 1sOY6dIcteeajuwhmVxf0I2o5V08e/FmMz8sSQl9GAFWg0y6pDgjW1RKkMtohP2Nxd1M 1krM5j7VxnrWwkzKOPQPL8CNEAcTyKMrIsXFQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Zu2VIuH1z5f2bBW/plF0n09gXgQ0X3sSCqcW0PkGcLirYQsARS1I4xNKBz1jYkV+Pg sH/AYh56Exj+FS89RIxNyuBVftGPrTw4jhc9O4ydhgpoc9YPEwWWsbHpPMCApwcZQQug FpoHslVZqZL2R8OT51N25HNSt3jPUa6iTXy+A= MIME-Version: 1.0 Received: by 10.42.173.10 with SMTP id p10mr9018867icz.142.1293155383774; Thu, 23 Dec 2010 17:49:43 -0800 (PST) Received: by 10.42.177.134 with HTTP; Thu, 23 Dec 2010 17:49:43 -0800 (PST) In-Reply-To: <928638.38398.qm@web110710.mail.gq1.yahoo.com> References: <928638.38398.qm@web110710.mail.gq1.yahoo.com> Date: Thu, 23 Dec 2010 20:49:43 -0500 Message-ID: Subject: Re: Grammar and formatting errors for 9.02 pdf version From: Robert Haas To: Leslie S Satenstein Cc: pgsql-docs Content-Type: multipart/alternative; boundary=90e6ba6e826c4a0ca904981e330f X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.598 tagged_above=-5 required=5 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7 X-Spam-Level: X-Archive-Number: 201012/39 X-Sequence-Number: 6275 --90e6ba6e826c4a0ca904981e330f Content-Type: text/plain; charset=ISO-8859-1 On Wed, Dec 22, 2010 at 5:08 PM, Leslie S Satenstein wrote: > > --- On *Tue, 12/21/10, Robert Haas * wrote: > > Since Yahoo.com does not allow me to respond as an append, please excuse > the formatting that takes place in the left margin. > > I very much doubt this is true. > Here is an example of how I was thinking to proceed but using a word > document so that formatting would be respected. I would present the page in > word, and then identify the changes with red/green. To keep this email > short, I am showing only a very few changes. Green is for an insertion, > Red is for a deletion. Yellow is for clarification > > This is just impenetrable. I spent 10 minutes trying to figure out what the first example below referred to. > Ignored (formerly, this parameter specified where to send server debug > output). > > This is on page 590 in the version of the PDF I downloaded, which surely illustrates the folly of trying to refer to anything by page number. rather than, say, section title. Or, better yet, providing an actual patch. While inserting the word parameter here might marginally more correct, the original text isn't unclear, and I'm certainly not willing to spend a huge amount of time on changes like this. If you're willing to learn how to send a patch, I or someone else will review it and some of your changes might be accepted, but I don't think anyone's going to be willing to be willing to try to interpret anything in this format. > > Page 594 > Text below is truncated as it goes beyond the right margin > > > Make a connection to the database server in a nonblocking manner. > PGconn *PQconnectStartParams(const char **keywords, const char **values, > int expand_dbname); > > I found this - it does go beyond the right margin. I'm not sure what to do about this one. > > Page 595 > To begin a nonblocking connection callexecute > conn = > > What's wrong with call? > > > Further down > > IfAfter PQconnectStart succeeds ... > > > Leaving the opening If ..... in my mind says, what to do if it does not > succeed then what? By writing after PQConnectStart succeeds... takes away > liability. > > If it doesn't succeed then you mustn't do what the rest of the sentence says. The sentence is correct as written and would be wrong with this change. By succeeds what is meant here is "returns non-NULL", as discussed in the preceding paragraph. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --90e6ba6e826c4a0ca904981e330f Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Dec 22, 2010 at 5:08 PM, Leslie S Satenstein <= lsatenstein@yahoo.com> wrote:

--- On Tue, 12= /21/10, Robert Haas <robertmhaas@gmail.com> wrote:
Since Yahoo.com does not allow me to respond = as an append, please excuse the formatting that takes place in the left margin.
=

I very much doubt this is true.
=A0
=A0Here i= s an example of how I was thinking to proceed but using a word document so that formatting would be respected.=A0 I would=20 present the page in word, and then identify the changes with red/green.=A0 To keep this email short, I am showing only a very few changes. Green is for an ins= ertion, Red is for a deletion.=A0 Yellow is for clarification

This is = just impenetrable.=A0 I spent 10 minutes trying to figure out what the firs= t example below referred to.


Ignored (formerly, this parameter specified where to send server debug output).

This is on page 590 in= the version of the PDF I downloaded, which surely illustrates the folly of= trying to refer to anything by page number. rather than, say, section titl= e.=A0 Or, better yet, providing an actual patch.=A0 While inserting the wor= d parameter here might marginally more correct, the original text isn't= unclear, and I'm certainly not willing to spend a huge amount of time = on changes like this.=A0 If you're willing to learn how to send a patch= , I or someone else will review it and some of your changes might be accept= ed, but I don't think anyone's going to be willing to be willing to= try to interpret anything in this format.
=A0

I found this - it does go beyond the right margin.= =A0 I'm not sure what to do about this one.
=A0

Page 594
Text below is truncated as it goes beyond the right margin


Make a connection to the databas= e server in a nonblocking manner.
PGconn *PQconnectStartParams(const char **keywords, co= nst char **values, int expand_dbname);
=A0
Page 595
To begin a nonblocking connection callexecute
conn =3D

What's wro= ng with call?
=A0


Further down

IfAfter PQconnectStart succeeds ...

= Leaving the opening If ..... in my mind says, what to do if it does not suc= ceed then what?=A0 By writing after PQConnectStart succeeds... takes away l= iability.

I= f it doesn't succeed then you mustn't do what the rest of the sente= nce says.=A0 The sentence is correct as written and would be wrong with thi= s change.=A0 By succeeds what is meant here is "returns non-NULL"= , as discussed in the preceding paragraph.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The E= nterprise PostgreSQL Company
--90e6ba6e826c4a0ca904981e330f--