public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: psql's ON_ERROR_STOP is misdocumented
Date: Tue, 14 Jun 2011 11:07:58 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Mon, Jun 13, 2011 at 11:01 AM, Robert Haas <[email protected]> wrote:
> On Thu, May 5, 2011 at 11:20 AM, Tom Lane <[email protected]> wrote:
>> The documentation for ON_ERROR_STOP states, or at least implies by
>> omission, that it only affects the behavior in non-interactive scripts:
>>
>>        By default, if non-interactive scripts encounter an error, such
>>        as a malformed SQL command or internal meta-command, processing
>>        continues. This has been the traditional behavior of psql but it
>>        is sometimes not desirable. If this variable is set, script
>>        processing will immediately terminate. If the script was called
>>        from another script it will terminate in the same fashion. If
>>        the outermost script was not called from an interactive psql
>>        session but rather using the -f option, psql will return error
>>        code 3, to distinguish this case from fatal error conditions
>>        (error code 1).
>>
>> However, it is easily proven that it *does* affect interactive commands;
>> just try two commands on one line:
>>
>> regression=# select 1/0; select 2;
>> ERROR:  division by zero
>>  ?column?
>> ----------
>>        2
>> (1 row)
>>
>> regression=# \set ON_ERROR_STOP 1
>> regression=# select 1/0; select 2;
>> ERROR:  division by zero
>> regression=#
>>
>> Can we get the docs changed to reflect reality?
>
> Here's an attempt at some suitable word-smithing.

Hearing no objections, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: psql's ON_ERROR_STOP is misdocumented
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox