Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8034=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XGbSW-0001wd-68
 for pgsql-docs@arkaria.postgresql.org; Sun, 10 Aug 2014 22:19:24 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-docs-owner+M8034=pgsql+2Ddocs=arkaria.postgresql.org@postgresql.org>)
 id 1XGbSV-0007B7-2S
 for pgsql-docs@arkaria.postgresql.org; Sun, 10 Aug 2014 22:19:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <maumau307@gmail.com>) id 1XGbST-0007Aw-2p
 for pgsql-docs@postgresql.org; Sun, 10 Aug 2014 22:19:21 +0000
Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233])
 by magus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.80) (envelope-from <maumau307@gmail.com>) id 1XGbSJ-0004JT-DC
 for pgsql-docs@postgresql.org; Sun, 10 Aug 2014 22:19:19 +0000
Received: by mail-pa0-f51.google.com with SMTP id ey11so10036904pad.38
 for <pgsql-docs@postgresql.org>; Sun, 10 Aug 2014 15:19:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=message-id:from:to:references:in-reply-to:subject:date:mime-version
 :content-type:content-transfer-encoding;
 bh=ErZKy+wkT8pmtr0JWrzUSqnrsBKabXwK3CkDEF0twa8=;
 b=QdymWVikPpkHTXyjFE0W7QAywQe/jnIx0Dy/DXpQBeTiamzatxPOnYGgxi/0f6AXYp
 /4AguUjRZ4esWsIP4RxNuzb3idhFAvU0dTu2ckBG4ksWL15oEh+a6Bj3BDuIsfidrhV4
 cMOxF1HPVdIYNxeBeY6UxINviGAa3LrMBJnb65ypeOzaK4eY6XRMBSJgKms6DCBtlc3K
 Ewx6P3v8Tsvpg/tmQLsNS/t5lwGZYVUsSKRc7blAL7PXrqPShyavagq2955PUKmjdh4G
 k0JImdbmxtbVQPxn4o20QDO3uPbkBIU3t5tP2+igM4Uv0kHnGJ2Qzpkao8JYaVIWql21
 p0Rw==
X-Received: by 10.70.35.166 with SMTP id i6mr33832273pdj.60.1407709147482;
 Sun, 10 Aug 2014 15:19:07 -0700 (PDT)
Received: from maumau (p23196-ipngn100307sizuokaden.shizuoka.ocn.ne.jp.
 [153.131.144.196])
 by mx.google.com with ESMTPSA id br1sm9379286pbc.6.2014.08.10.15.19.05
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
 Sun, 10 Aug 2014 15:19:06 -0700 (PDT)
Message-ID: <C7973B036D05487FB1A83AA5231E2039@maumau>
From: "MauMau" <maumau307@gmail.com>
To: "Vik Fearing" <vik.fearing@dalibo.com>,
 "PG Docs" <pgsql-docs@postgresql.org>
References: <53D8E0D9.9090300@dalibo.com>
 <510823BF13464AAE872F0C81C194E86C@maumau> <53E7C12F.3020901@dalibo.com>
In-Reply-To: <53E7C12F.3020901@dalibo.com>
Subject: Re: pageinspect forks
Date: Mon, 11 Aug 2014 07:22:09 +0900
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="utf-8"; reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Windows Mail 6.0.6002.18197
X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6002.18463
X-Pg-Spam-Score: -1.3 (-)
List-Archive: <http://archives.postgresql.org/pgsql-docs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-docs.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@postgresql.org>
List-Post: <mailto:pgsql-docs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-docs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
X-Mailing-List: pgsql-docs
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

From: "Vik Fearing" <vik.fearing@dalibo.com>
> On 08/10/2014 03:24 PM, MauMau wrote:
>> Could you also improve the doc by changing "table" to "relation" in the
>> description of get_raw_page()?  Having a quick look at the code, it
>> seems that the function can also handle indexes.
>>
>>        table and returns a copy as a <type>bytea</> value.  This allows a
>
>
> Good catch.  I wasn't sure whether using "relation" or "table or index"
> was better, but after a quick test it seems it works for sequences, too,
> so I've gone with "relation".
>
> It doesn't work with views, of course, but it does work with
> materialized views.
>
> Modified patch attached.

Thanks, I marked this as ready for committer.

I think I'll leave it up to you to decide whether you improve the HINT 
message Fujii-san pointed out, which is in src/backend/catalog/catalog.c.

Regards
MauMau





-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs