MIME-Version: 1.0
In-Reply-To: 
 <CA+HiwqHvoM4RpYpGQdLXSQziGZhR1KmR9skTr03MMRJFdqXuJg@mail.gmail.com>
References: 
 <CA+HiwqE35_+z0_gFw9mp=_0MLgPfb=+QY910LG7C-sBNTvqdgg@mail.gmail.com>
 <3036.1396497272@sss.pgh.pa.us>
 <CA+HiwqGzakcVbKbfxv6ThNcAmp_ZgakagKTM1u80PAF2mnNVcQ@mail.gmail.com>
 <3704.1396498776@sss.pgh.pa.us>
 <CA+HiwqHvoM4RpYpGQdLXSQziGZhR1KmR9skTr03MMRJFdqXuJg@mail.gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
Date: Thu, 3 Apr 2014 14:02:41 +0900
Message-ID: 
 <CA+HiwqHyY6fKuGjHTtF_HesnbJs=muu9chmNqzoa3MLaRv_KbQ@mail.gmail.com>
Subject: Fwd: [GENERAL] Table Rewrite During ALTER TABLE ... ADD COLUMN ...
 DEFAULT NULL
To: pgsql-docs@postgresql.org
Content-Type: multipart/mixed; boundary=089e0118226cccf1f804f61c5064
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

--089e0118226cccf1f804f61c5064
Content-Type: text/plain; charset=UTF-8

---------- Forwarded message ----------
From: Amit Langote <amitlangote09@gmail.com>
Date: Thu, Apr 3, 2014 at 1:53 PM
Subject: Re: [GENERAL] Table Rewrite During ALTER TABLE ... ADD COLUMN
... DEFAULT NULL
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres General <pgsql-general@postgresql.org>


On Thu, Apr 3, 2014 at 1:19 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
>> On Thu, Apr 3, 2014 at 12:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Some experimentation suggests that we are smart about "DEFAULT NULL"
>>> unless the column type requires a length-coercion cast, in which
>>> case the default expression involves a function call, and that doesn't
>>> get elided.
>
>> Is there a warning about such behavior in the manual?
>> Is it useful to include it somewhere (not sure where though)?
>
> We could just rephrase the ALTER TABLE docs to say that the table
> rewrite is avoided if you omit the DEFAULT clause, rather than
> saying that a null default works.
>

How does the attached sound?
Wonder if a rewrite-warning is necessary?

--
Amit

--089e0118226cccf1f804f61c5064
Content-Type: application/octet-stream; name="alter-table-doc-fix.patch"
Content-Disposition: attachment; filename="alter-table-doc-fix.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_htjkd8dq0

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfdGFibGUuc2dt
bCBiL2RvYy9zcmMvc2dtbC9yZWYvYWx0ZXJfdGFibGUuc2dtbAppbmRleCA0
ODQ3ZDY2Li5kZTYzZTllIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVm
L2FsdGVyX3RhYmxlLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9hbHRl
cl90YWJsZS5zZ21sCkBAIC04NTMsNyArODUzLDkgQEAgQUxURVIgVEFCTEUg
WyBJRiBFWElTVFMgXSA8cmVwbGFjZWFibGUgY2xhc3M9IlBBUkFNRVRFUiI+
bmFtZTwvcmVwbGFjZWFibGU+CiAgICA8cGFyYT4KICAgICBXaGVuIGEgY29s
dW1uIGlzIGFkZGVkIHdpdGggPGxpdGVyYWw+QUREIENPTFVNTjwvbGl0ZXJh
bD4sIGFsbCBleGlzdGluZwogICAgIHJvd3MgaW4gdGhlIHRhYmxlIGFyZSBp
bml0aWFsaXplZCB3aXRoIHRoZSBjb2x1bW4ncyBkZWZhdWx0IHZhbHVlCi0g
ICAgKE5VTEwgaWYgbm8gPGxpdGVyYWw+REVGQVVMVDwvPiBjbGF1c2UgaXMg
c3BlY2lmaWVkKS4KKyAgICAoTlVMTCBpZiBubyA8bGl0ZXJhbD5ERUZBVUxU
PC8+IGNsYXVzZSBpcyBzcGVjaWZpZWQpLiBVc2VycyBhcmUgYWR2aXNlZAor
ICAgIG5vdCB0byB1c2UgZXhwbGljaXQgPGxpdGVyYWw+REVGQVVMVDwvPiBj
bGF1c2UgdW5sZXNzIHRoZXJlIGlzIGEgbm9uLW51bGwKKyAgICBkZWZhdWx0
IHZhbHVlIHRvIHNwZWNpZnkuCiAgICA8L3BhcmE+CiAKICAgIDxwYXJhPgo=

--089e0118226cccf1f804f61c5064
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--089e0118226cccf1f804f61c5064--