Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoWiS-0006HE-Sk for pgsql-docs@arkaria.postgresql.org; Tue, 20 Oct 2015 13:12:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZoWiS-0003Fw-4o for pgsql-docs@arkaria.postgresql.org; Tue, 20 Oct 2015 13:12:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZoWiP-0003Ed-LZ; Tue, 20 Oct 2015 13:12:33 +0000 Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZoWiK-0007Pn-3L; Tue, 20 Oct 2015 13:12:31 +0000 Received: by lbbec13 with SMTP id ec13so12475973lbb.0; Tue, 20 Oct 2015 06:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kjydDd/mk4VOho7cMYIBJApMKhpRaRNn+fRPPf4/Jbs=; b=VIoo98ZV87pqSaltuz/fjPiX1aM9QizT9jsY7ELGJuo7sWx5j+n5EVC5HGaM5UcA0T /vTihC741sLdX7tWZ8P6hABs6vMD06jTaP6CfOZJfnfa+YhXEQWUtbUDmiOq9Zqobsf6 6IUN8DVWyNBcuqY5fDCRUGy2k5b9yLEFncqNqEV0gZFIQHzqSIQRxd4P2vEQax/HnHWk /vWJFu9ikjEdbu144puBMsKJe7Lhhf+bbGzW1cmuzcnZ2zMsyP66Msby2dUCl5sam90E ZUALfXd392++Ds/48V2g9JY/CXRb1icVN/BsFCG7oGvN5YFwMITLQZU7vJSIYb4ygRb+ ra2g== MIME-Version: 1.0 X-Received: by 10.112.161.42 with SMTP id xp10mr1784228lbb.49.1445346744781; Tue, 20 Oct 2015 06:12:24 -0700 (PDT) Received: by 10.112.44.101 with HTTP; Tue, 20 Oct 2015 06:12:24 -0700 (PDT) In-Reply-To: <5622BF9D.2010409@2ndquadrant.com> References: <20150930224806.GR2573@alvherre.pgsql> <20151001181240.GT2573@alvherre.pgsql> <20151002145839.GZ2573@alvherre.pgsql> <20151002185941.GE2573@alvherre.pgsql> <5622BF9D.2010409@2ndquadrant.com> Date: Tue, 20 Oct 2015 09:12:24 -0400 Message-ID: Subject: Re: [HACKERS] max_worker_processes on the standby From: Robert Haas To: Petr Jelinek Cc: Alvaro Herrera , Fujii Masao , oonishitk@nttdata.co.jp, pgsql-docs , PostgreSQL-development Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org On Sat, Oct 17, 2015 at 5:37 PM, Petr Jelinek wrote: > I agree with that sentiment. > > Attached patch adds variable to the shmem which is used for module > activation tracking - set to true in ActiveCommitTs() and false in > DeactivateCommitTs(). All the checks inside the commit_ts code were changed > to use this new variable. I also removed the static variable Alvaro added in > previous commit because it's not needed anymore. That sounds good to me. On a quick read-through it looks OK too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs