MIME-Version: 1.0
In-Reply-To: 
 <CAJKUy5jqgN+qyZj1tG68s8mygNx6_8U1pxPOL6Y=n2FFK5TDnw@mail.gmail.com>
References: <201112140139.pBE1dEo03975@momjian.us>
	<27416.1323836857@sss.pgh.pa.us>
	<CAJKUy5jqgN+qyZj1tG68s8mygNx6_8U1pxPOL6Y=n2FFK5TDnw@mail.gmail.com>
Date: Wed, 2 May 2012 13:09:39 -0400
Message-ID: 
 <CA+Tgmoa-PQgqvdQDGriTgyjLMLNoXBzUHkEDGgiX5Y+0f92ztQ@mail.gmail.com>
Subject: Re: CREATE USER
From: Robert Haas <robertmhaas@gmail.com>
To: Jaime Casanova <jaime@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>,
	Scott Marlowe <scott.marlowe@gmail.com>,
	pgsql-docs <pgsql-docs@postgresql.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 24, 2012 at 2:55 AM, Jaime Casanova <jaime@2ndquadrant.com> wro=
te:
> On Tue, Dec 13, 2011 at 11:27 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Bruce Momjian <bruce@momjian.us> writes:
>>> Well, I know we support the new pg_dump dumping back to 7.1, but I don'=
t
>>> know what our policy is for accepting old dumps.
>>
>> We're still going to very large lengths to load pre-7.3 dumps; see
>> for instance ConvertTriggerToFK() in trigger.c. =A0I'm not aware of any
>> policy that would suggest blowing off pre-8.1 dumps should be
>> acceptable. =A0Yeah, it's true that the *recommended* procedure is to
>> use the newer pg_dump, but people aren't always in a position to do
>> that.
>>
>> I think it might be sane to emit a WARNING suggesting that CREATEUSER
>> might not mean what you think, but failing is probably not good.
>>
>
> are we going to do this in this release?
> i never was able to think in a good phrasing for this, though

I actually think we should just leave this alone.  There is a
limitless number of things that someone could potentially be confused
by if they fail to read the documentation, and we can't warn about all
of them.

Now, one thing we could do is add a deprecation warning, stating that
CREATEUSER may be removed in a future release, assuming we want to
eventually remove it.  But I don't think warning people that
CREATEUSER means SUPERUSER and not CREATEROLE is very helpful.

--=20
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company