public inbox for [email protected]  

help / color / mirror / Atom feed

From: Paul A Jungwirth <[email protected]>
To: Daisuke Higuchi <[email protected]>
Cc: [email protected]
Subject: Re: doc: Fix the header file where CompareType is defined in gist.sgml
Date: Mon, 15 Dec 2025 15:19:34 -0800
Message-ID: <CA+renyV6soCRaZGOgyBXoqGQn2E2gT-MuqFoc0jOhw74iMJ6AA@mail.gmail.com> (raw)
In-Reply-To: <CAEVT6c8guXe5P=L_Un5NUUzCgEgbHnNcP+Y3TV2WbQh-xjiwqA@mail.gmail.com>
References: <CAEVT6c8guXe5P=L_Un5NUUzCgEgbHnNcP+Y3TV2WbQh-xjiwqA@mail.gmail.com>

On Sat, Dec 13, 2025 at 12:25 AM Daisuke Higuchi
<[email protected]> wrote:
>
> I found that the header file where CompareType was actually defined did not match the header file described in gist.sgml.
> CompareType is currently defined at "src/include/access/cmptype.h" instead of "src/include/nodes/primnodes.h".
> This change was made in the commit below, but it seems that documentation update was missed.
>
> https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

You're right, that's where we define it. Your email landed in Gmail's
spam folder for me, so hopefully this +1 will help it not be missed by
a committer.

Yours,

-- 
Paul              ~{:-)
[email protected]

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: doc: Fix the header file where CompareType is defined in gist.sgml
  In-Reply-To: <CA+renyV6soCRaZGOgyBXoqGQn2E2gT-MuqFoc0jOhw74iMJ6AA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox