MIME-Version: 1.0
References: <177609278737.403059.14174275013090471947@wrigleys.postgresql.org>
 <CAKFQuwZ86BE49-gzFunuu=u1ieT+T6q900=1Cx=vuO9Aqv9kcg@mail.gmail.com>
In-Reply-To: 
 <CAKFQuwZ86BE49-gzFunuu=u1ieT+T6q900=1Cx=vuO9Aqv9kcg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Thu, 16 Apr 2026 08:34:34 +0530
Message-ID: 
 <CAA4eK1LR_MjZuV31r-MOqno9-Kr0mA9zas2cxZtE=+X3RUYXbw@mail.gmail.com>
Subject: Re: Logical Replication upgrade
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: mimidatabase@gmail.com, pgsql-docs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1LR_MjZuV31r-MOqno9-Kr0mA9zas2cxZtE%3D%2BX3RUYXbw%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 15, 2026 at 9:25=E2=80=AFPM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Wed, Apr 15, 2026 at 7:52=E2=80=AFAM PG Doc comments form <noreply@pos=
tgresql.org> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/18/logical-replication-upgrade.htm=
l
>> Description:
>>
>> Hello there,
>>
>> I don't know if it's me but I find this sentence quite confusing in its
>> current wording:
>> All slots on the old cluster must be usable, i.e., there are no slots wh=
ose
>> pg_replication_slots.conflicting is not true.
>>
>> The prerequisite is that no replication slot has conflicting=3Dtrue righ=
t?
>> So this sentence (the i.e. part) suggests the opposite, as per my
>> understanding.
>>
>> Here is the link (29.13.1):
>> https://www.postgresql.org/docs/current/logical-replication-upgrade.html=
#STEPS-TWO-NODE-CIRCULAR-LOGICAL-REPLICATION-CLUSTER:~:text=3Dthere%20are%2=
0no%20slots%20whose%20pg_replication_slots.conflicting%20is%20not%20true
>>
>
> You are correct.  Usage of a double-negative should be avoided as a matte=
r of style, but in this case it actually resolves to an untrue statement.
>
> https://github.com/postgres/postgres/commit/7fdeaf5774d05245e82632e763665=
ff62db5598e
>
> I've copied the committer for this.  Removing the "not" is simple enough;=
 though writing in the negative sense,
>

How about: "All slots on the old cluster must be usable, i.e., there
are no slots whose pg_replication_slots.conflicting is false."?

--=20
With Regards,
Amit Kapila.