MIME-Version: 1.0
References: <82eb512b-8ed2-46be-b311-54ffd26978c4@ewie.name>
 <a5034028-3f97-4157-8fd2-6eb552ffaab8@app.fastmail.com>
 <0a9d7393-1cf2-4d38-a648-631c1f93e345@ewie.name>
In-Reply-To: <0a9d7393-1cf2-4d38-a648-631c1f93e345@ewie.name>
From: David Rowley <dgrowleyml@gmail.com>
Date: Fri, 24 Oct 2025 11:50:19 +1300
Message-ID: 
 <CAApHDvoLfa2UjGfoGfVL4b=g5VbFgscrLONuC3kKE9=VZeeN=Q@mail.gmail.com>
Subject: Re: Use uppercase keywords in foreign key tutorial
To: Erik Wienhold <ewie@ewie.name>
Cc: Euler Taveira <euler@eulerto.com>, pgsql-docs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAApHDvoLfa2UjGfoGfVL4b%3Dg5VbFgscrLONuC3kKE9%3DVZeeN%3DQ%40mail.gmail.com>
Precedence: bulk

On Fri, 24 Oct 2025 at 09:39, Erik Wienhold <ewie@ewie.name> wrote:
> This of course produces a lot of noise, but I managed to find and fix a
> couple more places with the attached v2 (including the ones you've
> listed) that I've missed previously.  I've searched for "primary key"
> across the docs previously but did not spot the matches between the
> false-positive ones from the running text.

I've not reviewed in detail, but on a first-pass read, I think this is
worth doing. I personally find queries with upper-case keywords and
lowercase identifiers much easier on the eyes.

I'm not so sure about the "Should be pushed to all stable branches"
part as it seems more of a general improvement than fixing a mistake.
I imagine there will be varying opinions on that, however.

David