public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: Tom Lane <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: Erik Wienhold <[email protected]>
Cc: [email protected]
Subject: Re: Use uppercase keywords in foreign key tutorial
Date: Thu, 30 Oct 2025 10:24:30 +1300
Message-ID: <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAApHDvoLfa2UjGfoGfVL4b=g5VbFgscrLONuC3kKE9=VZeeN=Q@mail.gmail.com>
	<[email protected]>
	<aQE29YG5pY4Cl8ym@nathan>
	<[email protected]>
	<[email protected]>

On Thu, 30 Oct 2025 at 09:48, Tom Lane <[email protected]> wrote:
>
> Bruce Momjian <[email protected]> writes:
> > On Tue, Oct 28, 2025 at 04:34:45PM -0500, Nathan Bossart wrote:
> >> I noticed the patch also changes some column types to lowercase:
> >> ...
> >> -    category_N TEXT
> >> +    category_N text
> >>
> >> FWIW I tend to use uppercase for those, too, but I'm not sure there is a
> >> preferred style for the docs.
>
> > Agreed, uppercase is better for type names.
>
> "text" is not a keyword according to either us or the SQL standard.
> I agree that there's some reason to capitalize things that are
> grammar keywords, such as INTEGER or VARCHAR, but it's a big stretch
> to go from that to capitalizing everything that is a type name.
> Would you capitalize user-defined type names?

Going by: git grep -i "\btext\b," we're fairly consistently using
lower case, so FWIW, when I looked, I thought Eric's change made
sense.

How about if Eric just drops the portion of the patch that alters the
casing of the types and leaves all the keyword uppercasing stuff in.
Any objections to that part?

David

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use uppercase keywords in foreign key tutorial
  In-Reply-To: <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox