Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zw11s-0000Xx-21 for pgsql-docs@arkaria.postgresql.org; Tue, 10 Nov 2015 04:59:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zw11r-0007ou-JL for pgsql-docs@arkaria.postgresql.org; Tue, 10 Nov 2015 04:59:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zw11q-0007oK-GW for pgsql-docs@postgresql.org; Tue, 10 Nov 2015 04:59:34 +0000 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1Zw11l-0006bi-QN for pgsql-docs@postgresql.org; Tue, 10 Nov 2015 04:59:32 +0000 Received: by qgea14 with SMTP id a14so81163831qge.0 for ; Mon, 09 Nov 2015 20:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=rmkwXZu+KwvYpR8KoXm5oOZz2ZvvJbDK8h6YDBQOQwg=; b=KXbLYOihXaKT6X9asd9XTC+F5/nJCd95im37+Ln1RKF+SXKQVt3CR83/JdM52162EL TCF0G5rLaoOyB4YXh02Pc57pEK8lLfWuWG9pncy3WWId+VluVdzRGBsmnc/nR33yyFLA z0qGLy972gqxdhPCGqupDr5H9mtMKrgWp0+AMlHuzWSoz6yKmovUhvtbSIapvLHIprQu kXQj55DSz6aFqYym7v34ieVLYt7qTaSUASNbTL8643iHkiv+27lLSMjubbg3SpQWOFHt z5+C0YsxgeGZlnwFrkocR81grPizXFT9htD1ix0pKz6+4DqTkA8TxfnewjPvsiJUEVVS wE6Q== MIME-Version: 1.0 X-Received: by 10.140.176.7 with SMTP id w7mr2008658qhw.18.1447131567887; Mon, 09 Nov 2015 20:59:27 -0800 (PST) Received: by 10.140.39.199 with HTTP; Mon, 9 Nov 2015 20:59:27 -0800 (PST) In-Reply-To: <5F0285CB-3926-4DF7-9DE0-CEEBC1DE3AEB@yesql.se> References: <5F0285CB-3926-4DF7-9DE0-CEEBC1DE3AEB@yesql.se> Date: Tue, 10 Nov 2015 13:59:27 +0900 Message-ID: Subject: Re: Documentation on Streaming Replication interface for Logical Decoding From: Michael Paquier To: Daniel Gustafsson Cc: pgsql-docs@postgresql.org Content-Type: multipart/mixed; boundary=001a113978ae0c4dc40524289396 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org --001a113978ae0c4dc40524289396 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2015 at 7:40 AM, Daniel Gustafsson wrote: > In section 46.3 (Streaming Replication Protocol Interface) the create com= mand > for logical slots, CREATE_REPLICATION_SLOT, is defined as taking =E2=80= =9Coptions=E2=80=9D > after the LOGICAL keyword when it in fact requires the plugin name. The = start > command is correctly listing the options but isn=E2=80=99t listing the re= quired start > position. > > The attached patch synchronizes these command signatures with the more de= tailed > descriptions in section 50.3* (Streaming Replication Protocol). > > cheers ./daniel > > (*) Section number from the 9.5beta1 manual Why do we need to maintain the semantics of those commands in two places by the way? There is already a link to the replication protocol page in logicaldecoding.sgml, hence it seems to me that we had better just cite the command names, per se the attached. --=20 Michael --001a113978ae0c4dc40524289396 Content-Type: text/x-diff; charset=US-ASCII; name="20151110_logdec_docs.patch" Content-Disposition: attachment; filename="20151110_logdec_docs.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igswrnpa0 ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9sb2dpY2FsZGVjb2Rpbmcuc2dt bCBiL2RvYy9zcmMvc2dtbC9sb2dpY2FsZGVjb2Rpbmcuc2dtbAppbmRleCAw Mjc5NGNjLi4xMWZjNzE1IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvbG9n aWNhbGRlY29kaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2xvZ2ljYWxk ZWNvZGluZy5zZ21sCkBAIC0yNzcsMjMgKzI3NywxMSBAQCAkIHBnX3JlY3Zs b2dpY2FsIC1kIHBvc3RncmVzIC0tc2xvdCB0ZXN0IC0tZHJvcC1zbG90CiAg ICA8dGl0bGU+U3RyZWFtaW5nIFJlcGxpY2F0aW9uIFByb3RvY29sIEludGVy ZmFjZTwvdGl0bGU+CiAKICAgIDxwYXJhPgotICAgIFRoZSBjb21tYW5kcwot ICAgIDxpdGVtaXplZGxpc3Q+Ci0gICAgIDxsaXN0aXRlbT4KLSAgICAgIDxw YXJhPjxsaXRlcmFsPkNSRUFURV9SRVBMSUNBVElPTl9TTE9UIDxyZXBsYWNl YWJsZT5zbG90X25hbWU8L3JlcGxhY2VhYmxlPiBMT0dJQ0FMIDxyZXBsYWNl YWJsZT5vcHRpb25zPC9yZXBsYWNlYWJsZT48L2xpdGVyYWw+PC9wYXJhPgot ICAgICA8L2xpc3RpdGVtPgotCi0gICAgIDxsaXN0aXRlbT4KLSAgICAgIDxw YXJhPjxsaXRlcmFsPkRST1BfUkVQTElDQVRJT05fU0xPVCA8cmVwbGFjZWFi bGU+c2xvdF9uYW1lPC9yZXBsYWNlYWJsZT48L2xpdGVyYWw+PC9wYXJhPgot ICAgICA8L2xpc3RpdGVtPgotCi0gICAgIDxsaXN0aXRlbT4KLSAgICAgIDxw YXJhPjxsaXRlcmFsPlNUQVJUX1JFUExJQ0FUSU9OIFNMT1QgPHJlcGxhY2Vh YmxlPnNsb3RfbmFtZTwvcmVwbGFjZWFibGU+IExPR0lDQUwgPHJlcGxhY2Vh YmxlPm9wdGlvbnM8L3JlcGxhY2VhYmxlPjwvbGl0ZXJhbD48L3BhcmE+Ci0g ICAgIDwvbGlzdGl0ZW0+Ci0gICAgPC9pdGVtaXplZGxpc3Q+Ci0gICAgYXJl IHVzZWQgdG8gY3JlYXRlLCBkcm9wLCBhbmQgc3RyZWFtIGNoYW5nZXMgZnJv bSBhIHJlcGxpY2F0aW9uCi0gICAgc2xvdCwgcmVzcGVjdGl2ZWx5LiBUaGVz ZSBjb21tYW5kcyBhcmUgb25seSBhdmFpbGFibGUgb3ZlciBhIHJlcGxpY2F0 aW9uCi0gICAgY29ubmVjdGlvbjsgdGhleSBjYW5ub3QgYmUgdXNlZCB2aWEg U1FMLgorICAgIFRoZSBjb21tYW5kcyA8bGl0ZXJhbD5DUkVBVEVfUkVQTElD QVRJT05fU0xPVDwvbGl0ZXJhbD4sCisgICAgPGxpdGVyYWw+RFJPUF9SRVBM SUNBVElPTl9TTE9UPC9saXRlcmFsPiBhbmQgCisgICAgPGxpdGVyYWw+U1RB UlRfUkVQTElDQVRJT04gU0xPVDwvbGl0ZXJhbD4gYXJlIHVzZWQgdG8gY3Jl YXRlLCBkcm9wLCBhbmQKKyAgICBzdHJlYW0gY2hhbmdlcyBmcm9tIGEgcmVw bGljYXRpb24gc2xvdCwgcmVzcGVjdGl2ZWx5LiBUaGVzZSBjb21tYW5kcyBh cmUKKyAgICBvbmx5IGF2YWlsYWJsZSBvdmVyIGEgcmVwbGljYXRpb24gY29u bmVjdGlvbjsgdGhleSBjYW5ub3QgYmUgdXNlZCB2aWEgU1FMLgogICAgIFNl ZSA8eHJlZiBsaW5rZW5kPSJwcm90b2NvbC1yZXBsaWNhdGlvbiI+IGZvciBk ZXRhaWxzIG9uIHRoZXNlIGNvbW1hbmRzLgogICAgPC9wYXJhPgogCg== --001a113978ae0c4dc40524289396 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs --001a113978ae0c4dc40524289396--