Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHW8q-0007IM-AP for pgsql-docs@arkaria.postgresql.org; Wed, 22 Nov 2017 14:36:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHW8p-00043y-TX for pgsql-docs@arkaria.postgresql.org; Wed, 22 Nov 2017 14:36:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eHW8p-00042x-Jw for pgsql-docs@lists.postgresql.org; Wed, 22 Nov 2017 14:36:43 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eHW8i-0008Uk-M7 for pgsql-docs@postgresql.org; Wed, 22 Nov 2017 14:36:42 +0000 Received: by mail-wm0-x243.google.com with SMTP id 9so10793339wme.4 for ; Wed, 22 Nov 2017 06:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qRSodcAm5tYVlgf4hd4i1Z816Zc/uuS5P3j5QJkV4K0=; b=DgLzUpLMhC5AVQgzbdmZOPkKh5wcj7/A7tzrXsPt9SJIcAK8gD2AK/ilpgczVms7aE sLFMI3BJg1hqhK7kKigeqqQeov9iyWNaT/5wIYWv79aimcdi93QO2e5GV+sKbwNeSYH3 bY1kVp6av1tOab6CCmN8lxT4Qm2Y0VEgif2WmPBKn4OZDqA4MKQI0qKXgDyWrBqV42cB kzTTH2DvJAiz+3v4EtszI3Xc7AG/XtWsoLxOWVJWlLeWLp2Pat1s5WZy+tvA7iarFF4C tQqZFZuumd509PKc6Lsbcip6rwn/OCuXvzrlFAtbnI4vrtPMf77xGnrhW5B/kF1zqVN/ N9Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qRSodcAm5tYVlgf4hd4i1Z816Zc/uuS5P3j5QJkV4K0=; b=q5KYhqIWh9oEF5B4iJFwU/c1zVp9aKyCpxVbPvamAgoIO4YRFe4PGIfM9HSUQsigfy ZAkMVpjR1oYW2wxi8WC+GOv8BqV4hfPX+CY60G+sh4ZPFOeCOB9eSrbHFm0VvtDbkH37 FKAi41nDnaK/OKE3+OHQ9u3iWgycH6Rk6mnlkiiP/wnQDWlJzQ4E1n/5URs44gNATfjQ 5yDcQgkVjZoZw9vaZIwLVh7gDfcPGLedu0mra+wg+NDWubsGESCiKH6efdLGfjzk4kLF Lyc3/Jb5Y2pGQzIWsGlhGLCq8DxJpHLQPJiROaKX82pa0mb3dE82SZjWGZMdVLSlPEd1 vk2A== X-Gm-Message-State: AJaThX4xHD7irurDOG9XgKl5LdZ5IKaTDayUdV5WJ0GWo14h96o7bLrv mWm9T6z3S0ysDotRHNenHtsBgL3dohkCcfJLLDk= X-Google-Smtp-Source: AGs4zMY1lmQUpFfiVcWtU8ihRAbJdcQC7CIFznCTM/yYQWpBGQNqdiN+le0HdoWdxO2pdOepvOeOL/o3EWTeoocAVrU= X-Received: by 10.28.169.198 with SMTP id s189mr4087022wme.65.1511361395066; Wed, 22 Nov 2017 06:36:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.157.137 with HTTP; Wed, 22 Nov 2017 06:36:34 -0800 (PST) In-Reply-To: <20171122132714.1463.27247@wrigleys.postgresql.org> References: <20171122132714.1463.27247@wrigleys.postgresql.org> From: Michael Paquier Date: Wed, 22 Nov 2017 23:36:34 +0900 Message-ID: Subject: Re: libpq options To: sahapasci@gmail.com Cc: pgsql-docs@postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Nov 22, 2017 at 10:27 PM, wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.6/static/libpq-connect.html > Description: > > The documentation refers the libpq connection option "replication" here in > "Streaming Replication Protocol" page; > > https://www.postgresql.org/docs/current/static/protocol-replication.html > > However the option "replication" is not clarified (or even listed) in libpq > options page. > > https://www.postgresql.org/docs/current/static/libpq-connect.html#LIBPQ-PARAMKEYWORDS > > I searched the source and find that pg_conn struct has this > > struct pg_conn > { > ... > char *replication; /* connect as the replication standby? */ > ... > } > > Adding something simple like above and referring back to one of replication > pages would be good I think. Yeah, it is mainly a developer option which is why I guess it is not documented. Like you, I think it should be added as part of the connection parameter, and mentioned it a couple of days back: https://www.postgresql.org/message-id/CAB7nPqQAtKfG3H%2BuK11JNivtJtZYE9yVCrPuejRMjp8tUDe0nQ%40mail.gmail.com -- Michael