Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZuzh-0005Cf-61 for pgsql-docs@arkaria.postgresql.org; Thu, 10 Sep 2015 06:06:01 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZZuzg-0002xH-3h for pgsql-docs@arkaria.postgresql.org; Thu, 10 Sep 2015 06:06:00 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZZuzf-0002xA-Gw for pgsql-docs@postgresql.org; Thu, 10 Sep 2015 06:05:59 +0000 Received: from mail-qk0-x22e.google.com ([2607:f8b0:400d:c09::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZZuzc-0001jn-82 for pgsql-docs@postgresql.org; Thu, 10 Sep 2015 06:05:57 +0000 Received: by qkfq186 with SMTP id q186so14369565qkf.1 for ; Wed, 09 Sep 2015 23:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wWOs3qPWM3zfcwJplpVx5xfJcYkBCMScPUkVD0sDj2k=; b=L/fhDxGgP1i/J/tYsNArihP0PqO9XN2SjHx5n5Cf2+XiyXWW/k6/JaHCdTDqg1D/52 CbWuHylPMOp/igUiQDv4SEp0xIm4U1khgKxqaT5Um4vsN8LbKvQBfmMQFkbGoebw6KcA Dw4cYP09R0I6BTTvTPDBjeWlsVYqhh78aHMlymLmc8C6d38uBx2HBgfcRtxySaQBHfv3 c+hroiiDDiMWw2322SObiJQRAXhyNDjEri8jroDgi4fa6T1Rl3pAWfJW2sFZoOvS8RzY 7Ml/ExSBhd39krli6E/ebS640tosQ8t4trV5IXWTWyeDvRKhPQ+Mjw18mW/qhNU41xBX wG/g== MIME-Version: 1.0 X-Received: by 10.55.197.213 with SMTP id k82mr50472817qkl.49.1441865155297; Wed, 09 Sep 2015 23:05:55 -0700 (PDT) Received: by 10.140.23.74 with HTTP; Wed, 9 Sep 2015 23:05:55 -0700 (PDT) In-Reply-To: References: Date: Thu, 10 Sep 2015 15:05:55 +0900 Message-ID: Subject: Re: Possible mistake in Section 63.6 - 9.6devel Documentation From: Michael Paquier To: Fujii Masao Cc: Vignesh Raghunathan , pgsql-docs Content-Type: multipart/mixed; boundary=001a1149a48265807b051f5e646c X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org --001a1149a48265807b051f5e646c Content-Type: text/plain; charset=UTF-8 On Thu, Sep 10, 2015 at 12:42 AM, Fujii Masao wrote: > On Tue, Jul 21, 2015 at 9:59 AM, Michael Paquier > wrote: >> On Tue, Jul 21, 2015 at 6:54 AM, Vignesh Raghunathan >> wrote: >>> Hello, >>> >>> It has been mentioned in Section 63.6 that the first two fields in >>> PageHeaderData track the most recent WAL entry related to the page. However, >>> I am not sure how pd_checksum is related to WAL. Could it be possible that >>> the sentence has been carried over from previous versions of the >>> documentations without considering the change to the second field in >>> PageHeaderData? >> >> Yes, the documentation is mistaken. The two bytes of pd_tli have been >> switched to pd_checksum in 9.3, hence only the first field is relevant >> for WAL, aka pd_lsn. Looking at this portion of the docs I think that >> it should be updated as attached, mentioning pd_checksum as well. > > Also the type of pd_lsn in the Table 63-3 should be PageXLogRecPtr. Yep. See attached FWIW. -- Michael --001a1149a48265807b051f5e646c Content-Type: text/x-diff; charset=US-ASCII; name="20150910_pageheader_docfix_v2.patch" Content-Disposition: attachment; filename="20150910_pageheader_docfix_v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iedta6sy0 ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9zdG9yYWdlLnNnbWwgYi9kb2Mv c3JjL3NnbWwvc3RvcmFnZS5zZ21sCmluZGV4IGU1YjdiNGIuLjAxNTNiMDgg MTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9zdG9yYWdlLnNnbWwKKysrIGIv ZG9jL3NyYy9zZ21sL3N0b3JhZ2Uuc2dtbApAQCAtNzU4LDE4ICs3NTgsMTgg QEAgZGF0YS4gRW1wdHkgaW4gb3JkaW5hcnkgdGFibGVzLjwvZW50cnk+CiAg PHBhcmE+CiAKICAgVGhlIGZpcnN0IDI0IGJ5dGVzIG9mIGVhY2ggcGFnZSBj b25zaXN0cyBvZiBhIHBhZ2UgaGVhZGVyCi0gIChQYWdlSGVhZGVyRGF0YSku IEl0cyBmb3JtYXQgaXMgZGV0YWlsZWQgaW4gPHhyZWYKLSAgbGlua2VuZD0i cGFnZWhlYWRlcmRhdGEtdGFibGUiPi4gVGhlIGZpcnN0IHR3byBmaWVsZHMg dHJhY2sgdGhlIG1vc3QKLSAgcmVjZW50IFdBTCBlbnRyeSByZWxhdGVkIHRv IHRoaXMgcGFnZS4gTmV4dCBpcyBhIDItYnl0ZSBmaWVsZAotICBjb250YWlu aW5nIGZsYWcgYml0cy4gVGhpcyBpcyBmb2xsb3dlZCBieSB0aHJlZSAyLWJ5 dGUgaW50ZWdlciBmaWVsZHMKLSAgKDxzdHJ1Y3RmaWVsZD5wZF9sb3dlcjwv c3RydWN0ZmllbGQ+LCA8c3RydWN0ZmllbGQ+cGRfdXBwZXI8L3N0cnVjdGZp ZWxkPiwKLSAgYW5kIDxzdHJ1Y3RmaWVsZD5wZF9zcGVjaWFsPC9zdHJ1Y3Rm aWVsZD4pLiBUaGVzZSBjb250YWluIGJ5dGUgb2Zmc2V0cwotICBmcm9tIHRo ZSBwYWdlIHN0YXJ0IHRvIHRoZSBzdGFydAotICBvZiB1bmFsbG9jYXRlZCBz cGFjZSwgdG8gdGhlIGVuZCBvZiB1bmFsbG9jYXRlZCBzcGFjZSwgYW5kIHRv IHRoZSBzdGFydCBvZgotICB0aGUgc3BlY2lhbCBzcGFjZS4KLSAgVGhlIG5l eHQgMiBieXRlcyBvZiB0aGUgcGFnZSBoZWFkZXIsCi0gIDxzdHJ1Y3RmaWVs ZD5wZF9wYWdlc2l6ZV92ZXJzaW9uPC9zdHJ1Y3RmaWVsZD4sIHN0b3JlIGJv dGggdGhlIHBhZ2Ugc2l6ZQotICBhbmQgYSB2ZXJzaW9uIGluZGljYXRvci4g IEJlZ2lubmluZyB3aXRoCisgICg8c3RydWN0bmFtZT5QYWdlSGVhZGVyRGF0 YTwvPikuIEl0cyBmb3JtYXQgaXMgZGV0YWlsZWQgaW4gPHhyZWYKKyAgbGlu a2VuZD0icGFnZWhlYWRlcmRhdGEtdGFibGUiPi4gVGhlIGZpcnN0IGZpZWxk IHRyYWNrcyB0aGUgbW9zdAorICByZWNlbnQgV0FMIGVudHJ5IHJlbGF0ZWQg dG8gdGhpcyBwYWdlLiBUaGUgc2Vjb25kIGZpZWxkIGNvbnRhaW5zCisgIHRo ZSBwYWdlIGNoZWNrc3VtIGlmIDx4cmVmIGxpbmtlbmQ9ImFwcC1pbml0ZGIt ZGF0YS1jaGVja3N1bXMiPiBhcmUKKyAgZW5hYmxlZC4gIE5leHQgaXMgYSAy LWJ5dGUgZmllbGQgY29udGFpbmluZyBmbGFnIGJpdHMuIFRoaXMgaXMgZm9s bG93ZWQKKyAgYnkgdGhyZWUgMi1ieXRlIGludGVnZXIgZmllbGRzICg8c3Ry dWN0ZmllbGQ+cGRfbG93ZXI8L3N0cnVjdGZpZWxkPiwKKyAgPHN0cnVjdGZp ZWxkPnBkX3VwcGVyPC9zdHJ1Y3RmaWVsZD4sIGFuZAorICA8c3RydWN0Zmll bGQ+cGRfc3BlY2lhbDwvc3RydWN0ZmllbGQ+KS4gIFRoZXNlIGNvbnRhaW4g Ynl0ZSBvZmZzZXRzCisgIGZyb20gdGhlIHBhZ2Ugc3RhcnQgdG8gdGhlIHN0 YXJ0IG9mIHVuYWxsb2NhdGVkIHNwYWNlLCB0byB0aGUgZW5kIG9mCisgIHVu YWxsb2NhdGVkIHNwYWNlLCBhbmQgdG8gdGhlIHN0YXJ0IG9mIHRoZSBzcGVj aWFsIHNwYWNlLiAgVGhlIG5leHQgMgorICBieXRlcyBvZiB0aGUgcGFnZSBo ZWFkZXIsIDxzdHJ1Y3RmaWVsZD5wZF9wYWdlc2l6ZV92ZXJzaW9uPC9zdHJ1 Y3RmaWVsZD4sCisgIHN0b3JlIGJvdGggdGhlIHBhZ2Ugc2l6ZSBhbmQgYSB2 ZXJzaW9uIGluZGljYXRvci4gIEJlZ2lubmluZyB3aXRoCiAgIDxwcm9kdWN0 bmFtZT5Qb3N0Z3JlU1FMPC9wcm9kdWN0bmFtZT4gOC4zIHRoZSB2ZXJzaW9u IG51bWJlciBpcyA0OwogICA8cHJvZHVjdG5hbWU+UG9zdGdyZVNRTDwvcHJv ZHVjdG5hbWU+IDguMSBhbmQgOC4yIHVzZWQgdmVyc2lvbiBudW1iZXIgMzsK ICAgPHByb2R1Y3RuYW1lPlBvc3RncmVTUUw8L3Byb2R1Y3RuYW1lPiA4LjAg dXNlZCB2ZXJzaW9uIG51bWJlciAyOwpAQCAtNzk5LDcgKzc5OSw3IEBAIGRh dGEuIEVtcHR5IGluIG9yZGluYXJ5IHRhYmxlcy48L2VudHJ5PgogIDx0Ym9k eT4KICAgPHJvdz4KICAgIDxlbnRyeT5wZF9sc248L2VudHJ5PgotICAgPGVu dHJ5PlhMb2dSZWNQdHI8L2VudHJ5PgorICAgPGVudHJ5PlBhZ2VYTG9nUmVj UHRyPC9lbnRyeT4KICAgIDxlbnRyeT44IGJ5dGVzPC9lbnRyeT4KICAgIDxl bnRyeT5MU046IG5leHQgYnl0ZSBhZnRlciBsYXN0IGJ5dGUgb2YgeGxvZyBy ZWNvcmQgZm9yIGxhc3QgY2hhbmdlCiAgICB0byB0aGlzIHBhZ2U8L2VudHJ5 Pgo= --001a1149a48265807b051f5e646c Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs --001a1149a48265807b051f5e646c--