Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1Ua6-0003OT-9N for pgsql-docs@arkaria.postgresql.org; Thu, 29 Mar 2018 10:14:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1Ua4-0003ze-Bm for pgsql-docs@arkaria.postgresql.org; Thu, 29 Mar 2018 10:14:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1Ua4-0003zU-2M for pgsql-docs@lists.postgresql.org; Thu, 29 Mar 2018 10:14:52 +0000 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1UZz-00012H-Vr for pgsql-docs@postgresql.org; Thu, 29 Mar 2018 10:14:50 +0000 Received: by mail-lf0-x243.google.com with SMTP id j68-v6so7601793lfg.13 for ; Thu, 29 Mar 2018 03:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lZiecZ+35MINGx498+lkARbpRZ8Qt70b1bnH7CwV/A0=; b=dC20XtzhfO1uuZ0oDuwL01eqBo34OYrYXsRWbA2z9BTRPhkwvZbD+n0T7pYQb+p+K0 NXxJNHD0ZLs1MvTWthPo0Z8zxubBJLClYU67y2Bd1Pw9De8SIwQsIwg7EVqXFb8UOrzC C7X47fmCdZnIRpylhC6VNLdjJs0Abq44+RfSaSFuspzMaagmvEo/tR5QF1yEGmKTf4lt Yrk6s8xb2EyPyqvF4uhy2A6N5uSXYMa2FNkhQpd0PtO52BgMbK+rgqO+f8ZGKKuRaMQH 1gFiKDG70M+qjNOeImxy8pKSEv3XUPwJ6eB4qsVLWxJ0vrY4EfXDpbhF5OG5mCvTYxUf xVoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lZiecZ+35MINGx498+lkARbpRZ8Qt70b1bnH7CwV/A0=; b=MwD68jVOO2S7crhx3zPEvoROGTC9k6E7MqyF94KgjFNjmL7Rf8j6TLPdCvRZygbMsz M57A1cK72QyXudbgYy+4f8l3fjkYOB0X21mcgFy9EQsefXGu9sdNIOyKR3VRuwigJQU7 QbBzfbbxOL3TMaJn/+O71BZ28tbmT7V0nCR3UcaYd071BNIniYl0IqysXaqAdIzNwwkr qhuebm4LsiaFq0WCwwCKdGJPhxNmHhp7GXFoJNasvmjBae4XAylM8hkoQ+s4TY+UCFrd vbmm8X8qUCA6iU8gCv3Gj29D+f0io3Yh34CPs6zCfwU0KuN88NHrH6UCttxCigvgP+pb PSmQ== X-Gm-Message-State: AElRT7EzXdXmGuv64kuTYEBkmwPTnxAH28/+MKMF7YfiskN+lr8pSgDd RaTQlJhv1hmP+PVEGlKTFCkr1a+e5baLYKiqJwIKvHuC X-Google-Smtp-Source: AIpwx48dHoO2XSuCPYWKan42s+18MUje+o/4AaopLWAGc7GOvtamjr+1gzJtmCwBFRPgMP3O4z7asT7CwisX/wco/Y8= X-Received: by 10.46.144.13 with SMTP id h13mr4210296ljg.115.1522318485995; Thu, 29 Mar 2018 03:14:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:9748:0:0:0:0:0 with HTTP; Thu, 29 Mar 2018 03:14:45 -0700 (PDT) In-Reply-To: <07C79745-DDD1-4544-B95F-D878A477E898@postgresql.org> References: <1237101144.12611.1521809780021.JavaMail.zimbra@dbi-services.com> <5B6B7585-9892-4846-904F-BB5B4A011A7D@postgresql.org> <07C79745-DDD1-4544-B95F-D878A477E898@postgresql.org> From: Magnus Hagander Date: Thu, 29 Mar 2018 12:14:45 +0200 Message-ID: Subject: Re: Blanks in the first line before the first word in the code boxes To: "Jonathan S. Katz" Cc: Peter Eisentraut , Daniel Westermann , pgsql-docs Content-Type: multipart/alternative; boundary="089e0823b26c97ce4005688a64b0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e0823b26c97ce4005688a64b0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 29, 2018 at 4:02 AM, Jonathan S. Katz wrote: > > > On Mar 28, 2018, at 9:47 PM, Peter Eisentraut < > peter.eisentraut@2ndquadrant.com> wrote: > > > > On 3/28/18 21:36, Jonathan S. Katz wrote: > >> > >>> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut > >>> >>> > wrote: > >>>> Yeah, that looks weird. I'll look into it. > >>> > >>> Just looking at a nearby thread ... something is quite whacky with th= e > >>> web site stylesheet. It didn't use to look like this. Check this ou= t: > >>> https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.= 5 > >> > >> Something is adding spaces - it=E2=80=99s within the =E2=80=9C
=E2=
=80=9D tag, which causes
> >> browsers
> >> to interpret each space literally.
> >>
> >> For the case of the =E2=80=9Cdigest=E2=80=9D function, the outputted H=
TML shows the
> >> first digest
> >> function indented, the second one at the start of the new line.
> >
> > Yeah, the spaces are in the source, so it's not a CSS issue.  But it
> > doesn't come out like that if you build the docs locally.  So it's
> > something in the web site code.
>
> If I traced the code correctly, the line I suspect is such:
>
>         s =3D tidy.parseString(contents.encode('utf-8'), **tidyopts)
>
> I know that the web infrastructure recently updated to the Django 1.11
> series, I=E2=80=99m not sure if libtidy or the like were also updated wit=
h that.
> I=E2=80=99ll
> defer to Magnus on that.
>

This would not change with the change to Django 1.11 -- the actual script
that loads the docs runs outside of Django.

Now, the entire machine was upgraded to a new Debian meaning new python,
new tidy etc some time ago. But this was done the first week of February.

Is it possible that this issue actually showed up around 4-5 February, but
just has gone unnoticed since?

--=20
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

--089e0823b26c97ce4005688a64b0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable




On Thu, Mar 29, 2018 at 4:02 AM, Jonathan S. Katz <=
;jkatz@postgresql=
.org> wrote:


> On Mar 28, 2018, at 9:47 PM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com&g=
t; wrote:

>

> On 3/28/18 21:36, Jonathan S. Katz wrote:

>>

>>> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut

>>> <peter.=
eisentraut@2ndquadrant.com

>>> <mailto:peter.eisentraut@2ndquadrant.com>> wrote:

>>>> Yeah, that looks weird.=C2=A0 I'll look into it.

>>>

>>> Just looking at a nearby thread ... something is quite whacky =
with the

>>> web site stylesheet.=C2=A0 It didn't use to look like this=
.=C2=A0 Check this out:

>>> https://www.postg=
resql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5

>>

>> Something is adding spaces - it=E2=80=99s within the =E2=80=9C<=
pre>=E2=80=9D tag, which causes

>> browsers

>> to interpret each space literally.

>>

>> For the case of the =E2=80=9Cdigest=E2=80=9D function, the outputt=
ed HTML shows the

>> first digest

>> function indented, the second one at the start of the new line.
>

> Yeah, the spaces are in the source, so it's not a CSS issue.=C2=A0=
 But it

> doesn't come out like that if you build the docs locally.=C2=A0 So=
 it's

> something in the web site code.



If I traced the code correctly, the line I suspect is such:



=C2=A0 =C2=A0 =C2=A0 =C2=A0 s =3D tidy.parseString(contents.encode(=
9;utf-8'), **tidyopts)



I know that the web infrastructure recently updated to the Django 1.11

series, I=E2=80=99m not sure if libtidy or the like were also updated with =
that. I=E2=80=99ll

defer to Magnus on that.

This would not=
 change with the change to Django 1.11 -- the actual script that loads the =
docs runs outside of Django.

Now, the entire machi=
ne was upgraded to a new Debian meaning new python, new tidy etc some time =
ago. But this was done the first week of February.

Is it possible that this issue actually showed up around 4-5 February, but=
 just has gone unnoticed since?=C2=A0

-- 
=C2=A0Magnus Hagander
=C2=A0Me: https://www.hagander.net/
=C2=A0Work: https://www.redpill-=
linpro.com/



--089e0823b26c97ce4005688a64b0--