Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3p2i-00056S-Tn for pgsql-docs@arkaria.postgresql.org; Wed, 04 Apr 2018 20:30:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3p2h-00046U-Gs for pgsql-docs@arkaria.postgresql.org; Wed, 04 Apr 2018 20:30:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3p2h-00046I-Ak for pgsql-docs@lists.postgresql.org; Wed, 04 Apr 2018 20:30:03 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3p2d-0000cD-R3 for pgsql-docs@postgresql.org; Wed, 04 Apr 2018 20:30:02 +0000 Received: by mail-wr0-x241.google.com with SMTP id l49so24795664wrl.4 for ; Wed, 04 Apr 2018 13:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xKNMJuB32M+kFfN+LgFS9/TiC1A8EcVkttdpKTq4Hwg=; b=irOWQIyIu2z4qs0w3LtMbC305okQsPEKkvZNZf4KcRxyDJD8pYUYErAGOwTBcK49js 9yoAdCK9ytjz26RsRJ7QVpILNo7u7OZnDRrGnF02GBiFV1lGNwZ9ywXLu61dLgw1fEgj AoLYztmm7PtDZey85+DmnqKhO5gnpycAKHGXCZHtyi5nUErkjenF94Lqw3DTfCnJ1sFB WALEU1VaP2q9OVZyno5A+I/gFqNNk1RkxV4GjLhOXfFaT680ht/ip9hfngnsRrTPwxFR fakdfgIrt4C7De2kUBjIGOFaMbdP1j8iYbMbZJXC6ObcWFQDbxlGWgQ9gaQ0VB/lmJgo Y5dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xKNMJuB32M+kFfN+LgFS9/TiC1A8EcVkttdpKTq4Hwg=; b=g5wdtschY9crgqqBiMvFHCyLYhPnZGsautL2PX+dxSipt5MFLzm/n+fMhxAjthcUym HR+6t7d8yXDpcxsRSh7n6OUThNxc5+eweGNVruPS/K25eRRpHjCaA0Ns9hxHducN50Gw pP4ANPym5YdsEL6l6c3F3ar+LT5xdyN1cBXw68H4Yr5OjRL0ckzSGWC7TlnNB4IUGC23 jJArk+ZVMKji5eh4nQLaeAQMjSbBq47v9My2tpNWQKomx+uOveApsQbEEXbZkrRwaJHw vv/NId89FQNqR7KQTYEktEIGg3AD9VYDTWgjzKznEUXPtUwH+E8hK7yWzmN+WaSG+QmC vQgA== X-Gm-Message-State: ALQs6tBMaBn1ypJGdwFRhWv45JEHi6MT8zxyRMS/rrPJrrLjVOHr6tkO UZvSVFJ/oOFAkdRtAWYw5CdeearYziH5AQiVi4cpbA== X-Google-Smtp-Source: AIpwx4+BUcOeURpYl1B6ymW+ld4EwpBuPbYBmX/wV+yq0DXBYjEVNwZGmr+qsHeisOSgkyfZFt0aoqDI3wTkWJO/LA0= X-Received: by 2002:a19:6919:: with SMTP id e25-v6mr11733336lfc.52.1522873798397; Wed, 04 Apr 2018 13:29:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:9748:0:0:0:0:0 with HTTP; Wed, 4 Apr 2018 13:29:57 -0700 (PDT) In-Reply-To: References: <1237101144.12611.1521809780021.JavaMail.zimbra@dbi-services.com> <5B6B7585-9892-4846-904F-BB5B4A011A7D@postgresql.org> <07C79745-DDD1-4544-B95F-D878A477E898@postgresql.org> <13425.1522330858@sss.pgh.pa.us> <60a39b28-485e-1621-79af-fa01cf43b3c6@2ndquadrant.com> <3f249760-fdf7-edb5-d927-6d5a4a1754d0@2ndquadrant.com> From: Magnus Hagander Date: Wed, 4 Apr 2018 22:29:57 +0200 Message-ID: Subject: Re: Blanks in the first line before the first word in the code boxes To: "Jonathan S. Katz" Cc: Peter Eisentraut , Tom Lane , Daniel Westermann , pgsql-docs Content-Type: multipart/alternative; boundary="000000000000caa90105690baf5c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000caa90105690baf5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 4, 2018 at 3:21 PM, Jonathan S. Katz wrote: > > On Apr 3, 2018, at 10:55 AM, Peter Eisentraut < > peter.eisentraut@2ndquadrant.com> wrote: > > On 4/3/18 09:12, Magnus Hagander wrote: > > I've pushed the fix and reloaded the 10 docs. I have not reloaded > earlier branches yet, but I'd be interested in some people reviewing a > bunch of pages in the 10 docs mainly to see if (1) it fixes all the > cases, and (2) it actually breaks some *other* cases. > > > It looks correct now. > > > +1 > > Did a spot check on known broken pages and chose some others at > random. Viewed the 9.6, 10, and devel versions. 10 and devel both > looked correct, and the 9.6 was broken where expected. > > The only thing I saw (and this may be something to look at the SGML > source) was some blocks that looked overly indented, but it was consisten= t > across all versions. On > > https://www.postgresql.org/docs/current/static/queries-with.html > > If you search for "WITH RECURSIVE search_graph(id, link, data, depth)=E2= =80=9D > the expression in the CTE is much more indented than similar CTEs above > it. > > IMV I would not let this stop us from reloading the earlier versions as > that > indentation is consistent across all versions (including 9.6, where it ha= s > the > initial indentation as well). > > I've reloaded docs back to 9.3. --=20 Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/ --000000000000caa90105690baf5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Apr 4, 2018 at 3:21 PM, Jonathan S. Katz <= jkatz@postgresql.= org> wrote:

On Apr 3, 2018, at 10:55 AM, Peter Eisentraut <peter.eisentraut@2ndquadran= t.com> wrote:

On 4/3/18 09:12, Magnus Hagander wrote:
I've pushed the fix and reloaded the 10 docs. I h= ave not reloaded
earlier branches yet, but I'd be interested in some= people reviewing a
bunch of pages in the 10 docs mainly to see if (1) i= t fixes all the
cases, and (2) it actually breaks some *other* cases.=C2= =A0

It looks correct now.

<= /div>
+1

Did a spot check on known brok= en pages and chose some others at
random. Viewed the 9.6, 10, and= devel versions. =C2=A010 and devel both
looked correct, and the = 9.6 was broken where expected.

The only thing I sa= w (and this may be something to look at the SGML
source) was some= blocks that looked overly indented, but it was consistent
across= all versions.=C2=A0 On

https:= //www.postgresql.org/docs/current/static/queries-with.html

If you search for "WITH RECURSIVE search_graph(= id, link, data, depth)=E2=80=9D
the expression in the CTE is much= more indented than similar CTEs above
it.

IMV I would not let this stop us from reloading the earlier versions as = that
indentation is consistent across all versions (including 9.6= , where it has the
initial indentation as well).


I've reloaded docs back to 9.3.=C2=A0


--
=C2=A0Magnus Ha= gander
=C2=A0Me: = https://www.hagander.net/
=C2=A0Work: https://www.redpill-linpro.com/
--000000000000caa90105690baf5c--