Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTUpH-0006Bd-T1 for pgsql-docs@arkaria.postgresql.org; Tue, 28 Apr 2020 18:19:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jTUpG-0003jm-RT for pgsql-docs@arkaria.postgresql.org; Tue, 28 Apr 2020 18:19:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTUpG-0003j4-HV for pgsql-docs@lists.postgresql.org; Tue, 28 Apr 2020 18:19:22 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jTUpC-0004jh-W0 for pgsql-docs@lists.postgresql.org; Tue, 28 Apr 2020 18:19:22 +0000 Received: by mail-lj1-x241.google.com with SMTP id h4so8962796ljg.12 for ; Tue, 28 Apr 2020 11:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aX+r+piS6c+87jptR/KjQ5FzgX+20SFvo7zHP0WZw4o=; b=tG/QvI0UZ/RRCkWfIYKXocBUjsB6O12TQuEIsO0CKcXf7QzNZX8kqdKE5d+axGoSxj qizyH2LzBClA8M4v1CSruwmngw+SD5Fd6YFs/C2vnotdqLr9xKTE0kLg4wKbZSMOschl 2nRuEvlnFEjvvvBkx24XxgDH1gkNxpFzzxywDUedlliefx/6V4eeclDGCc6PFrlziE5e BQ9G4lAZen1jwwjJGmjHPUeY7XOi9rviqziUj6vhyFN32/m6xHdpT2QAWbgSpGKvPzxA 4MxV+KHuKklLLE+DMMBTMeeXFONc9Zb5k77BfC/rhmH6iQIdEWl9mXODD9SWKYTEA3F7 FuNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aX+r+piS6c+87jptR/KjQ5FzgX+20SFvo7zHP0WZw4o=; b=tsNvcGfC4ZwWSTNajRhpYwTnDFo6YfeCSvDUt21wz+og4qRcJizlk8cmov12HzF2E3 BTh0k8/pi0gkauezOZJOA5YSBEZlqMURDt+Cw9NZ0YJttVsLjZL9LRxq9teV64pkUW5X LR+Iaj2A9/dNKempsIWP4lT1NGklks+63/yF/nMWi67xoOlkO+HxtIQ8x+PKKf7daGCt MaZy/+RwcdIaX7LGXIPowFjTL9mbQ5QelFf9y3BXctcVtIJl1C8bQweRjb7rcieYETkT cFgS37ThcLnk+QV0pxyeol7YcCJX5fe7EzTMi0E+mPrj1rbHMNCGRcXotSZahzP1lQG5 cVNA== X-Gm-Message-State: AGi0Pub8KT86jwwitKcXDVEICMINI+x+QMaJTltEx4m4QzVhBPfEFDNh W+Wi5D9kUbdaVhhwOTV+bpXoZXZxAK5trd0TS9BvpQ== X-Google-Smtp-Source: APiQypKz5BGXf6l98Nig0TL3xAfpBcGUSc/p82sYPekVwMNZkMM5b22K4OqIFW1AV62JRANSYAPKFxPGU0tH3xnQGbY= X-Received: by 2002:a2e:b1c9:: with SMTP id e9mr18995550lja.102.1588097958089; Tue, 28 Apr 2020 11:19:18 -0700 (PDT) MIME-Version: 1.0 References: <957c35e3-8023-ebe6-3b51-3a620b66ae82@2ndquadrant.com> <20200124001208.6dessehrm7lgeqwz@rat.local> <20200203204244.GA15678@momjian.us> <3b1f6cb3-4a6c-fff7-59ae-b8ce0a9866d8@postgresql.org> <5982a365-a38a-f81a-003c-f72cb4d7f269@postgresql.org> <20200206051131.GA20009@momjian.us> <41fb663f-96e5-dece-8aba-97d16f395948@postgresql.org> <20200409205716.GB26811@momjian.us> <20200410034523.GA26824@momjian.us> <4490e710-85f7-87a9-74dd-793d27440bed@postgresql.org> In-Reply-To: <4490e710-85f7-87a9-74dd-793d27440bed@postgresql.org> From: Magnus Hagander Date: Tue, 28 Apr 2020 20:19:06 +0200 Message-ID: Subject: Re: Documentation: 21.5. Default Roles To: "Jonathan S. Katz" Cc: Bruce Momjian , R Ransbottom , Ian Barwick , Stephen Frost , Laurenz Albe , Pg Docs Content-Type: multipart/alternative; boundary="000000000000a925cb05a45ddee3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a925cb05a45ddee3 Content-Type: text/plain; charset="UTF-8" On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz wrote: > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > >> On 4/9/20 4:57 PM, Bruce Momjian wrote: > >>> Jonathan, Stephen, with the minor release done, can we focus on adding > >>> the URL redirect and completing the patch to rename this feature in the > >>> docs? Thanks. > >> > >> Yes, I have a prototype for this ready, which I had scrambled together > >> before the release. I am happy to make it committable in the coming > days. > > > > Thanks. Once that is done Stephen can apply my patch with his > > additions. > > Please see attached patch for pgweb that allows for the documentation to > be redirected from a page that is removed to a newer page. The way it > works: > > - Checks to see if a page is found. If it is, great! > - Now if a page 404s, we first check to see if there is a forwarding > address, i.e. the new page. If it is, we issue a 301 (permanent redirecTt). > - If it's still not found, we abort. > > I believe this gives us the desired behavior. > > Thoughts on the patch? > Looks good to me. Go for it. //Magnus --000000000000a925cb05a45ddee3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Apr 25, 2020 at 1:38 AM Jonathan = S. Katz <jkatz@postgresql.org> wrote:
On 4/9/20 11:45 PM, Bruce Momjian wrote:
> On Thu, Apr=C2=A0 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
>>> Jonathan, Stephen, with the minor release done, can we focus o= n adding
>>> the URL redirect and completing the patch to rename this featu= re in the
>>> docs?=C2=A0 Thanks.
>>
>> Yes, I have a prototype for this ready, which I had scrambled toge= ther
>> before the release. I am happy to make it committable in the comin= g days.
>
> Thanks.=C2=A0 Once that is done Stephen can apply my patch with his > additions.

Please see attached patch for pgweb that allows for the documentation to be redirected from a page that is removed to a newer page. The way it works= :

- Checks to see if a page is found. If it is, great!
- Now if a page 404s, we first check to see if there is a forwarding
address, i.e. the new page. If it is, we issue a 301 (permanent redirecTt).=
- If it's still not found, we abort.

I believe this gives us the desired behavior.

Thoughts on the patch?



--000000000000a925cb05a45ddee3--