Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1w8C-00057v-D7 for pgsql-docs@arkaria.postgresql.org; Fri, 30 Mar 2018 15:39:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1w8A-0001BE-LB for pgsql-docs@arkaria.postgresql.org; Fri, 30 Mar 2018 15:39:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1w8A-0001B5-Aa for pgsql-docs@lists.postgresql.org; Fri, 30 Mar 2018 15:39:54 +0000 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1w86-0001mD-Om for pgsql-docs@lists.postgresql.org; Fri, 30 Mar 2018 15:39:53 +0000 Received: by mail-lf0-x233.google.com with SMTP id v207-v6so13020509lfa.10 for ; Fri, 30 Mar 2018 08:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0iv5tZxFX3WvQ3yTXyVauYSz6sBN44mTpBrEX4LiBj8=; b=JVC5WnwDek8FbSZl39kfmzFFfgQZDhlwNGsVfmo59D7uSH/tmpdqg+3OKz8rczIK9t suBaZ/7jqXhpfdRjA8l90bprfZm2tOqgrLDPQlK0m1AC2jGa7Fd44A9FaH6wXF3d1kT/ u553FCh6dmhzhV6VfZHueAuyi6YsFiAYcGOlciOOFSX2s+q5aC3q76dINOmscZte4pfc Z8EzgurdWEgvvK9GGrr86wsVmoGzQbZ4xNaA3VYaK2X+kfiTixaZKH24uIDJEboHjiLI obyO1E6nJVdVDvKOHFU6L++MC+fN0T1LZALXnV9m6YzhBcnRNanAFU2Il0kV1RCUqh/4 Fmzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0iv5tZxFX3WvQ3yTXyVauYSz6sBN44mTpBrEX4LiBj8=; b=VAhtaWv81msra82Rj3COV/kOwg6bwH5JCKUSvoqQr6yNak317HJjRNti/WeyT5EEKG ICHhd5gGhff3dVHLmvdRgSOb4YWgyrSyoV4vZfVNiRkZlEi2QMQ/EKi6OP349PoXw1Pi I8POrkMlg5WVO+NLUZKEzeqFwRcnm/b6crl4JPxjerSAex5pM6ITBGeaj41/xlj+pMif BBC4jXUsWsHxsgzZS1vfHtTQb/Gw6uaSXg9xcXRQPFoNEn9tKKIVVedNC4YIZOybi59m bKCzhMURzr/Vmy0OZYtceBkMWTwU3WPdoKHIA1F2Wp1NnnbYtAJdV9PkIXEw8WbIQECf 4h2A== X-Gm-Message-State: AElRT7GwxLCSUtsxQR/mV48QfcR/YKAxEAOJXnxsRuZRHd5LMY+KSy5o J4PHv9tcMQICnOoNjmd7noLAj8GcNTgyLncc/jeUkQ== X-Google-Smtp-Source: AIpwx49dv/mw7MGN3o1DWfFIqLQOFGJjxxYsJvsVgUfQOmskadxvfkDE2rchmyS9edASzPigeEJ2Dy5jWQWCSVCem8M= X-Received: by 2002:a19:d945:: with SMTP id q66-v6mr8836548lfg.144.1522424387311; Fri, 30 Mar 2018 08:39:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:9748:0:0:0:0:0 with HTTP; Fri, 30 Mar 2018 08:39:46 -0700 (PDT) In-Reply-To: <20180330151828.GL8476@momjian.us> References: <152074343671.1853.18284519607571497106@wrigleys.postgresql.org> <20180330151828.GL8476@momjian.us> From: Magnus Hagander Date: Fri, 30 Mar 2018 17:39:46 +0200 Message-ID: Subject: Re: Documentation for varbit is missing size parameter To: Bruce Momjian Cc: Euler Taveira , scott.ure@caseware.com, pgsql-docs@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000cdc19d0568a30c9b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000cdc19d0568a30c9b Content-Type: text/plain; charset="UTF-8" On Fri, Mar 30, 2018 at 5:18 PM, Bruce Momjian wrote: > On Fri, Mar 16, 2018 at 01:17:04AM -0300, Euler Taveira wrote: > > 2018-03-11 1:43 GMT-03:00 PG Doc comments form : > > > The documentation for the varbit data type is missing the size > parameter "[ > > > (n) ]". > > > > > Good catch! It seems to be an oversight in commit > > 768b647ead78d0d63915c1708cad13c2468f9440. The attached patch adds it. > > Wow, that commit is from 2004. Patch applied and backpatched to v10. > If it goes all the way back to 2004, why not backpatch further? -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/ --000000000000cdc19d0568a30c9b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On F= ri, Mar 30, 2018 at 5:18 PM, Bruce Momjian <bruce@momjian.us>= wrote:
On Fri, Mar 16, = 2018 at 01:17:04AM -0300, Euler Taveira wrote:
> 2018-03-11 1:43 GMT-03:00 PG Doc comments form <noreply@postgresql.org>:
> > The documentation for the varbit data type is missing the size pa= rameter "[
> > (n) ]".
> >
> Good catch! It seems to be an oversight in commit
> 768b647ead78d0d63915c1708cad13c2468f9440. The attached patch adds= it.

Wow, that commit is from 2004.=C2=A0 Patch applied and backpatched t= o v10.

If it goes all the way back to 2= 004, why not backpatch further?
=C2=A0
--
=
=C2=A0Magnus Hagander
=C2=A0Me: https://www.hagander.net/
=C2=A0Work: https://www.redpill-linp= ro.com/
--000000000000cdc19d0568a30c9b--