Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTUvd-0006Oa-5G for pgsql-docs@arkaria.postgresql.org; Tue, 28 Apr 2020 18:25:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jTUvb-0001AW-VD for pgsql-docs@arkaria.postgresql.org; Tue, 28 Apr 2020 18:25:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTUvb-0001AP-OH for pgsql-docs@lists.postgresql.org; Tue, 28 Apr 2020 18:25:55 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jTUvZ-0004nm-LH for pgsql-docs@lists.postgresql.org; Tue, 28 Apr 2020 18:25:55 +0000 Received: by mail-lf1-x144.google.com with SMTP id y3so2115827lfy.1 for ; Tue, 28 Apr 2020 11:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cVTq1End4OlwNgq0ncj/4hO9PqmPnMV0QUJP9t8yV/0=; b=vbttdY7dznhGtVRBVxkNb25X+LK+hTPuNDWWoy63A7lFYegX66ZH1zsPx71EGeoqJJ 4yDGCQWtn4O/nsAo5iwn4l0FzIdXb5kiW5M8n6GYn41cR4vOSCsspZau8YnzRcY5OUA5 LZeZz3fl62WbProvc0Zco1UB/6QxMEepRh/7jdjFatw7hK1fHBGjLyca1BzDXpCDUV6b NfTrj5FXDyIWJ+YpUh5IG2zkXVM2YoknjzsWOLKw+P4kEmjhMQVUX8UBLmTRYyYjy3iP Sc6vqCWZXfb3SY3hVn/h63lwq+jlxDPrFQmHRHR+DNZXRlaUSfkuiTFUG/P6Hb47hj1o FHuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cVTq1End4OlwNgq0ncj/4hO9PqmPnMV0QUJP9t8yV/0=; b=iRHHZEYzYwhtV4jBAxf6yyvAPd8+M3DJYiDuY9cG431MwKDPnohGZvUNrHkqSPVdQI 3AH6iqTyA+Nuq+6EiRlx9ctAUdtdaWsXvwcUe9ZMhQ78aTnCPRnMiTQYeQqpM1OAuo8u cHrJia+ky2++DSE+9v9Y1OvDx2j+gHptP8fEqyLd3Yp+ovAMDSczuDS6moG98me0v/KV ISSUjUdUUuFZ/kErgVSPUFNR3WVEIEKtItUNmeM/FZzO0zQG/MYNfgRCxl3p1u6rK5Ah AWy2EM1gVr+hSkkIUQ699I+TYUNecdw8+n+rSd8nfteu7Z8b4ZzfdF8vz89AiZzVWr6P g0tA== X-Gm-Message-State: AGi0PuYB9+5M8Cb7N2M47ni9alfVqliLjumj2/LZhllbxg+7KtJuZnlg 2kE1dh1sVGmVWKiEMcLizxYmduYlbmUCfx3TH1bILA== X-Google-Smtp-Source: APiQypK6EdrPlQtUoOVYlfvV1A+PtZd0sH052Rb1Q+pb1tBFGBQnzaibWPMl8M8K1kvnLN9C647yQdh6lJ1lMIzXrEA= X-Received: by 2002:a19:e041:: with SMTP id g1mr19631339lfj.70.1588098351121; Tue, 28 Apr 2020 11:25:51 -0700 (PDT) MIME-Version: 1.0 References: <3b1f6cb3-4a6c-fff7-59ae-b8ce0a9866d8@postgresql.org> <5982a365-a38a-f81a-003c-f72cb4d7f269@postgresql.org> <20200206051131.GA20009@momjian.us> <41fb663f-96e5-dece-8aba-97d16f395948@postgresql.org> <20200409205716.GB26811@momjian.us> <20200410034523.GA26824@momjian.us> <4490e710-85f7-87a9-74dd-793d27440bed@postgresql.org> <20200428182022.GI13712@tamriel.snowman.net> In-Reply-To: <20200428182022.GI13712@tamriel.snowman.net> From: Magnus Hagander Date: Tue, 28 Apr 2020 20:25:39 +0200 Message-ID: Subject: Re: Documentation: 21.5. Default Roles To: Stephen Frost Cc: "Jonathan S. Katz" , Bruce Momjian , R Ransbottom , Ian Barwick , Laurenz Albe , Pg Docs Content-Type: multipart/alternative; boundary="0000000000001658c405a45df6b9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001658c405a45df6b9 Content-Type: text/plain; charset="UTF-8" On Tue, Apr 28, 2020 at 8:20 PM Stephen Frost wrote: > Greetings, > > * Magnus Hagander (magnus@hagander.net) wrote: > > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz > > wrote: > > > > > On 4/9/20 11:45 PM, Bruce Momjian wrote: > > > > On Thu, Apr 9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote: > > > >> On 4/9/20 4:57 PM, Bruce Momjian wrote: > > > >>> Jonathan, Stephen, with the minor release done, can we focus on > adding > > > >>> the URL redirect and completing the patch to rename this feature > in the > > > >>> docs? Thanks. > > > >> > > > >> Yes, I have a prototype for this ready, which I had scrambled > together > > > >> before the release. I am happy to make it committable in the coming > > > days. > > > > > > > > Thanks. Once that is done Stephen can apply my patch with his > > > > additions. > > > > > > Please see attached patch for pgweb that allows for the documentation > to > > > be redirected from a page that is removed to a newer page. The way it > > > works: > > > > > > - Checks to see if a page is found. If it is, great! > > > - Now if a page 404s, we first check to see if there is a forwarding > > > address, i.e. the new page. If it is, we issue a 301 (permanent > redirecTt). > > > - If it's still not found, we abort. > > > > > > I believe this gives us the desired behavior. > > > > > > Thoughts on the patch? > > > > Looks good to me. Go for it. > > What's the plan for how to maintain it going forward? Just email -docs > and ask someone to perform the update whenever a release is going out..? > Or do we have some kind of better process in mind? > > GIven how seldom this happens, I think that's perfectly fine. Same as we already do with the page aliases. //Magnus --0000000000001658c405a45df6b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Apr 28, 2020 at 8:20 PM Stephen F= rost <sfrost@snowman.net> w= rote:
Greetings,

* Magnus Hagander (magnus@hagander.net) wrote:
> On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz <jkatz@postgresql.org>
> wrote:
>
> > On 4/9/20 11:45 PM, Bruce Momjian wrote:
> > > On Thu, Apr=C2=A0 9, 2020 at 08:47:56PM -0400, Jonathan Katz= wrote:
> > >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> > >>> Jonathan, Stephen, with the minor release done, can = we focus on adding
> > >>> the URL redirect and completing the patch to rename = this feature in the
> > >>> docs?=C2=A0 Thanks.
> > >>
> > >> Yes, I have a prototype for this ready, which I had scra= mbled together
> > >> before the release. I am happy to make it committable in= the coming
> > days.
> > >
> > > Thanks.=C2=A0 Once that is done Stephen can apply my patch w= ith his
> > > additions.
> >
> > Please see attached patch for pgweb that allows for the documenta= tion to
> > be redirected from a page that is removed to a newer page. The wa= y it
> > works:
> >
> > - Checks to see if a page is found. If it is, great!
> > - Now if a page 404s, we first check to see if there is a forward= ing
> > address, i.e. the new page. If it is, we issue a 301 (permanent r= edirecTt).
> > - If it's still not found, we abort.
> >
> > I believe this gives us the desired behavior.
> >
> > Thoughts on the patch?
>
>=C2=A0 Looks good to me. Go for it.

What's the plan for how to maintain it going forward?=C2=A0 Just email = -docs
and ask someone to perform the update whenever a release is going out..? Or do we have some kind of better process in mind?


GIven how seldom this happens, I think that's perfectly= fine. Same as we already do with the page aliases.

//Magnus=C2=A0
--0000000000001658c405a45df6b9--