Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3Lmm-0001MM-79 for pgsql-docs@arkaria.postgresql.org; Tue, 03 Apr 2018 13:15:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3Lml-0008Ok-3o for pgsql-docs@arkaria.postgresql.org; Tue, 03 Apr 2018 13:15:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3LjZ-0006Ha-Ar for pgsql-docs@lists.postgresql.org; Tue, 03 Apr 2018 13:12:21 +0000 Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3LjR-0007Ay-R8 for pgsql-docs@postgresql.org; Tue, 03 Apr 2018 13:12:20 +0000 Received: by mail-lf0-x22a.google.com with SMTP id o102-v6so20101147lfg.8 for ; Tue, 03 Apr 2018 06:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iCfHbtZru9+KDHjuby/1mz/ES6n5TGgSl5iI+nTahNs=; b=BRFzavrMNzrW+79Hra3nG+RkwTaSde6nXIUioixM6govu+eqT6SAY7xVw91XkVznno 92rwTpKmoGBU4tqxLqiF3SeOmJ4KhF3oPsF3A+paLSbIs06nr8bDMDbLXjzL5uKDy6BN pSnqtrkSVP0BIfdTTbw+4/6YcdTqakMD4PCU50LbkdX87Ybn9IcCjAteBzeVrK4S5gbC 0gRcC0FGQYpVU5xV/KZFXMbRp9Ano+yvCVpsYtS6IRAxdPq6WsghdKo7aiWBRzihAoCw OsxA/tMSR+d2RqNVM2fRTV5xhZxkYGysmpXFWUADglkixPFw9xok5fehXVmE9mW9cg7b ecnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iCfHbtZru9+KDHjuby/1mz/ES6n5TGgSl5iI+nTahNs=; b=QvSr+J7PcFn97hwKdpZP04qe55ikm3WqEktX6eV7NtwCq9mzjbN7xIJCzvWG0rRBEJ Yj5r6Lz44TsKKn7avipkH/cEYM9kvYipLBsoJ5mfKP9GE6AjnBuvCqQxb407LYgmoSv8 81hEaVYl4OmhrF2flTx7dCQHnOC9Ya9yzNdeDJdudDNE3J8YLK/WrJtT0Bs/SCHxc2j4 SaBstUalboEDh6pB3eT48xUctTr5hGez5hE6smzmkM3u6ziuWDh8rZIpN4PRnDPMkRuU j48LOjP7KzZNK8NJ6+PDHT4lzZDTT1AOmIAQ8cZtQjvdRx5fP5xMnvtcFv7PSigmMO+5 1qgQ== X-Gm-Message-State: ALQs6tDxKvP4kRStBdi98iTdg/jZ/IP9ZDylkX75Zb+EFxBPhDVh/yNf cGN06gqQnC/FpzAg3DphLEr542+hmoD9HOLaBibKFhaA X-Google-Smtp-Source: AIpwx4+BuWY1IuiHIPPD+nM54Vf8av0l3cMogOZ+tUL+w7KN2uaYDkybMShWHVrkNxo8ISgLvWwJhmel735rOx8okqU= X-Received: by 10.46.146.87 with SMTP id v23mr8844021ljg.147.1522761132902; Tue, 03 Apr 2018 06:12:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:9748:0:0:0:0:0 with HTTP; Tue, 3 Apr 2018 06:12:12 -0700 (PDT) In-Reply-To: <60a39b28-485e-1621-79af-fa01cf43b3c6@2ndquadrant.com> References: <1237101144.12611.1521809780021.JavaMail.zimbra@dbi-services.com> <5B6B7585-9892-4846-904F-BB5B4A011A7D@postgresql.org> <07C79745-DDD1-4544-B95F-D878A477E898@postgresql.org> <13425.1522330858@sss.pgh.pa.us> <60a39b28-485e-1621-79af-fa01cf43b3c6@2ndquadrant.com> From: Magnus Hagander Date: Tue, 3 Apr 2018 15:12:12 +0200 Message-ID: Subject: Re: Blanks in the first line before the first word in the code boxes To: Peter Eisentraut Cc: Tom Lane , "Jonathan S. Katz" , Daniel Westermann , pgsql-docs Content-Type: multipart/alternative; boundary="089e0823b0d4679ce60568f17473" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e0823b0d4679ce60568f17473 Content-Type: text/plain; charset="UTF-8" On Mon, Apr 2, 2018 at 5:59 PM, Peter Eisentraut < peter.eisentraut@2ndquadrant.com> wrote: > On 4/1/18 11:55, Magnus Hagander wrote: > > However, why does devel work fine when the others are broken. It's the > > exact same code that's run to load the docs. The *input* to the loader > > must also be different at some point. > > In devel, the raw HTML output looks like > > ... 
> ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (with a line break)
>
> but before it looks like
>
> ... 
ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (without a line break).
>
> So maybe some part of the processing code thinks it should do some kind
> of "indentation" here.
>
>
I think I found the problem, and pushed a fix for it. Basically it turns
off indentation completely on pre-11 versions., I elected to keep indention
on dev because it works there, and it makes debugging any of the formatting
a lot easier.

I've pushed the fix and reloaded the 10 docs. I have not reloaded earlier
branches yet, but I'd be interested in some people reviewing a bunch of
pages in the 10 docs mainly to see if (1) it fixes all the cases, and (2)
it actually breaks some *other* cases.


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

--089e0823b0d4679ce60568f17473
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


On M=
on, Apr 2, 2018 at 5:59 PM, Peter Eisentraut <peter.eisent=
raut@2ndquadrant.com> wrote:
On 4/1/18 11:55, Magnus Hagander wrote:

> However, why does devel work fine when the others are broken. It's=
 the

> exact same code that's run to load the docs. The *input* to the lo=
ader

> must also be different at some point.



In devel, the raw HTML output looks like



... <pre class=3D"synopsis">

ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...



(with a line break)



but before it looks like



... <pre class=3D"synopsis">ALTER FOREIGN TABLE [ IF EXISTS=
 ] [ ONLY ] ...



(without a line break).



So maybe some part of the processing code thinks it should do some kind

of "indentation" here.



<=
br>
I think I found the problem, and pushed a fix for it. Basical=
ly it turns off indentation completely on pre-11 versions., I elected to ke=
ep indention on dev because it works there, and it makes debugging any of t=
he formatting a lot easier.

I've pushed the fi=
x and reloaded the 10 docs. I have not reloaded earlier branches yet, but I=
'd be interested in some people reviewing a bunch of pages in the 10 do=
cs mainly to see if (1) it fixes all the cases, and (2) it actually breaks =
some *other* cases.=C2=A0


-- 
=C2=A0Magnus Hagander
=C2=A0Me: https://www.hagander.net/
=C2=A0Work: =
https://www.re=
dpill-linpro.com/




--089e0823b0d4679ce60568f17473--