public inbox for [email protected]
help / color / mirror / Atom feedFrom: Magnus Hagander <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Documentation for varbit is missing size parameter
Date: Fri, 30 Mar 2018 18:28:15 +0200
Message-ID: <CABUevEyumGh3r05U3_mhRrEU=dfacdRr2HEw140MvN7FSBMSyw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAHE3wgg1k5w2M4h6MjSD8tGBVVABiCooXx+VfQaVzwoUAuDFRA@mail.gmail.com>
<[email protected]>
<CABUevEwrn32xWezTNmmUT-7hGcENXRohDYwHnt8MqNm--o0FaA@mail.gmail.com>
<[email protected]>
On Fri, Mar 30, 2018 at 6:26 PM, Bruce Momjian <[email protected]> wrote:
> On Fri, Mar 30, 2018 at 05:39:46PM +0200, Magnus Hagander wrote:
> > On Fri, Mar 30, 2018 at 5:18 PM, Bruce Momjian <[email protected]> wrote:
> >
> > On Fri, Mar 16, 2018 at 01:17:04AM -0300, Euler Taveira wrote:
> > > 2018-03-11 1:43 GMT-03:00 PG Doc comments form <
> [email protected]>:
> > > > The documentation for the varbit data type is missing the size
> > parameter "[
> > > > (n) ]".
> > > >
> > > Good catch! It seems to be an oversight in commit
> > > 768b647ead78d0d63915c1708cad13c2468f9440. The attached patch adds
> it.
> >
> > Wow, that commit is from 2004. Patch applied and backpatched to v10.
> >
> >
> > If it goes all the way back to 2004, why not backpatch further?
>
> Uh, I am always debating how important it is to backpatck vs the churn
> we require of translations of our docs. In this case, it didn't seem
> worthwhile to have all of those translations try to deal with this
> change for all those back branches.
>
>
If it's a clean backpatch I'd say it is -- people who are using PostgreSQL
9.6 will be reading the documentation for 9.6 etc, so they will not know
about the fix then.
If it's not a clean backpatch I can certainly see considering it, but if
it's not a lot of effort then I'd say it's definitely worth it.
I really don't think considerations for translators of the *docs* are an
issue here. If you don't backpatch it, then nobody gets the fix. If you
backpatch it, then English readers do get the fix, and translated docs
readers *might* get the fix, depending on how they are maintained. It's not
like translatable strings where if they change in a backbranch they will
revert to English unless the translation is updated -- for the docs, they
just don't get the fix.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Documentation for varbit is missing size parameter
In-Reply-To: <CABUevEyumGh3r05U3_mhRrEU=dfacdRr2HEw140MvN7FSBMSyw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox